From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 109B0C43334 for ; Thu, 21 Jul 2022 10:27:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233272AbiGUK1s (ORCPT ); Thu, 21 Jul 2022 06:27:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233250AbiGUK1n (ORCPT ); Thu, 21 Jul 2022 06:27:43 -0400 Received: from 19.mo581.mail-out.ovh.net (19.mo581.mail-out.ovh.net [178.33.251.118]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BE13747AA for ; Thu, 21 Jul 2022 03:27:41 -0700 (PDT) Received: from player697.ha.ovh.net (unknown [10.108.4.72]) by mo581.mail-out.ovh.net (Postfix) with ESMTP id B344C24211 for ; Thu, 21 Jul 2022 06:51:21 +0000 (UTC) Received: from RCM-web2.webmail.mail.ovh.net (ip-194-187-74-233.konfederacka.maverick.com.pl [194.187.74.233]) (Authenticated sender: rafal@milecki.pl) by player697.ha.ovh.net (Postfix) with ESMTPSA id 65D0E2CD2F359; Thu, 21 Jul 2022 06:51:09 +0000 (UTC) MIME-Version: 1.0 Date: Thu, 21 Jul 2022 08:51:09 +0200 From: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= To: Krzysztof Kozlowski Cc: William Zhang , Linux ARM List , joel.peshkin@broadcom.com, dan.beygelman@broadcom.com, Rob Herring , Krzysztof Kozlowski , Anand Gore , Kursad Oney , Florian Fainelli , Broadcom internal kernel review list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [RESEND PATCH 2/9] dt-bindings: arm64: bcmbca: Update BCM4908 description In-Reply-To: References: <20220721000658.29537-1-william.zhang@broadcom.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <883c2ad4c36220b488519a8902ad72bc@milecki.pl> X-Sender: rafal@milecki.pl X-Originating-IP: 194.187.74.233 X-Webmail-UserID: rafal@milecki.pl Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 17827780602349661147 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrudelkedgudeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepggffhffvvefujghffgfkgihitgfgsehtjehjtddtredvnecuhfhrohhmpeftrghfrghlpgfoihhlvggtkhhiuceorhgrfhgrlhesmhhilhgvtghkihdrphhlqeenucggtffrrghtthgvrhhnpeegvdffjeelvdeggeetheegveejieetgeeiiefggeelveejffehieekhfduueelhfenucfkpheptddrtddrtddrtddpudelgedrudekjedrjeegrddvfeefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehplhgrhigvrheileejrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheprhgrfhgrlhesmhhilhgvtghkihdrphhlpdhnsggprhgtphhtthhopedupdhrtghpthhtohepuggvvhhitggvthhrvggvsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdfovfetjfhoshhtpehmohehkedu Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2022-07-21 08:44, Krzysztof Kozlowski wrote: > On 21/07/2022 02:06, William Zhang wrote: >> Append "brcm,bcmbca" to BCM4908 chip family compatible strings. Add >> generic 4908 board entry. > > This does not explain at all why you are doing it. Improve your commit > messages. To clarify it from my side (and maybe help a bit): 1. As I understand it BCMBCA is a one big family of SoCs. 2. BCM4908 is a subset of that family (a subfamily?) designed for a specific group of devices. If that's correct I think William it's what you should describe in your commit message. That would make binding more accurate and should be a good argument for your change (I believe).