From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
dmaengine@vger.kernel.org, imx@lists.linux.dev,
krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org,
peng.fan@nxp.com, robh@kernel.org, vkoul@kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: dma: fsl-edma: allow 'power-domains' property
Date: Sat, 2 Mar 2024 14:59:39 +0100 [thread overview]
Message-ID: <885501b5-0364-48bd-bc1d-3bc486d1b4c6@linaro.org> (raw)
In-Reply-To: <20240301214536.958869-2-Frank.Li@nxp.com>
On 01/03/2024 22:45, Frank Li wrote:
> Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need
> it.
>
> Fixed below DTB_CHECK warning:
> dma-controller@599f0000: Unevaluated properties are not allowed ('power-domains' was unexpected)
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>
> Notes:
> Change from v1 to v2
> - using maxitem: 64. Each channel have one power domain. Max 64 dmachannel.
> - add power-domains to 'required' when compatible string is fsl,imx8qm-adma
> or fsl,imx8qm-edma
>
> .../devicetree/bindings/dma/fsl,edma.yaml | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> index cf0aa8e6b9ec3..76c1716b8b95c 100644
> --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> @@ -59,6 +59,10 @@ properties:
> minItems: 1
> maxItems: 2
>
> + power-domains:
> + minItems: 1
> + maxItems: 64
Hm, this is odd. Blocks do not belong to almost infinite number of power
domains.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-02 13:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 21:45 [PATCH v2 1/2] dt-bindings: dma: fsl-edma: remove 'clocks' from required Frank Li
2024-03-01 21:45 ` [PATCH v2 2/2] dt-bindings: dma: fsl-edma: allow 'power-domains' property Frank Li
2024-03-02 13:59 ` Krzysztof Kozlowski [this message]
2024-03-02 15:42 ` Frank Li
2024-03-02 16:20 ` Krzysztof Kozlowski
2024-03-02 16:39 ` Frank Li
2024-03-02 16:43 ` Krzysztof Kozlowski
2024-03-02 16:47 ` Frank Li
2024-03-03 7:55 ` Krzysztof Kozlowski
2024-03-04 3:26 ` Frank Li
2024-03-04 7:23 ` Krzysztof Kozlowski
2024-03-04 15:24 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=885501b5-0364-48bd-bc1d-3bc486d1b4c6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).