From: Florian Fainelli <f.fainelli@gmail.com>
To: "Linus Walleij" <linus.walleij@linaro.org>,
"Andrew Lunn" <andrew@lunn.ch>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Marek Behún" <kabel@kernel.org>
Cc: Christian Marangi <ansuelsmth@gmail.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v7 3/7] ARM: dts: marvell: Fix some common switch mistakes
Date: Tue, 24 Oct 2023 09:35:43 -0700 [thread overview]
Message-ID: <885ec5bd-9c0e-4c03-9347-f88e29c5691c@gmail.com> (raw)
In-Reply-To: <20231024-marvell-88e6152-wan-led-v7-3-2869347697d1@linaro.org>
On 10/24/23 06:20, Linus Walleij wrote:
> Fix some errors in the Marvell MV88E6xxx switch descriptions:
> - The top node had no address size or cells.
> - switch0@0 is not OK, should be ethernet-switch@0.
> - The ports node should be named ethernet-ports
> - The ethernet-ports node should have port@0 etc children, no
> plural "ports" in the children.
> - Ports should be named ethernet-port@0 etc
> - PHYs should be named ethernet-phy@0 etc
>
> This serves as an example of fixes needed for introducing a
> schema for the bindings, but the patch can simply be applied.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
next prev parent reply other threads:[~2023-10-24 16:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 13:20 [PATCH net-next v7 0/7] Create a binding for the Marvell MV88E6xxx DSA switches Linus Walleij
2023-10-24 13:20 ` [PATCH net-next v7 1/7] dt-bindings: net: dsa: Require ports or ethernet-ports Linus Walleij
2023-10-24 16:34 ` Florian Fainelli
2023-10-25 13:02 ` Krzysztof Kozlowski
2023-10-24 13:20 ` [PATCH net-next v7 2/7] dt-bindings: net: mvusb: Fix up DSA example Linus Walleij
2023-10-24 16:34 ` Florian Fainelli
2023-10-24 13:20 ` [PATCH net-next v7 3/7] ARM: dts: marvell: Fix some common switch mistakes Linus Walleij
2023-10-24 16:35 ` Florian Fainelli [this message]
2023-10-24 13:20 ` [PATCH net-next v7 4/7] ARM: dts: nxp: " Linus Walleij
2023-10-24 16:36 ` Florian Fainelli
2023-10-24 13:20 ` [PATCH net-next v7 5/7] ARM64: dts: marvell: " Linus Walleij
2023-10-24 16:37 ` Florian Fainelli
2023-10-24 18:28 ` Vladimir Oltean
2023-10-24 19:03 ` Russell King (Oracle)
2023-10-24 19:51 ` Vladimir Oltean
2023-10-25 19:52 ` Linus Walleij
2023-10-24 20:10 ` Chris Packham
2023-10-24 20:20 ` Vladimir Oltean
2023-10-25 19:48 ` Linus Walleij
2023-10-25 20:56 ` Linus Walleij
2023-10-25 21:21 ` Andrew Lunn
2023-10-24 13:20 ` [PATCH net-next v7 6/7] dt-bindings: marvell: Rewrite MV88E6xxx in schema Linus Walleij
2023-10-24 16:39 ` Florian Fainelli
2023-10-24 13:20 ` [PATCH net-next v7 7/7] dt-bindings: marvell: Add Marvell MV88E6060 DSA schema Linus Walleij
2023-10-24 16:40 ` Florian Fainelli
2023-10-25 9:30 ` [PATCH net-next v7 0/7] Create a binding for the Marvell MV88E6xxx DSA switches patchwork-bot+netdevbpf
2023-10-25 9:36 ` Vladimir Oltean
2023-10-25 14:29 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=885ec5bd-9c0e-4c03-9347-f88e29c5691c@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=gregory.clement@bootlin.com \
--cc=kabel@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).