From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Arseniy Krasnov <avkrasnov@sberdevices.ru>,
Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Liang Yang <liang.yang@amlogic.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
oxffffaa@gmail.com, kernel@sberdevices.ru,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] dt-bindings: nand: meson: Fix 'nand-rb' property
Date: Wed, 7 Jun 2023 17:07:43 +0200 [thread overview]
Message-ID: <88740a95-d7b0-e5d0-62db-65b41c66c5bc@linaro.org> (raw)
In-Reply-To: <57ccf7ac-7d94-8a66-7a0e-abfe14f7df2c@sberdevices.ru>
On 07/06/2023 16:55, Arseniy Krasnov wrote:
>>>> The bindings and your driver internal representation are two different
>>>> things. Anyway, as mentioned above, wiring the RB line to one die and
>>>> not the other would be valid hardware design and would require the rb
>>>> property to be in the chip node. Please perform a per-chip property read
>>>> in the driver as well.
>>>
>>> Done, I resend both patches (bindings + driver update) as a single patchset. Your review comments
>>> for driver code were also fixed.
>>
>> No, please send new version, not the same. New version means with fixed
>> comments and with patch changelog.
>
> Sorry, Yes, I mean new version, here it is:
> https://lore.kernel.org/linux-mtd/20230607145026.2899547-1-AVKrasnov@sberdevices.ru/
>
> There I fixed bindings and tested it.
I still see v1 and there is no changelog. So it's the same?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-07 15:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 19:35 [PATCH v1] dt-bindings: nand: meson: Fix 'nand-rb' property Arseniy Krasnov
2023-06-06 20:12 ` Rob Herring
2023-06-07 7:58 ` Miquel Raynal
2023-06-07 8:40 ` Arseniy Krasnov
2023-06-07 8:53 ` Krzysztof Kozlowski
2023-06-07 8:57 ` Arseniy Krasnov
2023-06-07 9:08 ` Krzysztof Kozlowski
2023-06-07 9:04 ` Arseniy Krasnov
2023-06-07 9:36 ` Miquel Raynal
2023-06-07 14:52 ` Arseniy Krasnov
2023-06-07 14:58 ` Krzysztof Kozlowski
2023-06-07 14:55 ` Arseniy Krasnov
2023-06-07 15:07 ` Krzysztof Kozlowski [this message]
2023-06-07 15:21 ` Arseniy Krasnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88740a95-d7b0-e5d0-62db-65b41c66c5bc@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=avkrasnov@sberdevices.ru \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=liang.yang@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=miquel.raynal@bootlin.com \
--cc=neil.armstrong@linaro.org \
--cc=oxffffaa@gmail.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).