From: Marek Vasut <marex@denx.de>
To: Alexandre TORGUE <alexandre.torgue@foss.st.com>,
Olivier Moysan <olivier.moysan@foss.st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 1/1] ARM: dts: stm32: fix AV96 board SAI2B pin muxing on stm32mp15
Date: Thu, 30 Sep 2021 17:13:09 +0200 [thread overview]
Message-ID: <88867104-97f5-1c5f-506a-cfcac0962e55@denx.de> (raw)
In-Reply-To: <9b278eb2-7ca9-0e4b-ecb1-5949ce3c5c10@foss.st.com>
On 9/30/21 5:05 PM, Alexandre TORGUE wrote:
> On 9/30/21 12:26 PM, Marek Vasut wrote:
>> On 9/30/21 10:47 AM, Alexandre TORGUE wrote:
>>> Hi Marek
>>>
>>> On 9/29/21 1:18 PM, Marek Vasut wrote:
>>>> On 9/27/21 1:45 PM, Olivier Moysan wrote:
>>>>> Fix SAI2B pin muxing for AV96 board on STM32MP15.
>>>>> The label "sai2a-4" is defined twice. Change redundant label to
>>>>> "sai2b-4".
>>>>>
>>>>> Fixes: dcf185ca8175 ("ARM: dts: stm32: Add alternate pinmux for
>>>>> SAI2 pins on stm32mp15")
>>>>>
>>>>> Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
>>>>> ---
>>>>> arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
>>>>> b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
>>>>> index 5b60ecbd718f..b9cc9e0dd4fc 100644
>>>>> --- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
>>>>> +++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
>>>>> @@ -1235,7 +1235,7 @@
>>>>> };
>>>>> };
>>>>> - sai2b_pins_c: sai2a-4 {
>>>>> + sai2b_pins_c: sai2b-4 {
>>>>> pins1 {
>>>>> pinmux = <STM32_PINMUX('F', 11, AF10)>; /* SAI2_SD_B */
>>>>> bias-disable;
>>>>
>>>> This mp1 pinmuxing is a total mess, sigh.
>>>
>>> What is the issue here ?
>>
>> The same-old discussion about where to place the pinmux nodes, whether
>> we should have these clusters of pre-defined options in
>> ...pinctrl.dtsi, or whether we should do more nxp-like per-board
>> configuration.
>
> ok it's a bit more precise. Honestly I don't understand why the current
> topology is an issue here. Maybe pinctrl SAI nodes names are not well
> chosen or are not enough explicit. Concerning our topology and the NXP
> ones both exists and both have advantages and drawbacks. For ST boards
> (DK/EV) we want to keep all configs in the same place.
>
> As I prefer to not re open this topic again and again, feel free to add
> your pin config in your dts board file, I'll accept it.
Yes, let's not reopen it. I'm sorry if my grumbling came across as too
strong.
prev parent reply other threads:[~2021-09-30 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 11:45 [PATCH 1/1] ARM: dts: stm32: fix AV96 board SAI2B pin muxing on stm32mp15 Olivier Moysan
2021-09-29 11:18 ` Marek Vasut
2021-09-30 8:47 ` Alexandre TORGUE
2021-09-30 10:26 ` Marek Vasut
2021-09-30 15:05 ` Alexandre TORGUE
2021-09-30 15:13 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88867104-97f5-1c5f-506a-cfcac0962e55@denx.de \
--to=marex@denx.de \
--cc=alexandre.torgue@foss.st.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=olivier.moysan@foss.st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).