From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 280CDC433EF for ; Sun, 20 Feb 2022 09:36:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243577AbiBTJhI (ORCPT ); Sun, 20 Feb 2022 04:37:08 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:45706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232929AbiBTJhH (ORCPT ); Sun, 20 Feb 2022 04:37:07 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E42526D1 for ; Sun, 20 Feb 2022 01:36:46 -0800 (PST) Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 60A183F1F6 for ; Sun, 20 Feb 2022 09:36:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1645349805; bh=LePQseFU9KkFZIr2PZSkEhdx+6kX03cW7zQvAw4RWg4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ptv8vRiUqdidh0ZYmzUWNsMvckJFHiwwbToALjOvFAvgcYlIbPUqYR0SZ88o1QQc0 FNpkk0c7EqesB5hrPrxOuiop5rttWeGtUNCOvkKc70xWmDOGSGB0/Lln0nQ6ux0Rc+ FOj1b2MQ+clEn3xnshocQtFiEwHfRYvd104ylPznnomk2aidylCJEFrrSqLYbKlarW 0K3kZty07s7LD0Lea/7yxXqdGTzTuP6we8W6nXNu8LEpd5YHAxV+JkkvX57ECFifAo GxJxILQV7DPi+tii6Y9KYij8m0LLXI0qN93IZ6O3AkW07LAaPauZkmB3TcgxUuTXWd 3qUIaX0ocsy0A== Received: by mail-ed1-f71.google.com with SMTP id g5-20020a056402090500b0040f28e1da47so8431765edz.8 for ; Sun, 20 Feb 2022 01:36:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=LePQseFU9KkFZIr2PZSkEhdx+6kX03cW7zQvAw4RWg4=; b=QAANhQJTQDogiig9AHokD24pIIOqB5wsz/BD2HsmIqH7sazWOFAwTQeeWEK2EMxOVk uKYKWXROhC9DBRdQFiPdpvK83DLdWte+CWT4ooZhLpaoutMd13xXk61uJBxaEw/AQJmg qaEDlADXB2sniOsEOU3YIjxY1G99yWuaEPTianZbLTRLKOSlDlJ0Mpk6l16qlVLk//0z 28C0mJ5c7vT3hKGN17q4ioQNdpbmz2eruJMQBk/Zgc7Ec+dSHthAc596Qnb6T/Ggq5tT s0vhP8PuBG7fvjjLUe4mSTOEGqMXflL9krEzon2kA5Di1325Gr0jI7W9aIJ2QO2JlLkG 24vA== X-Gm-Message-State: AOAM533O5s+OOdgvBV6z1pS9fsZIwOlbBfslK7/sstSvQCDi6kzk1NLX KKYsIq2iv2qzMI6R31sz0n+sF+5apUMqX2teMw7xhNdlajceKyYdxMZJ+/k/mvM2EKmaEqfztdi d300vnOdwIvia9i1YO2uWfQYHOVEw/iClbMiFGKo= X-Received: by 2002:a5d:6d0e:0:b0:1e2:fa3d:7f22 with SMTP id e14-20020a5d6d0e000000b001e2fa3d7f22mr11961928wrq.142.1645349794241; Sun, 20 Feb 2022 01:36:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJwirmZy7S2pWU943BOtjlEkOfxkLQLpQso7yDIB5X+bes0fyRGnOL9B7PBSY3OljiTG2BQN2g== X-Received: by 2002:a5d:6d0e:0:b0:1e2:fa3d:7f22 with SMTP id e14-20020a5d6d0e000000b001e2fa3d7f22mr11961910wrq.142.1645349794068; Sun, 20 Feb 2022 01:36:34 -0800 (PST) Received: from [192.168.0.117] (xdsl-188-155-181-108.adslplus.ch. [188.155.181.108]) by smtp.gmail.com with ESMTPSA id l15sm4308967wmi.29.2022.02.20.01.36.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Feb 2022 01:36:33 -0800 (PST) Message-ID: <888977e0-03bb-3a6b-eca3-7fbf35f53ffc@canonical.com> Date: Sun, 20 Feb 2022 10:36:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 11/11] i2c: npcm: Support NPCM845 Content-Language: en-US To: Tyrone Ting , avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org, semen.protsenko@linaro.org, yangyicong@hisilicon.com, wsa@kernel.org, jie.deng@intel.com, sven@svenpeter.dev, bence98@sch.bme.hu, christophe.leroy@csgroup.eu, lukas.bulwahn@gmail.com, olof@lixom.net, arnd@arndb.de, digetx@gmail.com, andriy.shevchenko@linux.intel.com, tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com Cc: openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220220035321.3870-1-warp5tw@gmail.com> <20220220035321.3870-12-warp5tw@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220220035321.3870-12-warp5tw@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/02/2022 04:53, Tyrone Ting wrote: > From: Tyrone Ting > > Add NPCM8XX I2C support. > The NPCM8XX uses a similar i2c module as NPCM7XX. > The internal HW FIFO is larger in NPCM8XX. > > Signed-off-by: Tyrone Ting > Signed-off-by: Tali Perry > --- > drivers/i2c/busses/Kconfig | 8 +-- > drivers/i2c/busses/Makefile | 2 +- > drivers/i2c/busses/i2c-npcm7xx.c | 87 ++++++++++++++++++++++---------- > 3 files changed, 66 insertions(+), 31 deletions(-) > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index 42da31c1ab70..ab9ee2de5e00 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -817,13 +817,13 @@ config I2C_NOMADIK > I2C interface from ST-Ericsson's Nomadik and Ux500 architectures, > as well as the STA2X11 PCIe I/O HUB. > > -config I2C_NPCM7XX > +config I2C_NPCM > tristate "Nuvoton I2C Controller" > - depends on ARCH_NPCM7XX || COMPILE_TEST > + depends on ARCH_NPCM || COMPILE_TEST > help > If you say yes to this option, support will be included for the > - Nuvoton I2C controller, which is available on the NPCM7xx BMC > - controller. > + Nuvoton I2C controller, which is available on the NPCM BMC > + controllers. > Driver can also support slave mode (select I2C_SLAVE). > > config I2C_OCORES > diff --git a/drivers/i2c/busses/Makefile b/drivers/i2c/busses/Makefile > index 1d00dce77098..01fdf74a5565 100644 > --- a/drivers/i2c/busses/Makefile > +++ b/drivers/i2c/busses/Makefile > @@ -80,7 +80,7 @@ obj-$(CONFIG_I2C_MT7621) += i2c-mt7621.o > obj-$(CONFIG_I2C_MV64XXX) += i2c-mv64xxx.o > obj-$(CONFIG_I2C_MXS) += i2c-mxs.o > obj-$(CONFIG_I2C_NOMADIK) += i2c-nomadik.o > -obj-$(CONFIG_I2C_NPCM7XX) += i2c-npcm7xx.o > +obj-$(CONFIG_I2C_NPCM) += i2c-npcm7xx.o > obj-$(CONFIG_I2C_OCORES) += i2c-ocores.o > obj-$(CONFIG_I2C_OMAP) += i2c-omap.o > obj-$(CONFIG_I2C_OWL) += i2c-owl.o > diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c > index 2cbf9c679aed..b281e0424e3e 100644 > --- a/drivers/i2c/busses/i2c-npcm7xx.c > +++ b/drivers/i2c/busses/i2c-npcm7xx.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -91,7 +92,7 @@ enum i2c_addr { > > /* init register and default value required to enable module */ > #define NPCM_I2CSEGCTL 0xE4 > -#define NPCM_I2CSEGCTL_INIT_VAL 0x0333F000 > +#define NPCM_I2CSEGCTL_INIT_VAL bus->data->segctl_init_val > > /* Common regs */ > #define NPCM_I2CSDA 0x00 > @@ -228,8 +229,7 @@ static const int npcm_i2caddr[I2C_NUM_OWN_ADDR] = { > #define NPCM_I2CFIF_CTS_CLR_FIFO BIT(6) > #define NPCM_I2CFIF_CTS_SLVRSTR BIT(7) > > -/* NPCM_I2CTXF_CTL reg fields */ > -#define NPCM_I2CTXF_CTL_TX_THR GENMASK(4, 0) > +/* NPCM_I2CTXF_CTL reg field */ > #define NPCM_I2CTXF_CTL_THR_TXIE BIT(6) > > /* NPCM_I2CT_OUT reg fields */ > @@ -238,22 +238,22 @@ static const int npcm_i2caddr[I2C_NUM_OWN_ADDR] = { > #define NPCM_I2CT_OUT_T_OUTST BIT(7) > > /* NPCM_I2CTXF_STS reg fields */ > -#define NPCM_I2CTXF_STS_TX_BYTES GENMASK(4, 0) > +#define NPCM_I2CTXF_STS_TX_BYTES bus->data->txf_sts_tx_bytes It's not a clean code to use defines for complex types. It's not a constant anymore, so just use bus->data->txf_sts_tx_bytes directly. The same in other places. > #define NPCM_I2CTXF_STS_TX_THST BIT(6) > Best regards, Krzysztof