From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01C9EC1975A for ; Sun, 15 Mar 2020 01:34:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE3072076A for ; Sun, 15 Mar 2020 01:33:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="TUuRdVpc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726713AbgCOBd6 (ORCPT ); Sat, 14 Mar 2020 21:33:58 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:55730 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726825AbgCOBd6 (ORCPT ); Sat, 14 Mar 2020 21:33:58 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1584236037; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=VXbg0PkR8DzxPJz/MiykCW0CnZd/L0YGnzp2Lz0Y0eE=; b=TUuRdVpc8vph+M4LOH6n6A7k37QDn/mwImwjjBvsm1VySBK1/WbDq+3U6yWKZscIQHYzuryQ /BBJu4BXvMogbQFgbAt1M8NOEI2gsMoGiAw0aVa2zpxAF6+r48ov2+l5YBP2vi5WT18a8R2l IVj0TWAlGy4OajkjUjkJKURpfDw= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e6d268b.7fb83f309a40-smtp-out-n01; Sat, 14 Mar 2020 18:46:35 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 6AE8FC432C2; Sat, 14 Mar 2020 18:46:35 +0000 (UTC) Received: from [192.168.0.104] (unknown [183.82.137.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tdas) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1366FC433CB; Sat, 14 Mar 2020 18:46:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1366FC433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=tdas@codeaurora.org Subject: Re: [PATCH v5 3/5] dt-bindings: clock: Add YAML schemas for the QCOM MSS clock bindings To: Rob Herring , Stephen Boyd Cc: Michael Turquette , David Brown , Rajendra Nayak , linux-arm-msm , "open list:ARM/QUALCOMM SUPPORT" , linux-clk , "linux-kernel@vger.kernel.org" , Andy Gross , devicetree@vger.kernel.org References: <1582540703-6328-1-git-send-email-tdas@codeaurora.org> <1582540703-6328-4-git-send-email-tdas@codeaurora.org> <20200224184201.GA6030@bogus> <158267707817.177367.4165827948994155128@swboyd.mtv.corp.google.com> From: Taniya Das Message-ID: <888d1371-2eea-1cf2-5633-715fb047bbbb@codeaurora.org> Date: Sun, 15 Mar 2020 00:16:27 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org I have combined all the bindings in the same patch to avoid any YAML dependency. On 2/26/2020 7:40 PM, Rob Herring wrote: > On Tue, Feb 25, 2020 at 6:31 PM Stephen Boyd wrote: >> >> Quoting Rob Herring (2020-02-25 05:58:19) >>> On Mon, Feb 24, 2020 at 11:49 PM Taniya Das wrote: >>>> >>>> Hi Rob, >>>> >>>> On 2/25/2020 12:12 AM, Rob Herring wrote: >>>> >>>>> >>>>> My bot found errors running 'make dt_binding_check' on your patch: >>>>> >>>>> Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node >>>>> Error: Documentation/devicetree/bindings/clock/qcom,sc7180-mss.example.dts:21.26-27 syntax error >>>>> FATAL ERROR: Unable to parse input tree >>>>> scripts/Makefile.lib:300: recipe for target 'Documentation/devicetree/bindings/clock/qcom,sc7180-mss.example.dt.yaml' failed >>>>> make[1]: *** [Documentation/devicetree/bindings/clock/qcom,sc7180-mss.example.dt.yaml] Error 1 >>>>> Makefile:1263: recipe for target 'dt_binding_check' failed >>>>> make: *** [dt_binding_check] Error 2 >>>>> >>>>> See https://patchwork.ozlabs.org/patch/1242999 >>>>> Please check and re-submit. >>>>> >>>> >>>> The error shows syntax error at line 21, below is the example.dts from >>>> my tree and would compile for me as I have the dependency of the include >>>> file when I compile. >>> >>> The header should be part of this patch if possible. >>> >> >> Are patches tested in isolation instead of in series? I see this define >> in the first patch in this series so it seems like automated checkers >> should be able to apply the patches in series and see if they still >> work, unless that is broken somehow. > > The series should be applied, but it's all very fragile. It's going to > stay that way until someone else writes and maintains the applying > patches to git logic. > > In any case, the header is part of the binding (being an ABI) not the > driver, so it belongs in the binding patch. > > > However, in this case, the problem was pointed out in v4 to be a typo > in GCC_MSS_MFAB_AXIS_CLK. > > Rob > -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation. --