From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 048D5C6FA8A for ; Thu, 8 Sep 2022 14:55:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232465AbiIHOzp (ORCPT ); Thu, 8 Sep 2022 10:55:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232292AbiIHOzn (ORCPT ); Thu, 8 Sep 2022 10:55:43 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFAE09C8D7 for ; Thu, 8 Sep 2022 07:55:40 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id z23so20253516ljk.1 for ; Thu, 08 Sep 2022 07:55:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=fgfnhY3Ull0vFOfCmjRPglZnCyMcEKdcwqQSL0htN4s=; b=Tfxv0wLLpxiul/CCTKgU19nq1+XuXriBZ9LEMrMatNFJ1wo2fzx/HSwJqbhQM44pmK wwdS9BNxGTEgHi0RmOwgAN3usrdTi/vOqYrMp+qN/466jLe50E4voyYfGoqsfVRtk4Yu GGs8UuleALrZvGc3Em9sxDAuWYiNV5JWHBznhh/PNQfGPRFewKAe78QbCzZvmo7D0fNH p5z7id3h1Bd3mKefKckdHPrEHoFDDNOrQiQ2d0daHrehbFKtiuI1nHgpufCe1DWyLE/o 9QBOwZig6kQNYdGH4bSIzTozQCH3DT5PviCl1OC9UVmflrCatHXBpui/QATYDhZwXc7q 6Huw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=fgfnhY3Ull0vFOfCmjRPglZnCyMcEKdcwqQSL0htN4s=; b=DVNvPadwDiSqNmvmhxiXcRQNohwLXZkwEn9RjPA8E1vCkjYxtzvjX97j2X/bTFTxZB XRSg5mjVusiIEcsKWh9VRjgZb8yxE3cXzfpSBnHdFQgZFWpfof2i0dB+Mq0tKZgnGjou mr3DAPk3z7XRFNPGNcyHdGA5qZl+tfOY9JhGjI8at2fcDq7q9h2jBznnxbngG7Wjcyef jDVabzOPFm6rcsyLOxz4HrwIf1SYAWN5wYyYR40ib0duFxM24Ter2cVKxkggsw9ORfME VTEQqqBGcfsvc/q1YDbvQnVbveQwttMZ1MOSnF2MGoE0XvUyLRnoxjdxG6fEsjVxnPuO kLZw== X-Gm-Message-State: ACgBeo2PSKVKev2S07PCjA/WcNsCLf8UBOqgU5G68W+rEhlSwoI4H5lF 0Yf99NKXBfpOph9l7qjv177MMw== X-Google-Smtp-Source: AA6agR7CdTkFme++fxO7yCuNAUYEhQGmRtghzjNi1mJGcVbSKLCJ2f0obGMN5IJudh/AGuecUAFTjg== X-Received: by 2002:a2e:a910:0:b0:26a:ed13:cda6 with SMTP id j16-20020a2ea910000000b0026aed13cda6mr1407716ljq.250.1662648939305; Thu, 08 Sep 2022 07:55:39 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id c16-20020ac24150000000b0048afd0c496fsm3066503lfi.156.2022.09.08.07.55.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Sep 2022 07:55:38 -0700 (PDT) Message-ID: <889151be-9ea8-6a9e-e5fe-eac1dd93250c@linaro.org> Date: Thu, 8 Sep 2022 16:55:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v4 1/2] dt-bindings: power: reset: qcom-pon: update "reg" property details Content-Language: en-US To: Anjelique Melendez , corbet@lwn.net, sre@kernel.org, robh+dt@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org Cc: krzysztof.kozlowski+dt@linaro.org, vkoul@kernel.org, linux-doc@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, David Collins References: <20220725191314.19456-1-quic_amelende@quicinc.com> <20220725191314.19456-2-quic_amelende@quicinc.com> <0e6bf142-ca56-2414-86c4-1a18b74b3ba6@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <0e6bf142-ca56-2414-86c4-1a18b74b3ba6@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/08/2022 22:26, Anjelique Melendez wrote: > > Hi Krzysztof, > First I would like to apologize for my lack of response to this patch series > over these past few weeks. I have been out of office. > > On 7/26/2022 3:25 AM, Krzysztof Kozlowski wrote: >> On 25/07/2022 21:13, Anjelique Melendez wrote: >>> From: David Collins >>> >>> Update the description of "reg" property to add the PON_PBS base >>> address along with PON_HLOS base address. Also add "reg-names" >>> property constraints. >>> >>> Signed-off-by: David Collins >>> Signed-off-by: Anjelique Melendez >>> --- >>> Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 50 +++++++++++++++++++++++++++--- >>> 1 file changed, 46 insertions(+), 4 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml >>> index 353f155d..d7b6b875 100644 >>> --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml >>> +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml >>> @@ -15,18 +15,27 @@ description: | >>> >>> This DT node has pwrkey and resin as sub nodes. >>> >>> -allOf: >>> - - $ref: reboot-mode.yaml# >>> - >>> properties: >>> compatible: >>> enum: >>> - qcom,pm8916-pon >>> - qcom,pms405-pon >>> - qcom,pm8998-pon >>> + - qcom,pmk8350-pon >>> >>> reg: >>> - maxItems: 1 >>> + description: | >>> + Specifies the SPMI base address for the PON (power-on) peripheral. For >>> + PMICs that have the PON peripheral (GEN3) split into PON_HLOS and PON_PBS >>> + (e.g. PMK8350), this can hold addresses of both PON_HLOS and PON_PBS >>> + peripherals. In that case, the PON_PBS address needs to be specified to >>> + facilitate software debouncing on some PMIC. >>> + minItems: 1 >>> + maxItems: 2 >>> + >>> + reg-names: >>> + minItems: 1 >>> + maxItems: 2 >>> >>> pwrkey: >>> type: object >>> @@ -42,6 +51,39 @@ required: >>> >>> unevaluatedProperties: false >>> >>> +allOf: >>> + - $ref: reboot-mode.yaml# >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - qcom,pm8916-pon >>> + - qcom,pms405-pon >>> + - qcom,pm8998-pon >>> + then: >>> + properties: >>> + reg: >>> + maxItems: 1 >>> + reg-names: >>> + items: >>> + - const: pon >> >> All your previous patches were actually missing (in commit msg, in the >> code) that piece of information which you add here. You now add >> reg-names with "pon" for older devices. I assumed previous that it is >> somehow needed, so I gave you the hints how it should be coded. But I >> don't understand - why are you doing it >> >> This should be explained in commit msg. To me it is not needed at all... >> unless you want to mark that first address space is entirely different >> for other devices? > Adding reg-names "pon" for older devices is simply to provide clarification > about what the register relates to. Similar to reg-names "hlos" and "pbs" > for gen3 children devices, reg-names is completely optional and is not > consumed by any driver. OK, can be. Include it in the commit msg, please. Best regards, Krzysztof