From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E91FEB64D9 for ; Sun, 2 Jul 2023 10:47:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229889AbjGBKrP (ORCPT ); Sun, 2 Jul 2023 06:47:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229657AbjGBKrO (ORCPT ); Sun, 2 Jul 2023 06:47:14 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57095E6F for ; Sun, 2 Jul 2023 03:47:13 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-51d89664272so3876293a12.1 for ; Sun, 02 Jul 2023 03:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688294832; x=1690886832; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=doP8CZZyrslCenSYjdf6T/PIt+tCk5F92Ar2E5adtJ0=; b=ctacEYA1JK6veFXxDJZFud4r7LN4mBV0X0v7BsVcyc/h8oYdZJGgjQKfYbSclowoaF CKs9o5FIk4V/q8HdhxLVMS+Sr42LMHv+2sZCF8mC1KhKgvnJZh+69V4xD+YDMSYvsewV WNWMQiagaIhorzQIhS7+M2H2kyDkr2sPp+GZv66P5t8ubtR95qYQhfzLtRQeKW8MHomL kxGBUQyE83nuOB1+LLo9XvcMNl6hbj18QP9Xo/33e2Bs36JK0zpsHisRQmtKmyQue+sl 1pvQidSX7rfr4UOtgA2F6PKiRNJXHbHYojIpxZC8qxgeo+7dS0ixvkqrlbOm2SrYriy4 k1NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688294832; x=1690886832; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=doP8CZZyrslCenSYjdf6T/PIt+tCk5F92Ar2E5adtJ0=; b=iJiesLe3DPg6wX3wlVBdFDpkJ0SgUf/PU8olEwYgdIZ6ZDl+VXoXUcHPVBAindvhW8 BBpeEWxLepgYlhlHpnpvKoTH3tKVH5v2ZyUoWNRdIk6AbUt3SE9p4aqrGxYgKvzByshf xIy2Y2EIO16Dv/X15VgK31kzBcdVAlLhDM6vDm5qTRLEoQ1lbQdBU5gyU6cYukU6mfoU I6ED7dXF4LIC66p1Qh5LTD3dvDObUhH4skkc8/Bp5BKBCFOWjFc3f2nB1nAYfIWNyFkv IsYUpR8+5B2syMmbByzAvJEFwcsR56Sm9DBFL5cV9Pwwg3z2MXA3UisfOtg7wQkkgFER TbjQ== X-Gm-Message-State: ABy/qLYBHu47k5kBTGkOLSp2VcVrr2W/rlffFONLi6usOMmMjucjsngb 0CLJf9D73vYtD9kGWfhCKGsb6w== X-Google-Smtp-Source: APBJJlEUDjmuQNgaEKhIauAAnEoZ97aP9Ydyy4Asa0tJshbXlejAZ3SysQ8kzJrnLsVizDYxGEaxCQ== X-Received: by 2002:aa7:ca57:0:b0:51d:96de:af6f with SMTP id j23-20020aa7ca57000000b0051d96deaf6fmr5497089edt.0.1688294831756; Sun, 02 Jul 2023 03:47:11 -0700 (PDT) Received: from [192.168.10.214] ([217.169.179.6]) by smtp.gmail.com with ESMTPSA id q14-20020a056402040e00b0051d890b2407sm8550077edv.81.2023.07.02.03.47.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Jul 2023 03:47:11 -0700 (PDT) Message-ID: <889bbee2-db9c-c1dd-dc8a-cdc436f1dfd8@linaro.org> Date: Sun, 2 Jul 2023 12:47:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 3/4] dt-bindings: media: add mediatek ISP3.0 camsv Content-Language: en-US To: Julien Stephan Cc: Phi-bang Nguyen , Andy Hsieh , AngeloGioacchino Del Regno , Conor Dooley , daoyuan huang , devicetree@vger.kernel.org, Florian Sylvestre , Hans Verkuil , Krzysztof Kozlowski , Laurent Pinchart , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-media@vger.kernel.org, Louis Kuo , Matthias Brugger , Mauro Carvalho Chehab , Moudy Ho , Ping-Hsun Wu , Rob Herring , Vasily Gorbik References: <20230628145412.1610260-1-jstephan@baylibre.com> <20230628145412.1610260-4-jstephan@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <20230628145412.1610260-4-jstephan@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/06/2023 16:52, Julien Stephan wrote: > From: Phi-bang Nguyen > > This adds the bindings, for the ISP3.0 camsv module embedded in > some Mediatek SoC, such as the mt8365 Thank you for your patch. There is something to discuss/improve. > + > +description: > + The CAMSV is a set of DMA engines connected to the SENINF CSI-2 > + receivers. The number of CAMSVs depend on the SoC model. > + > +properties: > + compatible: > + const: mediatek,mt8365-camsv > + > + reg: > + maxItems: 3 Describe the items (items with description) instead. > + ... > + > +examples: > + - | > + #include > + #include > + #include > + #include > + #include > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + camsv1: camsv@15050000 { > + compatible = "mediatek,mt8365-camsv"; > + reg = <0 0x15050000 0 0x0040>, > + <0 0x15050208 0 0x0020>, > + <0 0x15050400 0 0x0100>; Fix the alignment. > + interrupts = ; > + clocks = <&camsys CLK_CAM>, > + <&camsys CLK_CAMTG>, > + <&camsys CLK_CAMSV0>; Everywhere... Best regards, Krzysztof