From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08E9E360 for ; Tue, 11 Mar 2025 07:41:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741678865; cv=none; b=X651xcAeMpkcNXmlTCXPLlCAfpRtkQjFCqsrLR8SxYsXAmJ4NiWIrXqrO8AhTfgXAagnhTu9q/JNXP0TUwtMRhi2e5y4f38OWnd5XkHMNyJ7NZa00kr+SIu/8i7vPjTxzmifypOERaZEYKLO4Y9bm3ow4mEbCXTCmZVxURRDAgI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741678865; c=relaxed/simple; bh=kmrGTuoWcvZPvvfmAHgaJ+HoWUIHDbPQ5XUdK5MVEfE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pRLDWzVygm1XmJ8gXBXY+RwlhZLXL/mgZSD3Gk3kAapkhO4Mx2IaWzzsV3iZFxWUynpaHgITT+zmmdusJSgZnDwFHZWhRAT5vnyppbpAMpI8i+2TnANj3FcBP6XMYmGFmuWvBf/LtFa+zIhuAd8TxkxFUGGIGuacLCLuEnqNKds= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qMVgE6z/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qMVgE6z/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A976C4CEE9; Tue, 11 Mar 2025 07:41:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741678864; bh=kmrGTuoWcvZPvvfmAHgaJ+HoWUIHDbPQ5XUdK5MVEfE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qMVgE6z/RdGEjBH5COLtvg1DT9eMxt0lwgUlyJR5OGQBj0+x9wdQLU+ora66XDTIu KSD9LB+TdTAMu4E29RN/xyV6CsDJxyRPKr7TfnO8GwrBl+m143BFEgzURhMrcz7Sos upUhtjzUxzDcLRyYY92sQDJM9C3Pghcz83aBkVtilhlWUHGjHJ+d2ehjwzC/TUA6XV sbKtD4qVdvRKQiMXP5zwGCrvxbo/6YKGw7AokcN3yVOw8Y0VrG+9P3AdIsRWTMlpbH t3HdNgRF+aBO5APMtU8XpYuHuILvASkhFs3k4UZRhunoAbzhHy2yeHZ+dN0hgFsRr3 2iyvQj5VmlEgA== Message-ID: <88aa345b-92f0-4807-8694-7f3a2b548fff@kernel.org> Date: Tue, 11 Mar 2025 08:40:58 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/6] dt-bindings: gpu: v3d: Add SMS to the registers' list To: =?UTF-8?Q?Ma=C3=ADra_Canal?= Cc: Melissa Wen , Iago Toral , Jose Maria Casanova Crespo , Phil Elwell , dri-devel@lists.freedesktop.org, kernel-dev@igalia.com, Krzysztof Kozlowski , Conor Dooley , Nicolas Saenz Julienne , devicetree@vger.kernel.org References: <20250308-v3d-gpu-reset-fixes-v2-0-2939c30f0cc4@igalia.com> <20250308-v3d-gpu-reset-fixes-v2-4-2939c30f0cc4@igalia.com> <20250310-calculating-flat-cuttlefish-4c9fc2@krzk-bin> <4d224fc2-d077-47aa-8b52-edba30c62d19@igalia.com> <6f87918b-b4ca-4404-8f1e-e1100190c0f6@kernel.org> <2bc573c6-e44f-441b-9b13-baa7df64a641@igalia.com> <130b6c9e-9e11-433c-881f-1a7ea8b0f86e@kernel.org> <4c658ba0-aa3b-4f8c-b1eb-fc7993a33ffa@igalia.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <4c658ba0-aa3b-4f8c-b1eb-fc7993a33ffa@igalia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 10/03/2025 21:07, Maíra Canal wrote: > > From my understanding, I'm keeping the ABI preserved, as brcm,7268-v3d > needs to have a GCA register (otherwise, you won't be able to flush the > cache) and brcm,2711-v3d doesn't even have this piece of hardware. > > I understand that now I'm imposing per-compatible restrictions that > didn't exist in the spec, but the new restrictions are compatible to the > hardware specification. I'd like to understand if I can: > > 1. Use two register items (gca and sms) to preserve the semantics of the > register names. Sure, that's fine. > > 2. Can I add per-compatible restrictions to the DT even if the original > bindings didn't do it? If not, can I just add a new register to the > register list? Like: Yes, constraints are expected and it does not matter that original binding forgot them. > > reg-names: > items: > - const: hub > - const: core0 > - - enum: [ bridge, gca ] > - - enum: [ bridge, gca ] > + - enum: [ bridge, gca, sms ] > + - enum: [ bridge, gca, sms ] > + - enum: [ bridge, gca, sms ] This does not look right, because there is no device from your description which has 5 items. Best regards, Krzysztof