From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amelie DELAUNAY Subject: Re: [PATCH 2/8] dt-bindings: document the STM32 RTC bindings Date: Mon, 5 Dec 2016 11:14:56 +0100 Message-ID: <88bf56d7-e8c2-b6ca-79fa-b9379ba44737@st.com> References: <1480687801-19525-2-git-send-email-amelie.delaunay@st.com> <1480687801-19525-4-git-send-email-amelie.delaunay@st.com> <20161205100630.n3gldznf524pucjm@piout.net> Reply-To: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Return-path: Sender: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20161205100630.n3gldznf524pucjm-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Alexandre Belloni Cc: "a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org" , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "mark.rutland-5wv7dgnIgG8@public.gmane.org" , "mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , Alexandre TORGUE , "linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org" , "rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Gabriel FERNANDEZ List-Id: devicetree@vger.kernel.org Hi Alexandre, Thanks for reviewing On 12/05/2016 11:06 AM, Alexandre Belloni wrote: > Hi, > > On 02/12/2016 at 15:09:55 +0100, Amelie Delaunay wrote : >> This patch adds documentation of device tree bindings for the STM32 RTC. >> >> Signed-off-by: Amelie Delaunay >> --- >> .../devicetree/bindings/rtc/st,stm32-rtc.txt | 31 ++++++++++++++++++++++ >> 1 file changed, 31 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/rtc/st,stm32-rtc.txt >> >> diff --git a/Documentation/devicetree/bindings/rtc/st,stm32-rtc.txt b/Documentation/devicetree/bindings/rtc/st,stm32-rtc.txt >> new file mode 100644 >> index 0000000..4578838 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/rtc/st,stm32-rtc.txt >> @@ -0,0 +1,31 @@ >> +STM32 Real Time Clock >> + >> +Required properties: >> +- compatible: "st,stm32-rtc". >> +- reg: address range of rtc register set. >> +- clocks: reference to the clock entry ck_rtc. >> +- clock-names: name of the clock used. Should be "ck_rtc". > > Is this name really useful? You're right, not useful. > >> +- interrupt-parent: phandle for the interrupt controller. >> +- interrupts: rtc alarm interrupt. >> +- interrupt-names: rtc alarm interrupt name, should be "alarm". > > Same comment, is this name really useful? Ditto. > > Best regards, Amelie -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.