From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>,
vkoul@kernel.org, agross@kernel.org, andersson@kernel.org,
robh+dt@kernel.org, broonie@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_rohkumar@quicinc.com, srinivas.kandagatla@linaro.org,
dianders@chromium.org, swboyd@chromium.org,
judyhsiao@chromium.org, alsa-devel@alsa-project.org,
quic_rjendra@quicinc.com, konrad.dybcio@somainline.org,
mka@chromium.org
Cc: Ratna Deepthi Kudaravalli <quic_rkudarav@quicinc.com>
Subject: Re: [PATCH v4 1/3] arm64: dts: qcom: Update soundwire slave node names
Date: Mon, 7 Nov 2022 16:02:24 +0100 [thread overview]
Message-ID: <88c55827-067c-e6b1-a841-be70c05b7fc4@linaro.org> (raw)
In-Reply-To: <1667830844-31566-2-git-send-email-quic_srivasam@quicinc.com>
On 07/11/2022 15:20, Srinivasa Rao Mandadapu wrote:
> Update soundwire slave nodes of WSA speaker to match with
> dt-bindings pattern properties regular expression.
>
> This modifiction is required to avoid dtbs-check errors
> occurred with qcom,soundwire.yaml.
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Ratna Deepthi Kudaravalli <quic_rkudarav@quicinc.com>
> Signed-off-by: Ratna Deepthi Kudaravalli <quic_rkudarav@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 4 ++--
> arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 ++--
> arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 ++--
> arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts | 4 ++--
> arch/arm64/boot/dts/qcom/sm8250-mtp.dts | 4 ++--
> 5 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> index 2c08500..983e8a9 100644
> --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> @@ -1007,7 +1007,7 @@
> };
>
> &swr0 {
> - left_spkr: wsa8810-left {
> + left_spkr: wsa8810@0,3 {
While changing it, make the node names generic, so:
speaker@0,3
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> compatible = "sdw10217211000";
> reg = <0 3>;
> powerdown-gpios = <&tlmm 130 GPIO_ACTIVE_HIGH>;
> @@ -1016,7 +1016,7 @@
> #sound-dai-cells = <0>;
> };
>
> - right_spkr: wsa8810-right {
> + right_spkr: wsa8810@0,4 {
speaker@0,4
and so on...
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-07 15:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 14:20 [PATCH v4 0/3] Convert soundwire bindings to DT schema Srinivasa Rao Mandadapu
2022-11-07 14:20 ` [PATCH v4 1/3] arm64: dts: qcom: Update soundwire slave node names Srinivasa Rao Mandadapu
2022-11-07 15:02 ` Krzysztof Kozlowski [this message]
2022-11-07 14:20 ` [PATCH v4 2/3] arm64: dts: qcom: Remove redundant soundwire property Srinivasa Rao Mandadapu
2022-11-07 15:03 ` Krzysztof Kozlowski
2022-11-07 15:48 ` Konrad Dybcio
2022-11-07 14:20 ` [PATCH v4 3/3] dt-bindings: soundwire: Convert text bindings to DT Schema Srinivasa Rao Mandadapu
2022-11-07 15:11 ` Krzysztof Kozlowski
2022-11-08 6:42 ` Srinivasa Rao Mandadapu
2022-11-08 9:05 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88c55827-067c-e6b1-a841-be70c05b7fc4@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=judyhsiao@chromium.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=quic_rjendra@quicinc.com \
--cc=quic_rkudarav@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=quic_srivasam@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).