From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
root <root@hu-msarkar-hyd.qualcomm.com>,
andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org,
jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
manivannan.sadhasivam@linaro.org, conor+dt@kernel.org,
quic_nitegupt@quicinc.com
Cc: quic_shazhuss@quicinc.com, quic_ramkri@quicinc.com,
quic_nayiluri@quicinc.com, quic_krichai@quicinc.com,
quic_vbadigan@quicinc.com,
"Mrinmay Sarkar" <quic_msarkar@quicinc.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/3] dt-bindings: PCI: qcom: Add global irq support for SA8775p
Date: Wed, 21 Feb 2024 15:33:58 +0100 [thread overview]
Message-ID: <88d8fea5-2b11-4d01-816c-dbe822ac8d19@linaro.org> (raw)
In-Reply-To: <a0677780-d013-44f7-94bf-ea7e23aab019@linaro.org>
On 21/02/2024 15:31, Konrad Dybcio wrote:
> On 21.02.2024 15:28, Krzysztof Kozlowski wrote:
>> On 21/02/2024 15:04, root wrote:
>>> From: Mrinmay Sarkar <quic_msarkar@quicinc.com>
>>>
>>> Add global interrupt support in dt-bindings for SA8775p RC platform.
>>
>> What is this global interrupt? Why wasn't it there before?
>>
>>>
>>> Signed-off-by: Mrinmay Sarkar <quic_msarkar@quicinc.com>
>>> ---
>>> .../devicetree/bindings/pci/qcom,pcie.yaml | 26 +++++++++++++++++--
>>> 1 file changed, 24 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>> index a93ab3b54066..d86fb63a2d2c 100644
>>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>> @@ -63,7 +63,7 @@ properties:
>>>
>>> interrupt-names:
>>> minItems: 1
>>> - maxItems: 8
>>> + maxItems: 9
>>>
>>> iommu-map:
>>> minItems: 1
>>> @@ -873,8 +873,30 @@ allOf:
>>> compatible:
>>> contains:
>>> enum:
>>> - - qcom,pcie-msm8996
>>> - qcom,pcie-sa8775p
>>> + then:
>>> + oneOf:
>>
>> No need, drop.
>
> Moreover, I think this global irq should be present on all qc platforms
Heh, this will anyway conflict with my series:
https://lore.kernel.org/all/90a50ab4-a513-48af-b13a-bba082e49540@linaro.org/
https://lore.kernel.org/all/20240205-dt-bindings-pci-qcom-split-continued-v1-0-c333cab5eeea@linaro.org/
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-21 14:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 14:04 [PATCH v1 0/3] Add support for detecting Controller Level PCIe Errors root
2024-02-21 14:04 ` [PATCH v1 1/3] dt-bindings: PCI: qcom: Add global irq support for SA8775p root
2024-02-21 14:28 ` Krzysztof Kozlowski
2024-02-21 14:31 ` Konrad Dybcio
2024-02-21 14:33 ` Krzysztof Kozlowski [this message]
2024-02-22 13:46 ` Mrinmay Sarkar
2024-02-22 14:19 ` Krzysztof Kozlowski
2024-02-21 14:04 ` [PATCH v1 2/3] arm64: dts: qcom: sa8775p: Enable " root
2024-02-21 14:04 ` [PATCH v1 3/3] PCI: qcom: Add support for detecting controller level PCIe errors root
2024-02-21 14:35 ` Krzysztof Kozlowski
2024-02-21 18:50 ` Bjorn Helgaas
2024-02-22 12:38 ` Bjorn Helgaas
2024-02-21 21:00 ` Frank Li
2024-02-22 11:01 ` kernel test robot
2024-02-22 12:39 ` kernel test robot
2024-02-22 5:22 ` [PATCH v1 0/3] Add support for detecting Controller Level PCIe Errors Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88d8fea5-2b11-4d01-816c-dbe822ac8d19@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_krichai@quicinc.com \
--cc=quic_msarkar@quicinc.com \
--cc=quic_nayiluri@quicinc.com \
--cc=quic_nitegupt@quicinc.com \
--cc=quic_ramkri@quicinc.com \
--cc=quic_shazhuss@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=robh@kernel.org \
--cc=root@hu-msarkar-hyd.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).