devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alexander Baransky <sanyapilot496@gmail.com>,
	neil.armstrong@linaro.org, quic_jesszhan@quicinc.com,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: display: panel: Add Visionox G2647FB105
Date: Tue, 25 Mar 2025 17:38:13 +0100	[thread overview]
Message-ID: <88e4cd7b-84a6-4c14-9704-012904a77ef5@kernel.org> (raw)
In-Reply-To: <ed62d5f3-a728-4d11-9b59-28496ed267db@kernel.org>

On 25/03/2025 17:35, Krzysztof Kozlowski wrote:
> On 25/03/2025 16:57, Alexander Baransky wrote:
>> The Visionox G2647FB105 is a 6.47 inch 1080x2340 MIPI-DSI CMD mode
> 
> 
> "Add a DT binding for the Visionox....."
> 
>> AMOLED panel used in:
>> - Xiaomi Mi Note 10 / CC9 Pro (sm7150-xiaomi-tucana)
>> - Xiaomi Mi Note 10 Lite (sm7150-xiaomi-toco)
>>
>> Add a dt-binding for it.
> 
> And drop this sentence.
> 
>>
>> Signed-off-by: Alexander Baransky <sanyapilot496@gmail.com>
>> ---
> 
> 
> ...
> 
>> +properties:
>> +  compatible:
>> +    const: visionox,g2647fb105
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  vdd3p3-supply:
>> +    description: 3.3V source voltage rail
>> +
>> +  vddio-supply:
>> +    description: I/O source voltage rail
>> +
>> +  vsn-supply:
>> +    description: Negative source voltage rail
>> +
>> +  vsp-supply:
>> +    description: Positive source voltage rail
> 
> Are you sure these are real voltage rails on the device? Weirdly similar
> to some old Samsung AMOLED panels...

Heh, actually entire example is the same as in Samsung panels.

Best regards,
Krzysztof

  reply	other threads:[~2025-03-25 16:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-25 15:57 [PATCH 0/2] Add Visionox G2647FB105 panel support Alexander Baransky
2025-03-25 15:57 ` [PATCH 1/2] dt-bindings: display: panel: Add Visionox G2647FB105 Alexander Baransky
2025-03-25 16:35   ` Krzysztof Kozlowski
2025-03-25 16:38     ` Krzysztof Kozlowski [this message]
     [not found]     ` <190ba70d-89bd-4e46-b7e5-7b93d706d84f@jiaxyga.com>
2025-03-25 18:21       ` Krzysztof Kozlowski
2025-03-25 15:57 ` [PATCH 2/2] drm/panel: Add Visionox G2647FB105 panel driver Alexander Baransky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88e4cd7b-84a6-4c14-9704-012904a77ef5@kernel.org \
    --to=krzk@kernel.org \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_jesszhan@quicinc.com \
    --cc=robh@kernel.org \
    --cc=sanyapilot496@gmail.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).