From: Krzysztof Kozlowski <krzk@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, krzk+dt@kernel.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
robh@kernel.org, ulf.hansson@linaro.org
Subject: Re: [PATCH v3 1/1] dt-bindings: mmc: Convert fsl-esdhc.txt to yaml
Date: Mon, 10 Jun 2024 14:29:57 +0200 [thread overview]
Message-ID: <8901d498-d30a-43db-bda2-25d3d1d58e8d@kernel.org> (raw)
In-Reply-To: <b1c51acc-441d-4484-adef-1da368571097@kernel.org>
On 06/06/2024 08:44, Krzysztof Kozlowski wrote:
> On 05/06/2024 20:50, Frank Li wrote:
>> Convert layerscape fsl-esdhc binding doc from txt to yaml format.
>>
>> Addtional change during convert:
>> - Deprecate "sdhci,wp-inverted", "sdhci,1-bit-only".
>> - Add "reg" and "interrupts" property.
>> - Change example "sdhci@2e000" to "mmc@2e000".
>> - Compatible string require fsl,<chip>-esdhc followed by fsl,esdhc to match
>> most existed dts file.
>> - Set clock-frequency to 100mhz in example.
>>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Or not... are you sure that DTS validates? Did you test it? kbuild has a
bit different opinion.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-10 12:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 18:50 [PATCH v3 1/1] dt-bindings: mmc: Convert fsl-esdhc.txt to yaml Frank Li
2024-06-06 6:44 ` Krzysztof Kozlowski
2024-06-10 12:29 ` Krzysztof Kozlowski [this message]
2024-06-10 14:33 ` Frank Li
2024-06-11 6:44 ` Krzysztof Kozlowski
2024-06-11 14:58 ` Frank Li
2024-06-08 8:27 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8901d498-d30a-43db-bda2-25d3d1d58e8d@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).