From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8139A12B166 for ; Mon, 26 Feb 2024 17:29:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708968550; cv=none; b=mNtbsnMgEDBPBww8CypxMqX0d5m2wQD8CrIM+NFs5n6gnXMCgscxEKdnEc0VzbKDDyySAncTqSKIVDGnoeTSE38PHWfJATr+N9UBpwFJTLyVcRinlQOOhPB1bRFEO7EiEQqKe7GQuIQUvELWFVTS3YrFqvp3gYtR3n1KmnmPGrM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708968550; c=relaxed/simple; bh=3PemA0qZXTfYcqdwnXhac3ZBiBqrNIFPdhVW4rMEW/k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rHMPKUI1EOdx6IznBypycWMtE/n9kZgHK/zbln66PpCrsHI3gGMm4en0YunfhunD1nodPgjcSuETI+KyW1Gf9X8asRwBm9f12KVvIUDZVR2rKnR9raP8XINiwiwRiJLZNOxNDpoB8ZU8GF/34WJz3dRsKn3Jzk2ZDREjmY614FQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Bu284n8v; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Bu284n8v" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-564fc495d83so3864166a12.0 for ; Mon, 26 Feb 2024 09:29:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708968547; x=1709573347; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=xSHCqUQrlcyM1UtPy6CIgv/PhwbptcNSxQXzTOmXrHA=; b=Bu284n8vX9auFG9LiuJ6h66JsgKn/Ika2hEgwCzlFxQUbnHub+7a/Tn5M9rEd7aF8k RC0O503GnHZMDs9CnmQORewd/7IDO1cGebUrSoHJEvMZNJl/ALi0Yn09a/2DrsBrI7Xp 16kyN0NQg+rHpYCHM+g4HK1WBD4/K0e53vfWmiKCfQXzmRWyzczSNm4qYf+crDnsLFf0 xmo/NLeCeLpTjEcW/bqCGKXarYvQ5nvN0u8+r1t3EODrglYn4Nx6PeMWorCvzTEvB84w M0HCwnHKGBBuPFCie2Gy8iha+uPoepExUnPRVcELxwZyZiTC5pT1umK7sxLoWPpDH9TI hMiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708968547; x=1709573347; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xSHCqUQrlcyM1UtPy6CIgv/PhwbptcNSxQXzTOmXrHA=; b=PCdi7TbP+jw1yKVXx8O8aUsNKpdJe0RxNfuaxlyhaLhnshilhyi1MZOAsKfMMCS52F 930oz+l2sV8EM7vju8Ks485WrTVOrSUqcOrsqiAIGxk7mrF34nTKoqpkvPr2Oo70+gJx UmQo/83OW4fSsB9mwhTFwwGsYbAhX13Xm1Ao3UX4YosVTkwQiYXt+GnYi3Ii4f6UPFUI 1zja456aWHMFEizAbkMfg8NXscBKH42Z31Uj/A9CXIM9nI98HQjgN604pXPgcTPo/UnT 0fW7pKeu0ML9OUYepL68pVBPxpk3j65+jKNREwBYz8Ul7wmDTlq/MfpT4MwjpJ0wabW1 JWTg== X-Forwarded-Encrypted: i=1; AJvYcCUpjJfkG5AoTN4BAAG7RrdExeV6O4kq8lh8DTb991+kznNRxRCeYBk3bDBpbbwnVwbE6xgpiXh/8qJqOI1EzDU8Qg/Zyb0PKloBdQ== X-Gm-Message-State: AOJu0Yzf8YbKXtw6D0UEJvUxU44IvfbJ69G8kUGDKHbD5XXxL11P6lSO BZrSZeq8VQ0Mw19qd1kFzn2BPXcgAFUCLkxVONiO3nlCjgyQHw1geB11Zcb/iYA= X-Google-Smtp-Source: AGHT+IGCBx2sVC3xleLhxR2xoPqUw5ldbavCbeDb+kP8NVH4vfw2fxcHj+dHBK2xmEv8DmrzZ98exQ== X-Received: by 2002:a17:906:f15a:b0:a3f:ce31:64d6 with SMTP id gw26-20020a170906f15a00b00a3fce3164d6mr5106209ejb.10.1708968546911; Mon, 26 Feb 2024 09:29:06 -0800 (PST) Received: from [192.168.1.20] ([178.197.222.116]) by smtp.gmail.com with ESMTPSA id z22-20020a1709060ad600b00a3d125b9c0asm2574985ejf.81.2024.02.26.09.29.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Feb 2024 09:29:06 -0800 (PST) Message-ID: <890afb05-1b19-47b2-bfd8-5f6de0caeda3@linaro.org> Date: Mon, 26 Feb 2024 18:29:04 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 8/9] media: dt-bindings: Add Intel Displayport RX IP To: =?UTF-8?Q?Pawe=C5=82_Anikiel?= Cc: airlied@gmail.com, akpm@linux-foundation.org, conor+dt@kernel.org, daniel@ffwll.ch, dinguyen@kernel.org, hverkuil-cisco@xs4all.nl, krzysztof.kozlowski+dt@linaro.org, maarten.lankhorst@linux.intel.com, mchehab@kernel.org, mripard@kernel.org, robh+dt@kernel.org, tzimmermann@suse.de, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, chromeos-krk-upstreaming@google.com, ribalda@chromium.org References: <20240221160215.484151-1-panikiel@google.com> <20240221160215.484151-9-panikiel@google.com> <13aeb2ff-72f4-49d9-b65e-ddc31569a936@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 26/02/2024 13:43, Paweł Anikiel wrote: >>>>> + intel,max-stream-count: >>>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>>>> + description: Max stream count configuration parameter >>>>> + >>>>> + port: >>>>> + $ref: /schemas/graph.yaml#/properties/port >>>>> + description: SST main link >>>> >>>> I don't understand why you have both port and ports. Shouldn't this be >>>> under ports? >>> >>> I put both so that you can use the shorter port property when the >>> device only has one port (i.e. no MST support). It would work fine >>> without it. If you think that's unnecessary, I can remove it (and use >>> the ports property even if there is only one). >> >> No, it is fine, but then you need allOf: which will restrict to only one >> of them: either port or ports. > > There already is an allOf below that says that ports is required for > MST support and port is required otherwise. Isn't this enough? Add both port and ports and see if it is enough. Best regards, Krzysztof