From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2FD0C46467 for ; Tue, 29 Nov 2022 08:27:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230244AbiK2I12 (ORCPT ); Tue, 29 Nov 2022 03:27:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230201AbiK2I11 (ORCPT ); Tue, 29 Nov 2022 03:27:27 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AECC57B7A for ; Tue, 29 Nov 2022 00:27:25 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id bs21so20837893wrb.4 for ; Tue, 29 Nov 2022 00:27:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=fC0Ojnx6/B78FbeaxNlNaS5gHEZKTLKTPBVMbnEU/Uo=; b=vqbla1SYWRt1WiOApwfF8a1m+eCPIDP40A9UnBLUW4pDWhEteS841d1Qsa+JFpEn5R Q6ScJdCUdlvzTUvV9sv1uL5V3IRYQ/YK77o2NtHM/ys2rRWuPW88u6PX1R4TFy57hx19 WwK/wp/ARbrwPSBlq6jj16I6d+hz+nBGT1/hk9opG9zpfA2YXhCgeClf4lImIgW/JHkG /JbHYrmtGfmagdk1MKpd5f04ODZAewuoAinapLBvIVhlZ2WT5ZvaLWEj/Neo1Dt3h3vq f7HsntfUClDlrWqvgC8GH4TXLov4gWwZwZWOP3cSPET9LGi9j80tBXWcqWwLQ+1+ISbQ Zpug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fC0Ojnx6/B78FbeaxNlNaS5gHEZKTLKTPBVMbnEU/Uo=; b=PkOZ6BorBB+E+yfeIPBxiUMepOllC9Rv9JwcFdyhFXdAQcK8h3/baxCeJH3VIordOp k5mnUQ9PqYnfKCtAa/UZCs2MPzpbhkJTvVhQ33BvLahGWA0pk5R9KKsmGE0GPhzF1Fpz axVdOnSdPQnSGZO7H5woOk0+jZYLYIJtf1ucxn8Hb4bnQpRfOosVbVbFpQMb1E64uqfi KDLL2pxEwzdMVQXx9uu91YLkk7tAH1mHWfalqDft9YJdWMz/3SwbflNb16ZvQZ8C9A8N DhtqmwpRMjpDJ8jE/nXNOormSvo33pupMCVrlxoCv9PN2kzzFxPr2xWF0+7xK8UNVVgr vJkw== X-Gm-Message-State: ANoB5pn819jUsdDRHJvegj5KLfzYv/cQB85fI3zdC8gnO3vPksHLh+YY nRytxhWnZ3iZVlsudnwgDwbOig== X-Google-Smtp-Source: AA0mqf5sna9CUiSoFrFut2DuhcjOVxisdEhSsZ7ova8PCj0QwmiRq7tHLberlUIwj5EZnNdk85HROA== X-Received: by 2002:a5d:6891:0:b0:22e:54da:a4f1 with SMTP id h17-20020a5d6891000000b0022e54daa4f1mr33612237wru.637.1669710444088; Tue, 29 Nov 2022 00:27:24 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:2f85:a28c:5df7:9cd2? ([2a01:e0a:982:cbb0:2f85:a28c:5df7:9cd2]) by smtp.gmail.com with ESMTPSA id 124-20020a1c1982000000b003cfa81e2eb4sm1187980wmz.38.2022.11.29.00.27.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Nov 2022 00:27:23 -0800 (PST) Message-ID: <891304de-c216-fecf-00ee-d70d61c847b6@linaro.org> Date: Tue, 29 Nov 2022 09:27:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 1/2] dt-bindings: reserved-memory: document Qualcomm MPSS DSM memory Content-Language: en-US To: Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , Andy Gross , Frank Rowand Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20221114-narmstrong-sm8550-upstream-mpss_dsm-v1-0-158dc2bb6e96@linaro.org> <20221114-narmstrong-sm8550-upstream-mpss_dsm-v1-1-158dc2bb6e96@linaro.org> <38fff21b-3e75-13f9-664e-a115bc527b67@linaro.org> <9aa23650-6ae1-3844-7cf3-6812dc023c11@linaro.org> <7b3356a9-8f2b-49de-7ad3-b01c3279eac0@linaro.org> <5b1eb21c-92bf-59bc-25c5-f8c38c42b375@linaro.org> Organization: Linaro Developer Services In-Reply-To: <5b1eb21c-92bf-59bc-25c5-f8c38c42b375@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 24/11/2022 14:57, Krzysztof Kozlowski wrote: > On 23/11/2022 11:19, neil.armstrong@linaro.org wrote: >>>>> We have already three of such "memory region devices" and we keep >>>>> growing it. It's not scalable. >>>> >>>> If we want to properly describe this, we must then represent the MPSS subsystem >>>> and associate this memory region. >>> >>> I don't see why. None of devices in your DTS reference this memory >>> region, so it is purely to keep it mapped for Modem, right? In such case >>> I still do not get why PAS/PIL, who starts and stops the remote >>> processor, could not prepare the memory and share it with modem. >> >> OK you've got a point, but this is still an implementation detail. >> >> I got some more background about why this memory zone appeared, before it >> was including in the modem reserved-memories, but for flexibility reasons >> this is now in the hands of the APPS runtime (linux) to setup this memory >> zone and share it to the MPSS subsystem. >> >> So the only requirement for the PAS is to make sure this zone is shared >> before starting the startup process, not to actually do the share setup. >> >> The zone will need to be shared whatever the PAS state is (probe, startup, remove, ...). > > I don't understand here. The memory region should be shared before > remote processor start or before the PAS probe? If the second, why? What > if your driver probes a bit later - after PAS probe? Then all is lost... After offline discussions, I'll associate the DSM memory zone to the PAS MPSS loader instead to make sure the zone is shared before startup. Thanks, Neil > > Best regards, > Krzysztof >