From: Milo Kim <woogyom.kim@gmail.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
Thierry Reding <thierry.reding@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 2/2] ARM: dts: sun8i-h3: Add UART1 pinctrl
Date: Fri, 26 Aug 2016 17:00:37 +0900 [thread overview]
Message-ID: <89195613-d5b6-bfc6-1c8c-0d74d9d02a99@gmail.com> (raw)
In-Reply-To: <20160826071056.GA10545@lukather>
On 08/26/2016 04:10 PM, Maxime Ripard wrote:
>> + uart1_pins_a: uart1@0 {
>> > + allwinner,pins = "PG6", "PG7";
>> > + allwinner,function = "uart1";
>> > + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>> > + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>> > + };
>> > +
> Our policy is that we don't introduce new pinctrl nodes that are not
> used by any board to avoid bloating the DT too much with unused nodes.
>
> If you have a board using it, please submit that change as well.
OK, I agree.
However, this pinmux is only useful in case PA5 is assigned for PWM.
PA5 is commonly used for UART0_RX, so I'd like to add UART1 node into
*.dts and disable it (status = "disabled"). Does it make sense?
Best regards,
Milo
next prev parent reply other threads:[~2016-08-26 8:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 6:44 [PATCH 1/2] pwm: sun4i: Add Allwinner H3 support Milo Kim
2016-08-25 6:44 ` [PATCH 2/2] ARM: dts: sun8i-h3: Add UART1 pinctrl Milo Kim
2016-08-26 7:10 ` Maxime Ripard
2016-08-26 8:00 ` Milo Kim [this message]
[not found] ` <89195613-d5b6-bfc6-1c8c-0d74d9d02a99-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-26 22:29 ` Maxime Ripard
2016-08-31 8:36 ` Milo Kim
2016-08-25 20:51 ` [PATCH 1/2] pwm: sun4i: Add Allwinner H3 support Maxime Ripard
2016-08-26 7:44 ` Milo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89195613-d5b6-bfc6-1c8c-0d74d9d02a99@gmail.com \
--to=woogyom.kim@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).