From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Macpaul Lin" <macpaul.lin@mediatek.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Bernhard Rosenkränzer" <bero@baylibre.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Cc: Bear Wang <bear.wang@mediatek.com>,
Pablo Sun <pablo.sun@mediatek.com>,
Macpaul Lin <macpaul@gmail.com>
Subject: Re: [PATCH v2] dt-bindings: arm64: dts: mediatek: add description for mt8365-evk board
Date: Tue, 12 Sep 2023 08:52:34 +0200 [thread overview]
Message-ID: <89341643-3d0e-89f6-f81c-579c56a358a3@linaro.org> (raw)
In-Reply-To: <4010955c-9df7-da30-aef9-477ae8483e89@mediatek.com>
On 12/09/2023 08:29, Macpaul Lin wrote:
>
>>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>>> ---
>>> Documentation/devicetree/bindings/arm/mediatek.yaml | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> change for v2:
>>> - rebase this patch to follow the v5 patch set of mt8395.
>>> - depends on https://lore.kernel.org/lkml/20230909132819.21626-2-macpaul.lin@mediatek.com/T/
>>> - Fix description as a single board.
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
>>> index 2e8ad49c3479..b163995e32d5 100644
>>> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
>>> @@ -244,7 +244,8 @@ properties:
>>> - enum:
>>> - mediatek,mt8183-pumpkin
>>> - const: mediatek,mt8183
>>> - - items:
>>> + - description: MediaTek Genio 350 Board (Genio 350 EVK)
>>
>> Drop, no need, redundant (copies the compatible) and your other entries
>> do not have it.
>
> The primary objective of this patch is to incorporate a description that
> will prevent users from confusing this platform with others.
How platform can be confused? The compatibles define it, not description.
> Additionally, it aids in identifying this as a "Genio EVK" for marketing
> purposes.
Kernel is not a place for marketing.
> Thanks
> Macpaul Lin
Best regards,
Krzysztof
prev parent reply other threads:[~2023-09-12 6:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 8:11 [PATCH v2] dt-bindings: arm64: dts: mediatek: add description for mt8365-evk board Macpaul Lin
2023-09-11 9:49 ` Krzysztof Kozlowski
2023-09-12 6:29 ` Macpaul Lin
2023-09-12 6:52 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89341643-3d0e-89f6-f81c-579c56a358a3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bear.wang@mediatek.com \
--cc=bero@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=macpaul.lin@mediatek.com \
--cc=macpaul@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=pablo.sun@mediatek.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).