From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59CE8311C21 for ; Sat, 17 Jan 2026 12:07:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768651628; cv=none; b=gV9KMCBT7IDdDpK9s9m+oX9WqcuWCCqpKTtQvWdP99Qgdw6v04p+IXzScoEtKZzBslQajZORR2ucypWylAOJ8VgcuXwgeeqWSK21mmQVr/WHlfHmzOtAByl8zOy3Z96Uqj1uF469eJ9E/gOc4dto8QjFYMAtf9VdFLoB5OqAf8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768651628; c=relaxed/simple; bh=kFZnTHhF810bQp9nNoOgW5Uyv5Nf05hbdnxEqBknzYA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ChEemdWHB3pKIEADzXIdZUFmu9tCupGOyRo5aYWyp/uWduXuSmsL9B5WGV3+ISR/Ao67tL3bTuLcvNz6A8NbgGEtBVXFoUDsi9bBu3vt+wdeH289DqBt2q8BuuTluiZf36lvF94q2XkUS9sNphQ6Gd+UeQGPowbAfK43zOnq/SM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=k+2fa3ZE; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="k+2fa3ZE" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-38323dd7cb1so3326381fa.1 for ; Sat, 17 Jan 2026 04:07:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768651624; x=1769256424; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=A7ci2Vvjz2qESH5bzyRXoL8+ViHAPbN5MrVtZdVAlwk=; b=k+2fa3ZEael0cGHqNnZ4PLxrvqyK54hKAq/6V78jf1P7u/6SF5fve65aXsGW2+J79P NdRihjfBbjk+mq//QrITQqjF86FeqcF0iavZHZhLYtX5k0FGV1s+8OMv1eqAj7PwcCc5 vOpsMDdmwAj2Cu8jdonqnrmm7yxWZze9FZmbKSs8GqGcck5suwfmTCki64BO6gjvEVYV +8JJs1VIR0v05vL/+rJaXqGfAdxXGXKXLvUqfsonOBGq3RTE/b62A8D49+U2LRlrg4Dx xYONFBMpFCV2M3ppARl/g884FlAjWwLK1EPsAbJnJPMmQYT+mx9LWzgLpQdGv93SGTmq uS2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768651624; x=1769256424; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=A7ci2Vvjz2qESH5bzyRXoL8+ViHAPbN5MrVtZdVAlwk=; b=Ow5aHvyQeJInFc6IKyUxzavr3VrUusRYy/p2WFnuctZmipooqb+OZjS6mVGx8dZGlr nNJFaW+04oeWbm02d5Z6SenUpBHXfz3OSEtzncLUbS7KLcEI2+S4aIloFu/wEF+Z6ago HmV14HD6BzcUosV3+nJLqf9WIOvO/k0x5SxScIp+bIKBxenhgsN9PjmADHc4QqZZ5DpP j4eQF5F4tCw4g+ONi0qYakJabZmJ6kpuZdvYiFuPkbrt0phlpGcnYxddodSZ+vJNQA5Q OuSv9OlNpfxxLlEr0POVYu74AheARyixrMggVo5nt1P2hFz642nFdlNzlpW7Xd/w9gfY t2Gw== X-Forwarded-Encrypted: i=1; AJvYcCXdHKxl4dZZny8Twvry1jQwTI2wQB1CzanWesVZr5OH0aKl475WE1L3PRztIJmwebOtd1xmnqB6SEel@vger.kernel.org X-Gm-Message-State: AOJu0YwteQQbS1ZCH+7KaksyYA1TsT63QR8aMS7797sn/5Kayf4o2goK qIw5U6qn6XFNRtHMk0JuyTEiiuCwxqAxvVv3IkdTn/XV46Fgj28SgtIBF/fYoR9rkxc= X-Gm-Gg: AY/fxX6vabug8Lrc+nIQiQExiqukONth1oUCiDu9cFbMNGAwKKrIb3l6abaioAV8u9C USQvjhxZAHGXeZeSprb+3aVHFpv3O7gz+ZdPU3AQJQaas70F2y8z6p4EzPvo5YXQYV2djK3tm0w 2DAHB3tIAiycO15q8YtEZLZ5uNWQm4e18FbABnz5kaG3X+AvEy3juVym/9JJw+pQHyWMNIoNe8i V0+p+RaoiwWFkjoAiyO56B40ewwDUiV/FPeg1s6st8K+EECXKT0bH5NX4EXzVXP0f6AA4GQQsT5 3B2ZqFC5WPiUNOnX2fO/yS6hH5RnnpB4Y/7+3F7udK8hyWLSMgdHeseUzDmBdz5aKUWJmHG9/PG Vq+Gh4EWPabRMN6ZUYeH5JlQvE8Vcp3lbTZHYmr/R+3WnE/1PsPROX8GE4pXz/LGJDifdqlPy3/ K6q1K+WoiXyPeVs+cFeGzNk8jUxZtDH2dW9X9i92ebBgRcdnebfE+vhNdpMkS6LzCDBA== X-Received: by 2002:a05:6512:3515:b0:59a:10c1:8f27 with SMTP id 2adb3069b0e04-59baef10857mr1106330e87.6.1768651624379; Sat, 17 Jan 2026 04:07:04 -0800 (PST) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59baf34dd67sm1577385e87.29.2026.01.17.04.07.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Jan 2026 04:07:03 -0800 (PST) Message-ID: <893b39a0-3479-454c-b6a1-33144d075afa@linaro.org> Date: Sat, 17 Jan 2026 14:07:02 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 5/5] arm64: dts: qcom: sdm670-google-sargo: add imx355 front camera To: Richard Acayan , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Sakari Ailus , Tianshu Qiu , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: Robert Mader , Bryan O'Donoghue , David Heidelberg , phone-devel@vger.kernel.org References: <20260117040657.27043-1-mailingradian@gmail.com> <20260117040657.27043-6-mailingradian@gmail.com> From: Vladimir Zapolskiy In-Reply-To: <20260117040657.27043-6-mailingradian@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/17/26 06:06, Richard Acayan wrote: > The Sony IMX355 is the front camera on the Pixel 3a, mounted in portrait > mode. It is connected to CSIPHY1 and CCI I2C1, and uses MCLK2. Add > support for it. > > Co-developed-by: Robert Mader > Signed-off-by: Robert Mader > Signed-off-by: Richard Acayan > Reviewed-by: Bryan O'Donoghue > --- > .../boot/dts/qcom/sdm670-google-sargo.dts | 95 +++++++++++++++++++ > 1 file changed, 95 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts b/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts > index ed55646ca419..e925cba0381f 100644 > --- a/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts > +++ b/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts > @@ -172,6 +172,34 @@ vreg_s2b_1p05: vreg-s2b-regulator { > regulator-min-microvolt = <1050000>; > regulator-max-microvolt = <1050000>; > }; > + > + cam_front_ldo: cam-front-ldo-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "cam_front_ldo"; > + regulator-min-microvolt = <1352000>; > + regulator-max-microvolt = <1352000>; > + regulator-enable-ramp-delay = <135>; > + > + gpios = <&pm660l_gpios 4 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + pinctrl-0 = <&cam_front_ldo_pin>; > + pinctrl-names = "default"; > + }; > + > + cam_vio_ldo: cam-vio-ldo-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "cam_vio_ldo"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-enable-ramp-delay = <233>; > + > + gpios = <&pm660_gpios 13 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + pinctrl-0 = <&cam_vio_pin>; > + pinctrl-names = "default"; > + }; > }; > > &apps_rsc { > @@ -392,6 +420,59 @@ vreg_bob: bob { > }; > }; > > +&camss { > + vdda-phy-supply = <&vreg_l1a_1p225>; > + vdda-pll-supply = <&vreg_s6a_0p87>; > + > + status = "okay"; > +}; > + > +&camss_port1 { > + camss_endpoint1: endpoint { > + data-lanes = <0 1 2 3>; > + remote-endpoint = <&cam_front_endpoint>; > + }; > +}; Looks acceptable. > + > +&cci { > + pinctrl-0 = <&cci1_default>; > + pinctrl-1 = <&cci1_sleep>; > + pinctrl-names = "default", "sleep"; > + > + status = "okay"; > +}; > + > +&cci_i2c1 { > + camera@1a { > + compatible = "sony,imx355"; > + reg = <0x1a>; > + > + clocks = <&camcc CAM_CC_MCLK2_CLK>; > + > + assigned-clocks = <&camcc CAM_CC_MCLK2_CLK>; > + assigned-clock-rates = <19200000>; > + > + reset-gpios = <&tlmm 9 GPIO_ACTIVE_LOW>; > + > + avdd-supply = <&cam_front_ldo>; > + dvdd-supply = <&cam_front_ldo>; > + dovdd-supply = <&cam_vio_ldo>; > + > + pinctrl-0 = <&cam_mclk2_default>; > + pinctrl-names = "default"; > + > + rotation = <270>; > + orientation = <0>; > + > + port { > + cam_front_endpoint: endpoint { > + link-frequencies = /bits/ 64 <360000000>; > + remote-endpoint = <&camss_endpoint1>; > + }; > + }; > + }; > +}; > + > &gcc { > protected-clocks = , > , > @@ -490,6 +571,14 @@ &pm660_charger { > status = "okay"; > }; > > +&pm660_gpios { > + cam_vio_pin: cam-vio-state { > + pins = "gpio13"; > + function = "normal"; > + power-source = <0>; > + }; > +}; > + > &pm660_rradc { > status = "okay"; > }; > @@ -508,6 +597,12 @@ led-0 { > }; > > &pm660l_gpios { > + cam_front_ldo_pin: cam-front-state { > + pins = "gpio4"; > + function = "normal"; > + power-source = <0>; > + }; > + > vol_up_pin: vol-up-state { > pins = "gpio7"; > function = "normal"; Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir