From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42635C04A6A for ; Wed, 9 Aug 2023 14:27:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232174AbjHIO1x (ORCPT ); Wed, 9 Aug 2023 10:27:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232178AbjHIO1w (ORCPT ); Wed, 9 Aug 2023 10:27:52 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E923E2107 for ; Wed, 9 Aug 2023 07:27:50 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-3fe5eb84d8bso25140985e9.2 for ; Wed, 09 Aug 2023 07:27:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691591269; x=1692196069; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RIeum1LY6S9oOWjrA1Hz1M/iI/HQL9yzxT92jLmRvy4=; b=HKuEWv2S3p0ryCE+P2Er85fOrWyumOVzBMb6xINWCp41dK3t68nBKR+B+iMKIGJ5Eo MEOJ+9XXbMmls/NfkWrvFnUIshwXEa4bsYJ9jWwYLUyxLz/v7JISdtz6FD1lZD8vww+i ZesbgngH8DiqPthHakl1RDVSv7tLru+r9Uo7VBJESjkzZhIVR40WLXuYlEDi5+n22XE5 4TFyGe/QrdLsldg8veJ4ibTPeqBTQLaoVCrwXbVMQ0xnY7vjUbW3JJGsChLjeZ7k+AdL S8Pn29LRLWRPT3bEUSAyKbT1bReWDgsKYIfEsSXUAFsaZNQLGkTkEKdNfE2qL90hEKHF grBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691591269; x=1692196069; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RIeum1LY6S9oOWjrA1Hz1M/iI/HQL9yzxT92jLmRvy4=; b=Q4aGGFZfZE0+YGIaS02TCX0DE3M7KKfuMTZRkT3k0vlnH6cDziDBsdOczpHTAZ34F2 ZrQlDDiEWeEI/OY3OLYJbWHMk0P9Si779slcnB7Ur8iX4Bzl4awUBmIIt5zUtOCzRsfj gEGFyXC3uK3QTOJKVkyofLRklZ7t9Kvi16nYYN81ivOedg1Nq6vgkCNqrrOEMFxUa3cG rQWl/dLbCFG/YdGBACXwAhXg3N2zYbQBWwvu8ioa9+woM5NKGpzNtqSxlBnthTfOtzuK 488iUMM69qsB3su5zesqTNrK5Nwx/rpdkNMDUNPn65FJ093Mm5bSx9xIMC1CM7LvCZiQ kVtA== X-Gm-Message-State: AOJu0YxcpfGwCz3LcXfttncborAXLJ6v4zaMIVQiXjjmlj1HFqqRo7EB Vfos/l+H+c0cvf4MeH/v+FIK/n9VU11Nwb25v6DL+Q== X-Google-Smtp-Source: AGHT+IFcvrF/0+48M5rEwvbGq8wkuT4jgAfdSLYdgNQCBWGh9/ZxwvF01V2txrU3jt8NvdClblnr4w== X-Received: by 2002:a05:600c:219:b0:3fe:1deb:82 with SMTP id 25-20020a05600c021900b003fe1deb0082mr2306960wmi.7.1691591269368; Wed, 09 Aug 2023 07:27:49 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.113]) by smtp.gmail.com with ESMTPSA id 24-20020a05600c029800b003fe2397c17fsm2124090wmk.17.2023.08.09.07.27.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Aug 2023 07:27:48 -0700 (PDT) Message-ID: <893c3f40-3094-1939-833b-2edcd935c83c@linaro.org> Date: Wed, 9 Aug 2023 16:27:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2 1/2] dt-bindings: rtc: nuvoton: Add DT compatible Content-Language: en-US To: Mia Lin , avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, a.zummo@towertech.it, alexandre.belloni@bootlin.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, KWLIU@nuvoton.com, JJLIU0@nuvoton.com, KFLIN@nuvoton.com, mylin1@nuvoton.com Cc: openbmc@lists.ozlabs.org, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230809095112.2836-1-mimi05633@gmail.com> <20230809095112.2836-2-mimi05633@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230809095112.2836-2-mimi05633@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/08/2023 11:51, Mia Lin wrote: > Add DT compatible "nuvoton,nct3015y" to select > > Signed-off-by: Mia Lin > --- > Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml b/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml > index 4f9b5604acd9..67fc60fd395c 100644 > --- a/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml > +++ b/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml > @@ -15,7 +15,9 @@ maintainers: > > properties: > compatible: > - const: nuvoton,nct3018y > + enum: > + - nuvoton,nct3018y > + - nuvoton,nct3015y Responding here, but based on your changelog and driver: Why? Why do you need compatibles to verify the reported ID? Verifying ID does not make sense. At all. These are compatible devices, so you could have one more compatible using old one as fallback. And no new entry in the driver. Best regards, Krzysztof