[PATCH 0/2] Add R8A77970/Eagle CAN-FD support

[PATCH 0/2] Add R8A77970/Eagle CAN-FD support

[Sergei Shtylyov]

Hello!

Here's the set of 2 patches against Simon Horman's 'renesas.git' repo's
'renesas-devel-20180426-v4.17-rc2' tag. We're adding the R8A77970 CAN-FD
device node and then enable single chnanel CAN-FD support on the Eagle board.

[1/2] arm64: dts: renesas: r8a77970: add CAN-FD support
[2/2] arm64: dts: renesas: eagle: add CAN-FD support

WBR, Sergei

[PATCH 1/2] arm64: dts: renesas: r8a77970: add CAN-FD support

[Sergei Shtylyov]

Define the generic R8A77970 part of the CAN-FD device node.

Based on the original (and large) patch by Vladimir Barinov.

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 arch/arm64/boot/dts/renesas/r8a77970.dtsi |   32 ++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

Index: renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
===================================================================
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970.dtsi
+++ renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
@@ -68,6 +68,13 @@
 		method = "smc";
 	};
 
+	/* External CAN clock - to be overridden by boards that provide it */
+	can_clk: can {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <0>;
+	};
+
 	/* External SCIF clock - to be overridden by boards that provide it */
 	scif_clk: scif {
 		compatible = "fixed-clock";
@@ -381,6 +388,31 @@
 			status = "disabled";
 		};
 
+		canfd: can@e66c0000 {
+			compatible = "renesas,r8a77970-canfd",
+				     "renesas,rcar-gen3-canfd";
+			reg = <0 0xe66c0000 0 0x8000>;
+			interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 914>,
+				 <&cpg CPG_CORE R8A77970_CLK_CANFD>,
+				 <&can_clk>;
+			clock-names = "fck", "canfd", "can_clk";
+			assigned-clocks = <&cpg CPG_CORE R8A77970_CLK_CANFD>;
+			assigned-clock-rates = <40000000>;
+			power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
+			resets = <&cpg 914>;
+			status = "disabled";
+
+			channel0 {
+				status = "disabled";
+			};
+
+			channel1 {
+				status = "disabled";
+			};
+		};
+
 		avb: ethernet@e6800000 {
 			compatible = "renesas,etheravb-r8a77970",
 				     "renesas,etheravb-rcar-gen3";

RE: [PATCH 1/2] arm64: dts: renesas: r8a77970: add CAN-FD support

[Ramesh Shanmugasundaram]

> Subject: [PATCH 1/2] arm64: dts: renesas: r8a77970: add CAN-FD support
> 
> Define the generic R8A77970 part of the CAN-FD device node.
> 
> Based on the original (and large) patch by Vladimir Barinov.
> 
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Acked-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>

Thanks,
Ramesh

Re: [PATCH 1/2] arm64: dts: renesas: r8a77970: add CAN-FD support

[Simon Horman]

On Fri, Apr 27, 2018 at 12:35:02PM +0000, Ramesh Shanmugasundaram wrote:
> > Subject: [PATCH 1/2] arm64: dts: renesas: r8a77970: add CAN-FD support
> > 
> > Define the generic R8A77970 part of the CAN-FD device node.
> > 
> > Based on the original (and large) patch by Vladimir Barinov.
> > 
> > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> Acked-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>

Thanks, applied.

[PATCH 2/2] arm64: dts: renesas: eagle: add CAN-FD support

[Sergei Shtylyov]

Define the Eagle board dependent part of the CAN-FD device node.

Based on the original (and large) patch by Vladimir Barinov.

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 arch/arm64/boot/dts/renesas/r8a77970-eagle.dts |   15 +++++++++++++++
 1 file changed, 15 insertions(+)

Index: renesas/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
===================================================================
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
+++ renesas/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
@@ -95,6 +95,16 @@
 	};
 };
 
+&canfd {
+	pinctrl-0 = <&canfd0_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+
+	channel0 {
+		status = "okay";
+	};
+};
+
 &extal_clk {
 	clock-frequency = <16666666>;
 };
@@ -156,6 +166,11 @@
 		function = "avb0";
 	};
 
+	canfd0_pins: canfd0 {
+		groups = "canfd0_data_a";
+		function = "canfd0";
+	};
+
 	i2c0_pins: i2c0 {
 		groups = "i2c0";
 		function = "i2c0";

RE: [PATCH 2/2] arm64: dts: renesas: eagle: add CAN-FD support

[Ramesh Shanmugasundaram]

> Subject: [PATCH 2/2] arm64: dts: renesas: eagle: add CAN-FD support
> 
> Define the Eagle board dependent part of the CAN-FD device node.
> 
> Based on the original (and large) patch by Vladimir Barinov.
> 
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 

Acked-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>

Thanks,
Ramesh

Re: [PATCH 2/2] arm64: dts: renesas: eagle: add CAN-FD support

[Simon Horman]

On Fri, Apr 27, 2018 at 12:35:05PM +0000, Ramesh Shanmugasundaram wrote:
> > Subject: [PATCH 2/2] arm64: dts: renesas: eagle: add CAN-FD support
> > 
> > Define the Eagle board dependent part of the CAN-FD device node.
> > 
> > Based on the original (and large) patch by Vladimir Barinov.
> > 
> > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > 
> 
> Acked-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>

Thanks, applied.

RE: [PATCH 0/2] Add R8A77970/Eagle CAN-FD support

[Ramesh Shanmugasundaram]

Hi Sergei,

Thank you for your patch. 
Could you also update the dt bindings please? A separate patch or part of this series.

> Subject: [PATCH 0/2] Add R8A77970/Eagle CAN-FD support
> 
> Hello!
> 
> Here's the set of 2 patches against Simon Horman's 'renesas.git' repo's
> 'renesas-devel-20180426-v4.17-rc2' tag. We're adding the R8A77970 CAN-FD
> device node and then enable single chnanel CAN-FD support on the Eagle
> board.
> 
> [1/2] arm64: dts: renesas: r8a77970: add CAN-FD support
> [2/2] arm64: dts: renesas: eagle: add CAN-FD support
> 
> WBR, Sergei

Thanks,
Ramesh

Re: [PATCH 0/2] Add R8A77970/Eagle CAN-FD support

[Sergei Shtylyov]

Hello!

On 04/27/2018 12:46 PM, Ramesh Shanmugasundaram wrote:

> Thank you for your patch. 
> Could you also update the dt bindings please? A separate patch or part of this series.

   I'd posted it just before these patches, see:

https://patchwork.kernel.org/patch/10366727/

MBR, Sergei

RE: [PATCH 0/2] Add R8A77970/Eagle CAN-FD support

[Ramesh Shanmugasundaram]

Hello Sergei,

Thanks. I did search my DT folder before response but it is queued under different folder ☹
Sorry for the noise.

Thanks,
Ramesh

> Subject: Re: [PATCH 0/2] Add R8A77970/Eagle CAN-FD support
> 
> Hello!
> 
> On 04/27/2018 12:46 PM, Ramesh Shanmugasundaram wrote:
> 
> > Thank you for your patch.
> > Could you also update the dt bindings please? A separate patch or part
> of this series.
> 
>    I'd posted it just before these patches, see:
> 
> https://patchwork.kernel.org/patch/10366727/
> 
> MBR, Sergei
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel