From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93D1DC00140 for ; Fri, 12 Aug 2022 09:47:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237536AbiHLJr2 (ORCPT ); Fri, 12 Aug 2022 05:47:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237173AbiHLJrY (ORCPT ); Fri, 12 Aug 2022 05:47:24 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 398D7AA3DB for ; Fri, 12 Aug 2022 02:47:23 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id c17so647018lfb.3 for ; Fri, 12 Aug 2022 02:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=DywEXydriB9RHQfiUoHdykArQLV4TBJt7mtn5YtjZoE=; b=LwBHdnO1aRo+0D4D+H6G/KpkkhcLYKCY5twp4lafcbV2iNbBewTSuDHWAicBUVyZ6k XD8W67AyOXCddFyRPbPFxX2NebnYA8KEpp5Bv1Uh9wvmz3oLqEDa6EGVrbCQmkmAdSUr EGjZXkJ2DQHVf2RSr3780Kkzyl1edtbSVocJT6VzGItAQ6VoQ+9Z+gaRbWBDXkp1YsBz JevUOIXgRV99bgu4/HsyvOTB7UNcUJ1vMtw9ObV0ZAadxCMhg/p12YxZ5xKeVDbCtuY+ 2w0sy1R7C0exFVZAMQp1oHgeQ3MBNp6OdxY5twq70XNaD7QKfqQqwY6cZ5LNxMH01tpc 1O9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=DywEXydriB9RHQfiUoHdykArQLV4TBJt7mtn5YtjZoE=; b=3z0yiSZAynQVc4xGmn8bjfPtu+Y6J/HJ+0EOzpu9yrN2ZiyHaRv0R9mMo1mVo5f6Fn trKkow2Mtpb000TDtDGwrbCRojLn2cYHPQJZP0YGmC0kL5q8APGkRjd4PaZ78hmzPH5r orthRDr9el0OQ4XYZS1WHc1Mc3zW1csN9jR7wzb+fql4myE82yQ9Ersc3ckvBss6XJA/ lRly0eZkxpMBNzO9tm/WzFCL1+l5K+62jKadmZffgrW+ZTuVBBq8MMMcmI77sIG/9WrD 2xAm6Us/xilVFBorD8AUB2vRKo3RfeNijLY9rqZnsWlRlJJy2M0DWv/db3gbKLW/zajy ZsaA== X-Gm-Message-State: ACgBeo3T6CfKFUcnbr0CSJCRkQpuGBCveOilFt+twj7xVsjS5G5fc8no 4IAaFhIbFjjnaDOOkxE7xs9Vdw== X-Google-Smtp-Source: AA6agR7eHNAVuLG1Tzwad6XCZn0/j6CytzXhWajS9DLvUg5eG94lCgboTQKVISVSGSj5oeRbZaww8g== X-Received: by 2002:a05:6512:3fa8:b0:48c:ffd1:625d with SMTP id x40-20020a0565123fa800b0048cffd1625dmr925593lfa.251.1660297641606; Fri, 12 Aug 2022 02:47:21 -0700 (PDT) Received: from [192.168.1.39] ([83.146.140.105]) by smtp.gmail.com with ESMTPSA id bf31-20020a2eaa1f000000b0025e496dad47sm295617ljb.26.2022.08.12.02.47.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Aug 2022 02:47:21 -0700 (PDT) Message-ID: <8962b7ed-a21c-0b7f-7a6d-5db3db84e4cb@linaro.org> Date: Fri, 12 Aug 2022 12:47:17 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v4 2/2] arm64: dts: imx8mp-msc-sm2s: Add device trees for MSC SM2S-IMX8PLUS SoM and carrier board Content-Language: en-US To: Martyn Welch , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Cc: kernel@collabora.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220812084120.376042-1-martyn.welch@collabora.com> <20220812084120.376042-2-martyn.welch@collabora.com> From: Krzysztof Kozlowski In-Reply-To: <20220812084120.376042-2-martyn.welch@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/08/2022 11:41, Martyn Welch wrote: > Add device trees for one of a number of MSC's (parent company, Avnet) > variants of the SM2S-IMX8PLUS system on module along with the compatible > SM2S-SK-AL-EP1 carrier board. As the name suggests, this family of SoMs use > the NXP i.MX8MP SoC and provide the SMARC module interface. > > Signed-off-by: Martyn Welch > --- > > Changes in v2 > - Added compatibles > - Removed underscores from node names > - Make node names more generic > - Reorder properties > - Fix issues found by dtbs_check in these files > > Changes in v3: > - Switched to avnet vendor string in compatibles > - Corrected patch description > > Changes in v4: > - Switched from phy-reset-gpios to reset-gpios, removing duplication > - Removed unneeded sdma1 node > > arch/arm64/boot/dts/freescale/Makefile | 1 + > .../freescale/imx8mp-msc-sm2s-14N0600E.dts | 72 ++ > .../dts/freescale/imx8mp-msc-sm2s-ep1.dts | 53 ++ > .../boot/dts/freescale/imx8mp-msc-sm2s.dtsi | 812 ++++++++++++++++++ > 4 files changed, 938 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-14N0600E.dts > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s.dtsi > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > index 8bf7f7ecebaa..139c8b95c9c9 100644 > --- a/arch/arm64/boot/dts/freescale/Makefile > +++ b/arch/arm64/boot/dts/freescale/Makefile > @@ -83,6 +83,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mn-venice-gw7902.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw74xx.dtb > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-14N0600E.dts b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-14N0600E.dts > new file mode 100644 > index 000000000000..9e976e8baaee > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-14N0600E.dts > @@ -0,0 +1,72 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2022 Avnet Embedded GmbH > + */ > +/dts-v1/; > + > +#include "imx8mp-msc-sm2s.dtsi" > + > +/ { > + model = "MSC SM2S-IMX8PLUS-QC6-14N0600E SoM"; > + compatible = "avnet,sm2s-imx8mp-14N0600E", "avnet,sm2s-imx8mp", > + "fsl,imx8mp"; This does not match your bindings. Please test your DTS. Best regards, Krzysztof