From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C285EB64D9 for ; Mon, 10 Jul 2023 07:44:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229978AbjGJHoh (ORCPT ); Mon, 10 Jul 2023 03:44:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230352AbjGJHo0 (ORCPT ); Mon, 10 Jul 2023 03:44:26 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A6D9124 for ; Mon, 10 Jul 2023 00:44:21 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2b6f97c7115so61218881fa.2 for ; Mon, 10 Jul 2023 00:44:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688975059; x=1691567059; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6XrmlGPg2875uNjm6boMUV/4SOLisp7J98OyN2fD1Tw=; b=pPrTTLBnGur5kN4+tW9BpSR3CRK1iLs2xQ5LA2jYbG3ZnCOdgiR7x3rbMWZL0wIKcY ONovt9MrvNp/PSjRLm1unFrsXKnzjZzi//nZT3gxyU50a24CvIN5RidEKkSt+GVbrZp9 vZH80Y9T28gpopOKUjPEFZ8Vs3K2XDFsxTf2j+dtOdnKfFY9e6/Q0oKGetam1di2/X1y rt0YDTle3h8GKRvd70ctpI4X4Y8ZJHZvei8eceydWn7zMwZLNa6G34HqPTUTrwt3FpWx LnQz5pA0SadArrSv9a1CJYdaiP88Al05514dB6CU9x+4dPjdZZDS0q5iDfUjqrPToFHx VH+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688975059; x=1691567059; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6XrmlGPg2875uNjm6boMUV/4SOLisp7J98OyN2fD1Tw=; b=fXaHwfX4md6S74ZFfQ7mqN8o2JJpjYzS0HZZgoEmLC677Lc/Bt2BTy506/U2chAwVg W7mfedtkb56HxyJD/gKPOmMf2AvwsV6ocEZ2zVISIkj6hl0gyoSArBwgZBUPQPORuBRV I0kk0Dhpm+Vfjgu6YOJ/EcoS1eePY94jXQsrt0kXrubydvZQ1zN7n7zMz9dFe8e141we uDR/UohG7F2B8NQ2jsOA9lV1Ql2r8UAqBf/VqDhI1i+t9SEuAFNbmW6MVdQEDQQoBLwc oz+6H9T+9qbmz3aqsztkZ7Au71C07FPKM92KIWbxz0KNxgDZwnhlyrVcKOVsVDtFRGFo mR7Q== X-Gm-Message-State: ABy/qLYoJmWuMWZEBUbFYVczouMbXWn+rp3Yl8Mf78apyI75CD8mofzL GSvJSfWcVIE+4FmBNrDKuhMbZg== X-Google-Smtp-Source: APBJJlG9EwwBqMxbwjIJnMoPkWXpbz49k2oZ4zzVaR1jVwtsSlECY1RtVLmIAi3Z49JKpD4MBMXLZg== X-Received: by 2002:a2e:7013:0:b0:2b6:d536:1bba with SMTP id l19-20020a2e7013000000b002b6d5361bbamr9641213ljc.18.1688975059356; Mon, 10 Jul 2023 00:44:19 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id n25-20020a2e86d9000000b002b6cc17add3sm1886857ljj.25.2023.07.10.00.44.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jul 2023 00:44:18 -0700 (PDT) Message-ID: <8966feba-eef9-2ea3-dbec-13fc53232a6b@linaro.org> Date: Mon, 10 Jul 2023 10:44:18 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [EXT] Re: [PATCH v6 4/8] phy: Add HDMI configuration options Content-Language: en-GB To: Sandor Yu , "andrzej.hajda@intel.com" , "neil.armstrong@linaro.org" , "robert.foss@linaro.org" , "Laurent.pinchart@ideasonboard.com" , "jonas@kwiboo.se" , "jernej.skrabec@gmail.com" , "airlied@gmail.com" , "daniel@ffwll.ch" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , "vkoul@kernel.org" , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-phy@lists.infradead.org" Cc: "kernel@pengutronix.de" , dl-linux-imx , Oliver Brown References: <6f590bb6-7d17-3ae8-684d-2d4403d6ff55@linaro.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/07/2023 10:28, Sandor Yu wrote: > Hi Dmitry, > > Thanks for your comments, > >> From: Dmitry Baryshkov >> On 15/06/2023 04:38, Sandor Yu wrote: >>> Allow HDMI PHYs to be configured through the generic functions through >>> a custom structure added to the generic union. >>> >>> The parameters added here are based on HDMI PHY implementation >>> practices. The current set of parameters should cover the potential >>> users. >>> >>> Signed-off-by: Sandor Yu >>> --- >>> include/linux/phy/phy-hdmi.h | 38 >> ++++++++++++++++++++++++++++++++++++ >>> include/linux/phy/phy.h | 7 ++++++- >>> 2 files changed, 44 insertions(+), 1 deletion(-) >>> create mode 100644 include/linux/phy/phy-hdmi.h >>> >>> diff --git a/include/linux/phy/phy-hdmi.h >>> b/include/linux/phy/phy-hdmi.h new file mode 100644 index >>> 000000000000..5765aa5bc175 >>> --- /dev/null >>> +++ b/include/linux/phy/phy-hdmi.h >>> @@ -0,0 +1,38 @@ >>> +/* SPDX-License-Identifier: GPL-2.0 */ >>> +/* >>> + * Copyright 2022 NXP >>> + */ >>> + >>> +#ifndef __PHY_HDMI_H_ >>> +#define __PHY_HDMI_H_ >>> + >>> +/** >>> + * Pixel Encoding as HDMI Specification >>> + * RGB, YUV422, YUV444:HDMI Specification 1.4a Section 6.5 >>> + * YUV420: HDMI Specification 2.a Section 7.1 */ enum >>> +hdmi_phy_colorspace { >>> + HDMI_PHY_COLORSPACE_RGB, /* RGB 4:4:4 */ >>> + HDMI_PHY_COLORSPACE_YUV422, /* YCbCr 4:2:2 */ >>> + HDMI_PHY_COLORSPACE_YUV444, /* YCbCr 4:4:4 */ >>> + HDMI_PHY_COLORSPACE_YUV420, /* YCbCr 4:2:0 */ >>> + HDMI_PHY_COLORSPACE_RESERVED4, >>> + HDMI_PHY_COLORSPACE_RESERVED5, >>> + HDMI_PHY_COLORSPACE_RESERVED6, >>> +}; >> >> This enum duplicates enum hdmi_colorspace from HDMI 2.0 >> defines '7' to be IDO-defined. >> >> Would it be better to use that enum instead? > Accept. I will create head file hdmi_colorspace.h to reuse enum hdmi_colorspace in . Excuse me, it was supposed to be a question. Do you need another header file to reuse this enum? > > B.R > Sandor >> >>> + >>> +/** >>> + * struct phy_configure_opts_hdmi - HDMI configuration set >>> + * @pixel_clk_rate: Pixel clock of video modes in KHz. >>> + * @bpc: Maximum bits per color channel. >>> + * @color_space: Colorspace in enum hdmi_phy_colorspace. >>> + * >>> + * This structure is used to represent the configuration state of a HDMI phy. >>> + */ >>> +struct phy_configure_opts_hdmi { >>> + unsigned int pixel_clk_rate; >>> + unsigned int bpc; >>> + enum hdmi_phy_colorspace color_space; }; >>> + >>> +#endif /* __PHY_HDMI_H_ */ >> >> [skipped the rest] >> >> -- >> With best wishes >> Dmitry > -- With best wishes Dmitry