From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Xin Xu <xxsemail@qq.com>, andersson@kernel.org, konradybcio@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sm8250-xiaomi-elish: add ov8856 front camera
Date: Wed, 24 Jun 2026 13:56:05 +0200 [thread overview]
Message-ID: <896f3704-e7bb-48da-a501-0c9b0228573d@oss.qualcomm.com> (raw)
In-Reply-To: <tencent_A7DA95458754255A62A4C730EEE484AB2905@qq.com>
On 6/22/26 8:52 PM, Xin Xu wrote:
> Add the ov8856 front camera, connected on CCI1 to CSIPHY4 and
> powered by pm8008 LDOs and other supplies.
>
> Signed-off-by: Xin Xu <xxsemail@qq.com>
> ---
[...]
> &cdsp {
> firmware-name = "qcom/sm8250/xiaomi/elish/cdsp.mbn";
> status = "okay";
> @@ -877,6 +933,20 @@ bt_en_state: bt-default-state {
> bias-pull-up;
> };
>
> + camera_front_active: camera-front-active-state {
> + pins = "gpio109";
> + function = "gpio";
> + bias-disable;
> + drive-strength = <2>;
> + };
> +
> + mclk3_active: mclk3-active-state {
> + pins = "gpio97";
> + function = "cam_mclk";
> + bias-disable;
> + drive-strength = <4>;
> + };
nit: other nodes have drive-strength before bias-disable
Also let's move the mclk pin state definition to sm8250, it's not
specific to this board
Konrad
next prev parent reply other threads:[~2026-06-24 11:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 18:46 [PATCH v2 1/2] arm64: dts: qcom: sm8250-xiaomi-elish: Add pm8008 PMIC Xin Xu
2026-06-22 18:52 ` [PATCH v2 2/2] arm64: dts: qcom: sm8250-xiaomi-elish: add ov8856 front camera Xin Xu
2026-06-24 11:56 ` Konrad Dybcio [this message]
2026-06-25 11:30 ` Xin Xu
2026-06-24 11:57 ` [PATCH v2 1/2] arm64: dts: qcom: sm8250-xiaomi-elish: Add pm8008 PMIC Konrad Dybcio
2026-06-24 12:00 ` Konrad Dybcio
2026-06-25 10:37 ` Xin Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=896f3704-e7bb-48da-a501-0c9b0228573d@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xxsemail@qq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox