[PATCH 1/4] drm: panel: jadard-jd9365da-h3: Fix panel vendor and model

[PATCH 1/4] drm: panel: jadard-jd9365da-h3: Fix panel vendor and model

[Jagan Teki]

The initial datasheet claimed that chouzhong designed this 10"
DSI panel on top of JD9365DA IC, but later Radxa mentioned that
chouzhong is the manufacturer.

So the actual design of the panel, gsensor, and customized FPC
is done by Radxa. The panel model named is Radxa Display 10HD
with AD001 is the part number.

Fix the binding and panel driver with the proper panel vendor
and model.

Fixes: <6b818c533dd8> ("drm: panel: Add Jadard JD9365DA-H3 DSI panel")
Fixes: <bb3098eead99> ("dt-bindings: display: Document Jadard
JD9365DA-H3 DSI panel")
Reported-by: Tom Cubie <tom@radxa.com>
Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
 .../bindings/display/panel/jadard,jd9365da-h3.yaml  |  4 ++--
 drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c    | 13 ++++++++-----
 2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
index c06902e4fe70..10ba1b813304 100644
--- a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
+++ b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
@@ -16,7 +16,7 @@ properties:
   compatible:
     items:
       - enum:
-          - chongzhou,cz101b4001
+          - radxa,display-10hd-ad001
       - const: jadard,jd9365da-h3
 
   reg: true
@@ -52,7 +52,7 @@ examples:
         #size-cells = <0>;
 
         panel@0 {
-            compatible = "chongzhou,cz101b4001", "jadard,jd9365da-h3";
+            compatible = "radxa,display-10hd-ad001", "jadard,jd9365da-h3";
             reg = <0>;
             vdd-supply = <&lcd_3v3>;
             vccio-supply = <&vcca_1v8>;
diff --git a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
index 48c1702a863b..ea89cecad0cf 100644
--- a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
+++ b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
@@ -167,7 +167,7 @@ static const struct drm_panel_funcs jadard_funcs = {
 	.get_modes = jadard_get_modes,
 };
 
-static const struct jadard_init_cmd cz101b4001_init_cmds[] = {
+static const struct jadard_init_cmd radxa_display_10hd_ad001_init_cmds[] = {
 	{ .data = { 0xE0, 0x00 } },
 	{ .data = { 0xE1, 0x93 } },
 	{ .data = { 0xE2, 0x65 } },
@@ -364,7 +364,7 @@ static const struct jadard_init_cmd cz101b4001_init_cmds[] = {
 	{ .data = { 0xE7, 0x0C } },
 };
 
-static const struct jadard_panel_desc cz101b4001_desc = {
+static const struct jadard_panel_desc radxa_display_10hd_ad001_desc = {
 	.mode = {
 		.clock		= 70000,
 
@@ -384,8 +384,8 @@ static const struct jadard_panel_desc cz101b4001_desc = {
 	},
 	.lanes = 4,
 	.format = MIPI_DSI_FMT_RGB888,
-	.init_cmds = cz101b4001_init_cmds,
-	.num_init_cmds = ARRAY_SIZE(cz101b4001_init_cmds),
+	.init_cmds = radxa_display_10hd_ad001_init_cmds,
+	.num_init_cmds = ARRAY_SIZE(radxa_display_10hd_ad001_init_cmds),
 };
 
 static int jadard_dsi_probe(struct mipi_dsi_device *dsi)
@@ -452,7 +452,10 @@ static void jadard_dsi_remove(struct mipi_dsi_device *dsi)
 }
 
 static const struct of_device_id jadard_of_match[] = {
-	{ .compatible = "chongzhou,cz101b4001", .data = &cz101b4001_desc },
+	{
+		.compatible = "radxa,display-10hd-ad001",
+		.data = &radxa_display_10hd_ad001_desc
+	},
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, jadard_of_match);
-- 
2.25.1

[PATCH 2/4] Revert "dt-bindings: vendor-prefixes: Document Chongzhou"

[Jagan Teki]

This reverts commit 90f86d0c617d9461cb00f4d8e861eda28011d46e.

[why]
The initial datasheet claimed that chouzhong designed the 10" DSI
panel on top of JD9365DA IC, but later Radxa mentioned that chouzhong
is the manufacturer. This concludes that the actual design of the
panel, gsensor, and customized FPC is done by Radxa.

So, drop the Chongzhou vendor-prefix as it is no longer useful
anywhere in the bindings.

Reported-by: Tom Cubie <tom@radxa.com>
Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 70ffb3780621..f5d0e75dab1f 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -248,8 +248,6 @@ patternProperties:
     description: ChipOne
   "^chipspark,.*":
     description: ChipSPARK
-  "^chongzhou,.*":
-    description: Shenzhen Chongzhou Electronic Technology Co., Ltd
   "^chrontel,.*":
     description: Chrontel, Inc.
   "^chrp,.*":
-- 
2.25.1

Re: [PATCH 2/4] Revert "dt-bindings: vendor-prefixes: Document Chongzhou"

[Krzysztof Kozlowski]

On 23/01/2023 17:40, Jagan Teki wrote:
> This reverts commit 90f86d0c617d9461cb00f4d8e861eda28011d46e.
> 
> [why]
> The initial datasheet claimed that chouzhong designed the 10" DSI
> panel on top of JD9365DA IC, but later Radxa mentioned that chouzhong
> is the manufacturer. This concludes that the actual design of the
> panel, gsensor, and customized FPC is done by Radxa.
> 
> So, drop the Chongzhou vendor-prefix as it is no longer useful
> anywhere in the bindings.
> 
> Reported-by: Tom Cubie <tom@radxa.com>

If it is a real company making real products, we can keep it. We might
need it soon anyway.

Best regards,
Krzysztof

[PATCH 3/4] dt-bindings: display: panel: jadard,jd9365da-h3: Add Radxa Display 8HD

[Jagan Teki]

Radxa Display 8HD is a family of DSI panels from Radxa that
uses jd9365da-h3 IC.

Add compatible string for it.

Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
 .../devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml    | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
index 10ba1b813304..d81b7fab4604 100644
--- a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
+++ b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
@@ -17,6 +17,7 @@ properties:
     items:
       - enum:
           - radxa,display-10hd-ad001
+          - radxa,display-8hd-ad002
       - const: jadard,jd9365da-h3
 
   reg: true
-- 
2.25.1

Re: [PATCH 3/4] dt-bindings: display: panel: jadard,jd9365da-h3: Add Radxa Display 8HD

[Krzysztof Kozlowski]

On 23/01/2023 17:40, Jagan Teki wrote:
> Radxa Display 8HD is a family of DSI panels from Radxa that
> uses jd9365da-h3 IC.
> 
> Add compatible string for it.


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH 4/4] drm: panel: jd9365da-h3: Add Radxa Display 8HD

[Jagan Teki]

Radxa Display 8HD is a family of DSI panels from Radxa that
uses jd9365da-h3 IC.

Add support for it.

Co-developed-by: Stephen Chen <stephen@radxa.com>
Signed-off-by: Stephen Chen <stephen@radxa.com>
Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
 .../gpu/drm/panel/panel-jadard-jd9365da-h3.c  | 200 ++++++++++++++++++
 1 file changed, 200 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
index ea89cecad0cf..7be8e6ab2da9 100644
--- a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
+++ b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
@@ -167,6 +167,202 @@ static const struct drm_panel_funcs jadard_funcs = {
 	.get_modes = jadard_get_modes,
 };
 
+static const struct jadard_init_cmd radxa_display_8hd_ad002_init_cmds[] = {
+	{ .data = { 0xE0, 0x00 } },
+	{ .data = { 0xE1, 0x93 } },
+	{ .data = { 0xE2, 0x65 } },
+	{ .data = { 0xE3, 0xF8 } },
+	{ .data = { 0x80, 0x03 } },
+	{ .data = { 0xE0, 0x01 } },
+	{ .data = { 0x00, 0x00 } },
+	{ .data = { 0x01, 0x7E } },
+	{ .data = { 0x03, 0x00 } },
+	{ .data = { 0x04, 0x65 } },
+	{ .data = { 0x0C, 0x74 } },
+	{ .data = { 0x17, 0x00 } },
+	{ .data = { 0x18, 0xB7 } },
+	{ .data = { 0x19, 0x00 } },
+	{ .data = { 0x1A, 0x00 } },
+	{ .data = { 0x1B, 0xB7 } },
+	{ .data = { 0x1C, 0x00 } },
+	{ .data = { 0x24, 0xFE } },
+	{ .data = { 0x37, 0x19 } },
+	{ .data = { 0x38, 0x05 } },
+	{ .data = { 0x39, 0x00 } },
+	{ .data = { 0x3A, 0x01 } },
+	{ .data = { 0x3B, 0x01 } },
+	{ .data = { 0x3C, 0x70 } },
+	{ .data = { 0x3D, 0xFF } },
+	{ .data = { 0x3E, 0xFF } },
+	{ .data = { 0x3F, 0xFF } },
+	{ .data = { 0x40, 0x06 } },
+	{ .data = { 0x41, 0xA0 } },
+	{ .data = { 0x43, 0x1E } },
+	{ .data = { 0x44, 0x0F } },
+	{ .data = { 0x45, 0x28 } },
+	{ .data = { 0x4B, 0x04 } },
+	{ .data = { 0x55, 0x02 } },
+	{ .data = { 0x56, 0x01 } },
+	{ .data = { 0x57, 0xA9 } },
+	{ .data = { 0x58, 0x0A } },
+	{ .data = { 0x59, 0x0A } },
+	{ .data = { 0x5A, 0x37 } },
+	{ .data = { 0x5B, 0x19 } },
+	{ .data = { 0x5D, 0x78 } },
+	{ .data = { 0x5E, 0x63 } },
+	{ .data = { 0x5F, 0x54 } },
+	{ .data = { 0x60, 0x49 } },
+	{ .data = { 0x61, 0x45 } },
+	{ .data = { 0x62, 0x38 } },
+	{ .data = { 0x63, 0x3D } },
+	{ .data = { 0x64, 0x28 } },
+	{ .data = { 0x65, 0x43 } },
+	{ .data = { 0x66, 0x41 } },
+	{ .data = { 0x67, 0x43 } },
+	{ .data = { 0x68, 0x62 } },
+	{ .data = { 0x69, 0x50 } },
+	{ .data = { 0x6A, 0x57 } },
+	{ .data = { 0x6B, 0x49 } },
+	{ .data = { 0x6C, 0x44 } },
+	{ .data = { 0x6D, 0x37 } },
+	{ .data = { 0x6E, 0x23 } },
+	{ .data = { 0x6F, 0x10 } },
+	{ .data = { 0x70, 0x78 } },
+	{ .data = { 0x71, 0x63 } },
+	{ .data = { 0x72, 0x54 } },
+	{ .data = { 0x73, 0x49 } },
+	{ .data = { 0x74, 0x45 } },
+	{ .data = { 0x75, 0x38 } },
+	{ .data = { 0x76, 0x3D } },
+	{ .data = { 0x77, 0x28 } },
+	{ .data = { 0x78, 0x43 } },
+	{ .data = { 0x79, 0x41 } },
+	{ .data = { 0x7A, 0x43 } },
+	{ .data = { 0x7B, 0x62 } },
+	{ .data = { 0x7C, 0x50 } },
+	{ .data = { 0x7D, 0x57 } },
+	{ .data = { 0x7E, 0x49 } },
+	{ .data = { 0x7F, 0x44 } },
+	{ .data = { 0x80, 0x37 } },
+	{ .data = { 0x81, 0x23 } },
+	{ .data = { 0x82, 0x10 } },
+	{ .data = { 0xE0, 0x02 } },
+	{ .data = { 0x00, 0x47 } },
+	{ .data = { 0x01, 0x47 } },
+	{ .data = { 0x02, 0x45 } },
+	{ .data = { 0x03, 0x45 } },
+	{ .data = { 0x04, 0x4B } },
+	{ .data = { 0x05, 0x4B } },
+	{ .data = { 0x06, 0x49 } },
+	{ .data = { 0x07, 0x49 } },
+	{ .data = { 0x08, 0x41 } },
+	{ .data = { 0x09, 0x1F } },
+	{ .data = { 0x0A, 0x1F } },
+	{ .data = { 0x0B, 0x1F } },
+	{ .data = { 0x0C, 0x1F } },
+	{ .data = { 0x0D, 0x1F } },
+	{ .data = { 0x0E, 0x1F } },
+	{ .data = { 0x0F, 0x5F } },
+	{ .data = { 0x10, 0x5F } },
+	{ .data = { 0x11, 0x57 } },
+	{ .data = { 0x12, 0x77 } },
+	{ .data = { 0x13, 0x35 } },
+	{ .data = { 0x14, 0x1F } },
+	{ .data = { 0x15, 0x1F } },
+	{ .data = { 0x16, 0x46 } },
+	{ .data = { 0x17, 0x46 } },
+	{ .data = { 0x18, 0x44 } },
+	{ .data = { 0x19, 0x44 } },
+	{ .data = { 0x1A, 0x4A } },
+	{ .data = { 0x1B, 0x4A } },
+	{ .data = { 0x1C, 0x48 } },
+	{ .data = { 0x1D, 0x48 } },
+	{ .data = { 0x1E, 0x40 } },
+	{ .data = { 0x1F, 0x1F } },
+	{ .data = { 0x20, 0x1F } },
+	{ .data = { 0x21, 0x1F } },
+	{ .data = { 0x22, 0x1F } },
+	{ .data = { 0x23, 0x1F } },
+	{ .data = { 0x24, 0x1F } },
+	{ .data = { 0x25, 0x5F } },
+	{ .data = { 0x26, 0x5F } },
+	{ .data = { 0x27, 0x57 } },
+	{ .data = { 0x28, 0x77 } },
+	{ .data = { 0x29, 0x35 } },
+	{ .data = { 0x2A, 0x1F } },
+	{ .data = { 0x2B, 0x1F } },
+	{ .data = { 0x58, 0x40 } },
+	{ .data = { 0x59, 0x00 } },
+	{ .data = { 0x5A, 0x00 } },
+	{ .data = { 0x5B, 0x10 } },
+	{ .data = { 0x5C, 0x06 } },
+	{ .data = { 0x5D, 0x40 } },
+	{ .data = { 0x5E, 0x01 } },
+	{ .data = { 0x5F, 0x02 } },
+	{ .data = { 0x60, 0x30 } },
+	{ .data = { 0x61, 0x01 } },
+	{ .data = { 0x62, 0x02 } },
+	{ .data = { 0x63, 0x03 } },
+	{ .data = { 0x64, 0x6B } },
+	{ .data = { 0x65, 0x05 } },
+	{ .data = { 0x66, 0x0C } },
+	{ .data = { 0x67, 0x73 } },
+	{ .data = { 0x68, 0x09 } },
+	{ .data = { 0x69, 0x03 } },
+	{ .data = { 0x6A, 0x56 } },
+	{ .data = { 0x6B, 0x08 } },
+	{ .data = { 0x6C, 0x00 } },
+	{ .data = { 0x6D, 0x04 } },
+	{ .data = { 0x6E, 0x04 } },
+	{ .data = { 0x6F, 0x88 } },
+	{ .data = { 0x70, 0x00 } },
+	{ .data = { 0x71, 0x00 } },
+	{ .data = { 0x72, 0x06 } },
+	{ .data = { 0x73, 0x7B } },
+	{ .data = { 0x74, 0x00 } },
+	{ .data = { 0x75, 0xF8 } },
+	{ .data = { 0x76, 0x00 } },
+	{ .data = { 0x77, 0xD5 } },
+	{ .data = { 0x78, 0x2E } },
+	{ .data = { 0x79, 0x12 } },
+	{ .data = { 0x7A, 0x03 } },
+	{ .data = { 0x7B, 0x00 } },
+	{ .data = { 0x7C, 0x00 } },
+	{ .data = { 0x7D, 0x03 } },
+	{ .data = { 0x7E, 0x7B } },
+	{ .data = { 0xE0, 0x04 } },
+	{ .data = { 0x00, 0x0E } },
+	{ .data = { 0x02, 0xB3 } },
+	{ .data = { 0x09, 0x60 } },
+	{ .data = { 0x0E, 0x2A } },
+	{ .data = { 0x36, 0x59 } },
+	{ .data = { 0xE0, 0x00 } },
+};
+
+static const struct jadard_panel_desc radxa_display_8hd_ad002_desc = {
+	.mode = {
+		.clock		= 70000,
+
+		.hdisplay	= 800,
+		.hsync_start	= 800 + 40,
+		.hsync_end	= 800 + 40 + 18,
+		.htotal		= 800 + 40 + 18 + 20,
+
+		.vdisplay	= 1280,
+		.vsync_start	= 1280 + 20,
+		.vsync_end	= 1280 + 20 + 4,
+		.vtotal		= 1280 + 20 + 4 + 20,
+
+		.width_mm	= 127,
+		.height_mm	= 199,
+		.type		= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
+	},
+	.lanes = 4,
+	.format = MIPI_DSI_FMT_RGB888,
+	.init_cmds = radxa_display_8hd_ad002_init_cmds,
+	.num_init_cmds = ARRAY_SIZE(radxa_display_8hd_ad002_init_cmds),
+};
+
 static const struct jadard_init_cmd radxa_display_10hd_ad001_init_cmds[] = {
 	{ .data = { 0xE0, 0x00 } },
 	{ .data = { 0xE1, 0x93 } },
@@ -456,6 +652,10 @@ static const struct of_device_id jadard_of_match[] = {
 		.compatible = "radxa,display-10hd-ad001",
 		.data = &radxa_display_10hd_ad001_desc
 	},
+	{
+		.compatible = "radxa,display-8hd-ad002",
+		.data = &radxa_display_8hd_ad002_desc
+	},
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, jadard_of_match);
-- 
2.25.1

Re: [PATCH 1/4] drm: panel: jadard-jd9365da-h3: Fix panel vendor and model

[Krzysztof Kozlowski]

On 23/01/2023 17:40, Jagan Teki wrote:
> The initial datasheet claimed that chouzhong designed this 10"
> DSI panel on top of JD9365DA IC, but later Radxa mentioned that
> chouzhong is the manufacturer.
> 
> So the actual design of the panel, gsensor, and customized FPC
> is done by Radxa. The panel model named is Radxa Display 10HD
> with AD001 is the part number.
> 
> Fix the binding and panel driver with the proper panel vendor
> and model.
> 
> Fixes: <6b818c533dd8> ("drm: panel: Add Jadard JD9365DA-H3 DSI panel")
> Fixes: <bb3098eead99> ("dt-bindings: display: Document Jadard

Does not look like correct syntax. Did you run checkpatch?

> JD9365DA-H3 DSI panel")
> Reported-by: Tom Cubie <tom@radxa.com>
> Signed-off-by: Jagan Teki <jagan@edgeble.ai>
> ---
>  .../bindings/display/panel/jadard,jd9365da-h3.yaml  |  4 ++--
>  drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c    | 13 ++++++++-----

Bindings are always separate.

>  2 files changed, 10 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
> index c06902e4fe70..10ba1b813304 100644
> --- a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
> @@ -16,7 +16,7 @@ properties:
>    compatible:
>      items:
>        - enum:
> -          - chongzhou,cz101b4001
> +          - radxa,display-10hd-ad001
>        - const: jadard,jd9365da-h3
>  
>    reg: true
> @@ -52,7 +52,7 @@ examples:
>          #size-cells = <0>;
>  
>          panel@0 {
> -            compatible = "chongzhou,cz101b4001", "jadard,jd9365da-h3";
> +            compatible = "radxa,display-10hd-ad001", "jadard,jd9365da-h3";
>              reg = <0>;
>              vdd-supply = <&lcd_3v3>;
>              vccio-supply = <&vcca_1v8>;
> diff --git a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> index 48c1702a863b..ea89cecad0cf 100644
> --- a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> +++ b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> @@ -167,7 +167,7 @@ static const struct drm_panel_funcs jadard_funcs = {
>  	.get_modes = jadard_get_modes,
>  };
>  
> -static const struct jadard_init_cmd cz101b4001_init_cmds[] = {
> +static const struct jadard_init_cmd radxa_display_10hd_ad001_init_cmds[] = {
>  	{ .data = { 0xE0, 0x00 } },
>  	{ .data = { 0xE1, 0x93 } },
>  	{ .data = { 0xE2, 0x65 } },
> @@ -364,7 +364,7 @@ static const struct jadard_init_cmd cz101b4001_init_cmds[] = {
>  	{ .data = { 0xE7, 0x0C } },
>  };
>  
> -static const struct jadard_panel_desc cz101b4001_desc = {
> +static const struct jadard_panel_desc radxa_display_10hd_ad001_desc = {
>  	.mode = {
>  		.clock		= 70000,
>  
> @@ -384,8 +384,8 @@ static const struct jadard_panel_desc cz101b4001_desc = {
>  	},
>  	.lanes = 4,
>  	.format = MIPI_DSI_FMT_RGB888,
> -	.init_cmds = cz101b4001_init_cmds,
> -	.num_init_cmds = ARRAY_SIZE(cz101b4001_init_cmds),
> +	.init_cmds = radxa_display_10hd_ad001_init_cmds,
> +	.num_init_cmds = ARRAY_SIZE(radxa_display_10hd_ad001_init_cmds),
>  };
>  
>  static int jadard_dsi_probe(struct mipi_dsi_device *dsi)
> @@ -452,7 +452,10 @@ static void jadard_dsi_remove(struct mipi_dsi_device *dsi)
>  }
>  
>  static const struct of_device_id jadard_of_match[] = {
> -	{ .compatible = "chongzhou,cz101b4001", .data = &cz101b4001_desc },

This breaks ABI. When was support for it merged?

> +	{
> +		.compatible = "radxa,display-10hd-ad001",
> +		.data = &radxa_display_10hd_ad001_desc
> +	},
>  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, jadard_of_match);

Best regards,
Krzysztof

Re: [PATCH 1/4] drm: panel: jadard-jd9365da-h3: Fix panel vendor and model

[Jagan Teki]

On Mon, 23 Jan 2023 at 22:52, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 23/01/2023 17:40, Jagan Teki wrote:
> > The initial datasheet claimed that chouzhong designed this 10"
> > DSI panel on top of JD9365DA IC, but later Radxa mentioned that
> > chouzhong is the manufacturer.
> >
> > So the actual design of the panel, gsensor, and customized FPC
> > is done by Radxa. The panel model named is Radxa Display 10HD
> > with AD001 is the part number.
> >
> > Fix the binding and panel driver with the proper panel vendor
> > and model.
> >
> > Fixes: <6b818c533dd8> ("drm: panel: Add Jadard JD9365DA-H3 DSI panel")
> > Fixes: <bb3098eead99> ("dt-bindings: display: Document Jadard
>
> Does not look like correct syntax. Did you run checkpatch?

Yes. I did check with --strict as well.

>
> > JD9365DA-H3 DSI panel")
> > Reported-by: Tom Cubie <tom@radxa.com>
> > Signed-off-by: Jagan Teki <jagan@edgeble.ai>
> > ---
> >  .../bindings/display/panel/jadard,jd9365da-h3.yaml  |  4 ++--
> >  drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c    | 13 ++++++++-----
>
> Bindings are always separate.

Correct, but separation here triggers a warning for compatible not found.

>
> >  2 files changed, 10 insertions(+), 7 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
> > index c06902e4fe70..10ba1b813304 100644
> > --- a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
> > @@ -16,7 +16,7 @@ properties:
> >    compatible:
> >      items:
> >        - enum:
> > -          - chongzhou,cz101b4001
> > +          - radxa,display-10hd-ad001
> >        - const: jadard,jd9365da-h3
> >
> >    reg: true
> > @@ -52,7 +52,7 @@ examples:
> >          #size-cells = <0>;
> >
> >          panel@0 {
> > -            compatible = "chongzhou,cz101b4001", "jadard,jd9365da-h3";
> > +            compatible = "radxa,display-10hd-ad001", "jadard,jd9365da-h3";
> >              reg = <0>;
> >              vdd-supply = <&lcd_3v3>;
> >              vccio-supply = <&vcca_1v8>;
> > diff --git a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> > index 48c1702a863b..ea89cecad0cf 100644
> > --- a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> > +++ b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> > @@ -167,7 +167,7 @@ static const struct drm_panel_funcs jadard_funcs = {
> >       .get_modes = jadard_get_modes,
> >  };
> >
> > -static const struct jadard_init_cmd cz101b4001_init_cmds[] = {
> > +static const struct jadard_init_cmd radxa_display_10hd_ad001_init_cmds[] = {
> >       { .data = { 0xE0, 0x00 } },
> >       { .data = { 0xE1, 0x93 } },
> >       { .data = { 0xE2, 0x65 } },
> > @@ -364,7 +364,7 @@ static const struct jadard_init_cmd cz101b4001_init_cmds[] = {
> >       { .data = { 0xE7, 0x0C } },
> >  };
> >
> > -static const struct jadard_panel_desc cz101b4001_desc = {
> > +static const struct jadard_panel_desc radxa_display_10hd_ad001_desc = {
> >       .mode = {
> >               .clock          = 70000,
> >
> > @@ -384,8 +384,8 @@ static const struct jadard_panel_desc cz101b4001_desc = {
> >       },
> >       .lanes = 4,
> >       .format = MIPI_DSI_FMT_RGB888,
> > -     .init_cmds = cz101b4001_init_cmds,
> > -     .num_init_cmds = ARRAY_SIZE(cz101b4001_init_cmds),
> > +     .init_cmds = radxa_display_10hd_ad001_init_cmds,
> > +     .num_init_cmds = ARRAY_SIZE(radxa_display_10hd_ad001_init_cmds),
> >  };
> >
> >  static int jadard_dsi_probe(struct mipi_dsi_device *dsi)
> > @@ -452,7 +452,10 @@ static void jadard_dsi_remove(struct mipi_dsi_device *dsi)
> >  }
> >
> >  static const struct of_device_id jadard_of_match[] = {
> > -     { .compatible = "chongzhou,cz101b4001", .data = &cz101b4001_desc },
>
> This breaks ABI. When was support for it merged?

It was merged last year, in September

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=6b818c533dd8615a803a72733eace58fd06e5a3c

Jagan.

Re: [PATCH 1/4] drm: panel: jadard-jd9365da-h3: Fix panel vendor and model

[Krzysztof Kozlowski]

On 23/01/2023 18:45, Jagan Teki wrote:
> On Mon, 23 Jan 2023 at 22:52, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 23/01/2023 17:40, Jagan Teki wrote:
>>> The initial datasheet claimed that chouzhong designed this 10"
>>> DSI panel on top of JD9365DA IC, but later Radxa mentioned that
>>> chouzhong is the manufacturer.
>>>
>>> So the actual design of the panel, gsensor, and customized FPC
>>> is done by Radxa. The panel model named is Radxa Display 10HD
>>> with AD001 is the part number.
>>>
>>> Fix the binding and panel driver with the proper panel vendor
>>> and model.
>>>
>>> Fixes: <6b818c533dd8> ("drm: panel: Add Jadard JD9365DA-H3 DSI panel")
>>> Fixes: <bb3098eead99> ("dt-bindings: display: Document Jadard
>>
>> Does not look like correct syntax. Did you run checkpatch?
> 
> Yes. I did check with --strict as well.

Anyway, it's not correct. <> are not valid and commit msg should not be
wrapped.

> 
>>
>>> JD9365DA-H3 DSI panel")
>>> Reported-by: Tom Cubie <tom@radxa.com>
>>> Signed-off-by: Jagan Teki <jagan@edgeble.ai>
>>> ---
>>>  .../bindings/display/panel/jadard,jd9365da-h3.yaml  |  4 ++--
>>>  drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c    | 13 ++++++++-----
>>
>> Bindings are always separate.
> 
> Correct, but separation here triggers a warning for compatible not found.

Which should point you to the problem - you cannot remove compatibles...

> 
>>
>>>  2 files changed, 10 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
>>> index c06902e4fe70..10ba1b813304 100644
>>> --- a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
>>> +++ b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
>>> @@ -16,7 +16,7 @@ properties:
>>>    compatible:
>>>      items:
>>>        - enum:
>>> -          - chongzhou,cz101b4001
>>> +          - radxa,display-10hd-ad001
>>>        - const: jadard,jd9365da-h3
>>>
>>>    reg: true
>>> @@ -52,7 +52,7 @@ examples:
>>>          #size-cells = <0>;
>>>
>>>          panel@0 {
>>> -            compatible = "chongzhou,cz101b4001", "jadard,jd9365da-h3";
>>> +            compatible = "radxa,display-10hd-ad001", "jadard,jd9365da-h3";
>>>              reg = <0>;
>>>              vdd-supply = <&lcd_3v3>;
>>>              vccio-supply = <&vcca_1v8>;
>>> diff --git a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
>>> index 48c1702a863b..ea89cecad0cf 100644
>>> --- a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
>>> +++ b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
>>> @@ -167,7 +167,7 @@ static const struct drm_panel_funcs jadard_funcs = {
>>>       .get_modes = jadard_get_modes,
>>>  };
>>>
>>> -static const struct jadard_init_cmd cz101b4001_init_cmds[] = {
>>> +static const struct jadard_init_cmd radxa_display_10hd_ad001_init_cmds[] = {
>>>       { .data = { 0xE0, 0x00 } },
>>>       { .data = { 0xE1, 0x93 } },
>>>       { .data = { 0xE2, 0x65 } },
>>> @@ -364,7 +364,7 @@ static const struct jadard_init_cmd cz101b4001_init_cmds[] = {
>>>       { .data = { 0xE7, 0x0C } },
>>>  };
>>>
>>> -static const struct jadard_panel_desc cz101b4001_desc = {
>>> +static const struct jadard_panel_desc radxa_display_10hd_ad001_desc = {
>>>       .mode = {
>>>               .clock          = 70000,
>>>
>>> @@ -384,8 +384,8 @@ static const struct jadard_panel_desc cz101b4001_desc = {
>>>       },
>>>       .lanes = 4,
>>>       .format = MIPI_DSI_FMT_RGB888,
>>> -     .init_cmds = cz101b4001_init_cmds,
>>> -     .num_init_cmds = ARRAY_SIZE(cz101b4001_init_cmds),
>>> +     .init_cmds = radxa_display_10hd_ad001_init_cmds,
>>> +     .num_init_cmds = ARRAY_SIZE(radxa_display_10hd_ad001_init_cmds),
>>>  };
>>>
>>>  static int jadard_dsi_probe(struct mipi_dsi_device *dsi)
>>> @@ -452,7 +452,10 @@ static void jadard_dsi_remove(struct mipi_dsi_device *dsi)
>>>  }
>>>
>>>  static const struct of_device_id jadard_of_match[] = {
>>> -     { .compatible = "chongzhou,cz101b4001", .data = &cz101b4001_desc },
>>
>> This breaks ABI. When was support for it merged?
> 
> It was merged last year, in September
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=6b818c533dd8615a803a72733eace58fd06e5a3c

So you cannot remove it.

Best regards,
Krzysztof