From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85C9022301; Sat, 7 Feb 2026 10:49:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770461363; cv=none; b=eaz0HfHhMoM8hHR5NpPzjazmglIMuH5/SHttdto/UcV7mb+zJZyYA2Oq92EsdzyuIIrZf1BC96YnZ5oinLG5hP6p5/iaROFdw1wTbD9DQ/5pzQjXGCGuoYaztaEJGV0KCbrY5OBWRG0N31s1bD4R1ywSktRHfWTxVmt5Dyxh1l4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770461363; c=relaxed/simple; bh=vR/diDxqa1OFN1W0xmqG5HflpJfwRP+WkZ+7TLOMKGM=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=EO8vN1BXnKXrkb6meWbAjn30INDHybXBkJaqA/g+Oo2MJDbT/CpUO8xCeJZfO724RtI5IWcTvQurphIFCG0KNlkn7RKrLYhlY+kxoJr+s9Ot8/vGVgtIa9ciWm4bs/HfOa+osIPb+OYmDK9LrxTYhAbfTS5qm+4T+me4hYe5j2s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=o/AmsU2P; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="o/AmsU2P" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F20C7C116D0; Sat, 7 Feb 2026 10:49:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770461363; bh=vR/diDxqa1OFN1W0xmqG5HflpJfwRP+WkZ+7TLOMKGM=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=o/AmsU2Parvgl6nqB3SiA0GGC4av+vWpc3R+nvqMn8KlDtUges2+5IJ25ViRmAA3g dH8YQc4RXIeKoLjoCual9KA9bfKbEgNmRBwOpS+BKE7fL2jHsjfmg3VAaYQQvEs/UL fhpnudCcRIYjeriweBngewAgKFm6JUeIgSOV/rBlk8vWuZILpIZRHlO3jykX487Cq0 ATohj0PWTg9lhcDF/xLcA8W/JtFkUjCwcn9UgVTAYqo0q6hAaa8fRy58uY5wNugn/1 4hibOyUS+MD3NfB6BM2fE0BmjW5UpFutqlrZ61QfIG8JfhZHju5m0tPgax4fP8t/Hc oYzXFw8gqPrVQ== Message-ID: <89882b75-dc80-479b-b2b2-199bebe4ecc3@kernel.org> Date: Sat, 7 Feb 2026 11:49:17 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: phy: spacemit: add regulator support to K1 USB2 PHY From: Krzysztof Kozlowski To: Chukun Pan Cc: Yixun Lan , Vinod Koul , Ze Huang , Rob Herring , Mark Brown , Conor Dooley , Liam Girdwood , Krzysztof Kozlowski , Neil Armstrong , linux-riscv@lists.infradead.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, spacemit@lists.linux.dev References: <20260206100009.873182-1-amadeus@jmu.edu.cn> <20260207-dancing-finch-of-chemistry-f98cf2@quoll> Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20260207-dancing-finch-of-chemistry-f98cf2@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 07/02/2026 11:48, Krzysztof Kozlowski wrote: > On Fri, Feb 06, 2026 at 06:00:08PM +0800, Chukun Pan wrote: >> Add an optional phy-supply property to describe the regulator >> supplying for USB VBUS. > > Why wasn't it there before? USB did not have VBUS? > > Explanation is so incomplete I suspect you are patching broken things, > so as well this could be completely different hardware (e.g. there is no > regulator for this block but e.g. connector). > > >> >> Signed-off-by: Chukun Pan >> --- >> Documentation/devicetree/bindings/phy/spacemit,usb2-phy.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/phy/spacemit,usb2-phy.yaml b/Documentation/devicetree/bindings/phy/spacemit,usb2-phy.yaml >> index 43eaca90d88c..74a1cd5bcdbe 100644 >> --- a/Documentation/devicetree/bindings/phy/spacemit,usb2-phy.yaml >> +++ b/Documentation/devicetree/bindings/phy/spacemit,usb2-phy.yaml >> @@ -19,6 +19,10 @@ properties: >> clocks: >> maxItems: 1 >> >> + phy-supply: >> + description: >> + Phandle to a regulator that provides power to VBUS. > > Drop redundant part. This cannot be anything else than phandle and > regulator. > > "VBUS power supply" for example. But anyway, I don't have certainty that > this is correct hardware representation. It's your task to provide that. Plus, if this was a vbus regulator it would not be called "phy"... Even more confusing. Best regards, Krzysztof