[PATCH] ARM: dts: Drop bogus CLKSEL for timer12 on dra7

[PATCH] ARM: dts: Drop bogus CLKSEL for timer12 on dra7

[Tony Lindgren]

There is no CLKSEL for timer12 on dra6 unlike for timer1. This
causes issues on booting the device that Tomi noticed if
DEBUG_SLAB is enabled and the clkctrl clock does not properly
handle non-existing clock. Let's drop the bogus CLKSEL clock,
the clkctrl clock handling gets fixed separately.

Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reported-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Fixes: 4ed0dfe3cf39 ("ARM: dts: dra7: Move l4 child devices to probe them with ti-sysc")
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/boot/dts/dra7-l4.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/boot/dts/dra7-l4.dtsi b/arch/arm/boot/dts/dra7-l4.dtsi
--- a/arch/arm/boot/dts/dra7-l4.dtsi
+++ b/arch/arm/boot/dts/dra7-l4.dtsi
@@ -4450,8 +4450,6 @@
 			timer12: timer@0 {
 				compatible = "ti,omap5430-timer";
 				reg = <0x0 0x80>;
-				clocks = <&wkupaon_clkctrl DRA7_WKUPAON_TIMER12_CLKCTRL 24>;
-				clock-names = "fck";
 				interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
 				ti,timer-alwon;
 				ti,timer-secure;
-- 
2.21.0

Re: [PATCH] ARM: dts: Drop bogus CLKSEL for timer12 on dra7

[Tomi Valkeinen]

On 30/05/2019 09:56, Tony Lindgren wrote:
> There is no CLKSEL for timer12 on dra6 unlike for timer1. This

dra7

> causes issues on booting the device that Tomi noticed if
> DEBUG_SLAB is enabled and the clkctrl clock does not properly
> handle non-existing clock. Let's drop the bogus CLKSEL clock,
> the clkctrl clock handling gets fixed separately.
> 
> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Cc: Tero Kristo <t-kristo@ti.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Reported-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Fixes: 4ed0dfe3cf39 ("ARM: dts: dra7: Move l4 child devices to probe them with ti-sysc")
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
>   arch/arm/boot/dts/dra7-l4.dtsi | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/dra7-l4.dtsi b/arch/arm/boot/dts/dra7-l4.dtsi
> --- a/arch/arm/boot/dts/dra7-l4.dtsi
> +++ b/arch/arm/boot/dts/dra7-l4.dtsi
> @@ -4450,8 +4450,6 @@
>   			timer12: timer@0 {
>   				compatible = "ti,omap5430-timer";
>   				reg = <0x0 0x80>;
> -				clocks = <&wkupaon_clkctrl DRA7_WKUPAON_TIMER12_CLKCTRL 24>;
> -				clock-names = "fck";
>   				interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
>   				ti,timer-alwon;
>   				ti,timer-secure;
> 

Tested-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Re: [PATCH] ARM: dts: Drop bogus CLKSEL for timer12 on dra7

[Peter Ujfalusi]

On 30/05/2019 9.56, Tony Lindgren wrote:
> There is no CLKSEL for timer12 on dra6 unlike for timer1. This
> causes issues on booting the device that Tomi noticed if
> DEBUG_SLAB is enabled and the clkctrl clock does not properly
> handle non-existing clock. Let's drop the bogus CLKSEL clock,
> the clkctrl clock handling gets fixed separately.

Tested-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Cc: Tero Kristo <t-kristo@ti.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Reported-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Fixes: 4ed0dfe3cf39 ("ARM: dts: dra7: Move l4 child devices to probe them with ti-sysc")
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
>  arch/arm/boot/dts/dra7-l4.dtsi | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/dra7-l4.dtsi b/arch/arm/boot/dts/dra7-l4.dtsi
> --- a/arch/arm/boot/dts/dra7-l4.dtsi
> +++ b/arch/arm/boot/dts/dra7-l4.dtsi
> @@ -4450,8 +4450,6 @@
>  			timer12: timer@0 {
>  				compatible = "ti,omap5430-timer";
>  				reg = <0x0 0x80>;
> -				clocks = <&wkupaon_clkctrl DRA7_WKUPAON_TIMER12_CLKCTRL 24>;
> -				clock-names = "fck";
>  				interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
>  				ti,timer-alwon;
>  				ti,timer-secure;
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Re: [PATCH] ARM: dts: Drop bogus CLKSEL for timer12 on dra7

[Tony Lindgren]

* Tomi Valkeinen <tomi.valkeinen@ti.com> [190531 12:06]:
> On 30/05/2019 09:56, Tony Lindgren wrote:
> > There is no CLKSEL for timer12 on dra6 unlike for timer1. This
> 
> dra7

Thanks for spotting the typo, pushed out now and will send
a pull request for the dra7 fixes probably on Wednesday.

Regards,

Tony