* [PATCH 1/8] ASoC: dt-bindings: realtek,rt5682s: Add AVDD and MICVDD supplies
2022-10-28 20:55 [PATCH 0/8] Adjust usage of rt5682(s) power supply properties Nícolas F. R. A. Prado
@ 2022-10-28 20:55 ` Nícolas F. R. A. Prado
2022-10-31 12:53 ` AngeloGioacchino Del Regno
2022-10-28 20:55 ` [PATCH 2/8] ASoC: dt-bindings: realtek,rt5682s: Add dbvdd and ldo1-in supplies Nícolas F. R. A. Prado
` (4 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-10-28 20:55 UTC (permalink / raw)
To: Mark Brown, Bjorn Andersson
Cc: kernel, AngeloGioacchino Del Regno, Nícolas F. R. A. Prado,
Derek Fang, Krzysztof Kozlowski, Liam Girdwood, Rob Herring,
alsa-devel, devicetree, linux-kernel
The rt5682s codec has two supplies - AVDD and MICVDD - which are already
used by sc7180-trogdor-kingoftown.dtsi. Document them in the binding.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
Commit adapted from [1], changes:
- Made supplies required
- Added description for supplies
[1] https://lore.kernel.org/all/20221024220015.1759428-3-nfraprado@collabora.com
.../devicetree/bindings/sound/realtek,rt5682s.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
index 1c0b06d82369..b7338bfc0f5a 100644
--- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
+++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
@@ -90,11 +90,20 @@ properties:
"#sound-dai-cells":
const: 1
+ AVDD-supply:
+ description: Regulator supplying analog power through the AVDD pin.
+
+ MICVDD-supply:
+ description: Regulator supplying power for the microphone bias through the
+ MICVDD pin.
+
additionalProperties: false
required:
- compatible
- reg
+ - AVDD-supply
+ - MICVDD-supply
examples:
- |
@@ -120,5 +129,8 @@ examples:
clocks = <&osc>;
clock-names = "mclk";
+
+ AVDD-supply = <&avdd_reg>;
+ MICVDD-supply = <&micvdd_reg>;
};
};
--
2.38.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 1/8] ASoC: dt-bindings: realtek,rt5682s: Add AVDD and MICVDD supplies
2022-10-28 20:55 ` [PATCH 1/8] ASoC: dt-bindings: realtek,rt5682s: Add AVDD and MICVDD supplies Nícolas F. R. A. Prado
@ 2022-10-31 12:53 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 13+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-10-31 12:53 UTC (permalink / raw)
To: Nícolas F. R. A. Prado, Mark Brown, Bjorn Andersson
Cc: kernel, Derek Fang, Krzysztof Kozlowski, Liam Girdwood,
Rob Herring, alsa-devel, devicetree, linux-kernel
Il 28/10/22 22:55, Nícolas F. R. A. Prado ha scritto:
> The rt5682s codec has two supplies - AVDD and MICVDD - which are already
> used by sc7180-trogdor-kingoftown.dtsi. Document them in the binding.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 2/8] ASoC: dt-bindings: realtek,rt5682s: Add dbvdd and ldo1-in supplies
2022-10-28 20:55 [PATCH 0/8] Adjust usage of rt5682(s) power supply properties Nícolas F. R. A. Prado
2022-10-28 20:55 ` [PATCH 1/8] ASoC: dt-bindings: realtek,rt5682s: Add AVDD and MICVDD supplies Nícolas F. R. A. Prado
@ 2022-10-28 20:55 ` Nícolas F. R. A. Prado
2022-10-31 12:53 ` AngeloGioacchino Del Regno
2022-11-03 22:26 ` Krzysztof Kozlowski
2022-10-28 20:55 ` [PATCH 3/8] ASoC: dt-bindings: rt5682: Add AVDD, MICVDD and VBAT supplies Nícolas F. R. A. Prado
` (3 subsequent siblings)
5 siblings, 2 replies; 13+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-10-28 20:55 UTC (permalink / raw)
To: Mark Brown, Bjorn Andersson
Cc: kernel, AngeloGioacchino Del Regno, Nícolas F. R. A. Prado,
Derek Fang, Krzysztof Kozlowski, Liam Girdwood, Rob Herring,
alsa-devel, devicetree, linux-kernel
The rt5682s codec has two additional power supply pins, DBVDD and
LDO1_IN, that aren't currently described in the binding. Add them.
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
.../devicetree/bindings/sound/realtek,rt5682s.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
index b7338bfc0f5a..5b2bbf6f9156 100644
--- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
+++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
@@ -97,6 +97,13 @@ properties:
description: Regulator supplying power for the microphone bias through the
MICVDD pin.
+ dbvdd-supply:
+ description: Regulator supplying I/O power through the DBVDD pin.
+
+ ldo1-in-supply:
+ description: Regulator supplying power to the digital core and charge pump
+ through the LDO1_IN pin.
+
additionalProperties: false
required:
@@ -104,6 +111,8 @@ required:
- reg
- AVDD-supply
- MICVDD-supply
+ - dbvdd-supply
+ - ldo1-in-supply
examples:
- |
@@ -132,5 +141,7 @@ examples:
AVDD-supply = <&avdd_reg>;
MICVDD-supply = <&micvdd_reg>;
+ dbvdd-supply = <&dbvdd_reg>;
+ ldo1-in-supply = <&ldo1_in_reg>;
};
};
--
2.38.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 2/8] ASoC: dt-bindings: realtek,rt5682s: Add dbvdd and ldo1-in supplies
2022-10-28 20:55 ` [PATCH 2/8] ASoC: dt-bindings: realtek,rt5682s: Add dbvdd and ldo1-in supplies Nícolas F. R. A. Prado
@ 2022-10-31 12:53 ` AngeloGioacchino Del Regno
2022-11-03 22:26 ` Krzysztof Kozlowski
1 sibling, 0 replies; 13+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-10-31 12:53 UTC (permalink / raw)
To: Nícolas F. R. A. Prado, Mark Brown, Bjorn Andersson
Cc: kernel, Derek Fang, Krzysztof Kozlowski, Liam Girdwood,
Rob Herring, alsa-devel, devicetree, linux-kernel
Il 28/10/22 22:55, Nícolas F. R. A. Prado ha scritto:
> The rt5682s codec has two additional power supply pins, DBVDD and
> LDO1_IN, that aren't currently described in the binding. Add them.
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/8] ASoC: dt-bindings: realtek,rt5682s: Add dbvdd and ldo1-in supplies
2022-10-28 20:55 ` [PATCH 2/8] ASoC: dt-bindings: realtek,rt5682s: Add dbvdd and ldo1-in supplies Nícolas F. R. A. Prado
2022-10-31 12:53 ` AngeloGioacchino Del Regno
@ 2022-11-03 22:26 ` Krzysztof Kozlowski
1 sibling, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-03 22:26 UTC (permalink / raw)
To: Nícolas F. R. A. Prado, Mark Brown, Bjorn Andersson
Cc: kernel, AngeloGioacchino Del Regno, Derek Fang,
Krzysztof Kozlowski, Liam Girdwood, Rob Herring, alsa-devel,
devicetree, linux-kernel
On 28/10/2022 16:55, Nícolas F. R. A. Prado wrote:
> The rt5682s codec has two additional power supply pins, DBVDD and
> LDO1_IN, that aren't currently described in the binding. Add them.
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 3/8] ASoC: dt-bindings: rt5682: Add AVDD, MICVDD and VBAT supplies
2022-10-28 20:55 [PATCH 0/8] Adjust usage of rt5682(s) power supply properties Nícolas F. R. A. Prado
2022-10-28 20:55 ` [PATCH 1/8] ASoC: dt-bindings: realtek,rt5682s: Add AVDD and MICVDD supplies Nícolas F. R. A. Prado
2022-10-28 20:55 ` [PATCH 2/8] ASoC: dt-bindings: realtek,rt5682s: Add dbvdd and ldo1-in supplies Nícolas F. R. A. Prado
@ 2022-10-28 20:55 ` Nícolas F. R. A. Prado
2022-10-28 20:55 ` [PATCH 4/8] ASoC: dt-bindings: rt5682: Add dbvdd and ldo1-in supplies Nícolas F. R. A. Prado
` (2 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-10-28 20:55 UTC (permalink / raw)
To: Mark Brown, Bjorn Andersson
Cc: kernel, AngeloGioacchino Del Regno, Nícolas F. R. A. Prado,
Krzysztof Kozlowski, Liam Girdwood, Rob Herring, alsa-devel,
devicetree, linux-kernel
The rt5682 codec has three supplies - AVDD, MICVDD and VBAT - which are
already used by sc7180-trogdor.dtsi. Document them in the binding.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
Commit adapted from [1], changes:
- Made supplies required
- Improved supplies descriptions
[1] https://lore.kernel.org/all/20221024220015.1759428-5-nfraprado@collabora.com
Documentation/devicetree/bindings/sound/rt5682.txt | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt
index 6b87db68337c..89e6245b870e 100644
--- a/Documentation/devicetree/bindings/sound/rt5682.txt
+++ b/Documentation/devicetree/bindings/sound/rt5682.txt
@@ -8,6 +8,15 @@ Required properties:
- reg : The I2C address of the device.
+- AVDD-supply: phandle to the regulator supplying analog power through the
+ AVDD pin
+
+- MICVDD-supply: phandle to the regulator supplying power for the microphone
+ bias through the MICVDD pin. Either MICVDD or VBAT should be present.
+
+- VBAT-supply: phandle to the regulator supplying battery power through the
+ VBAT pin. Either MICVDD or VBAT should be present.
+
Optional properties:
- interrupts : The CODEC's interrupt output.
@@ -75,4 +84,7 @@ rt5682 {
clocks = <&osc>;
clock-names = "mclk";
+
+ AVDD-supply = <&avdd_reg>;
+ MICVDD-supply = <&micvdd_reg>;
};
--
2.38.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 4/8] ASoC: dt-bindings: rt5682: Add dbvdd and ldo1-in supplies
2022-10-28 20:55 [PATCH 0/8] Adjust usage of rt5682(s) power supply properties Nícolas F. R. A. Prado
` (2 preceding siblings ...)
2022-10-28 20:55 ` [PATCH 3/8] ASoC: dt-bindings: rt5682: Add AVDD, MICVDD and VBAT supplies Nícolas F. R. A. Prado
@ 2022-10-28 20:55 ` Nícolas F. R. A. Prado
2022-11-03 22:26 ` Krzysztof Kozlowski
2022-10-28 20:55 ` [PATCH 7/8] arm64: dts: qcom: sc7180-trogdor: Add missing supplies for rt5682 Nícolas F. R. A. Prado
2022-10-28 20:55 ` [PATCH 8/8] arm64: dts: qcom: sc7180-trogdor: Remove VBAT supply from rt5682s Nícolas F. R. A. Prado
5 siblings, 1 reply; 13+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-10-28 20:55 UTC (permalink / raw)
To: Mark Brown, Bjorn Andersson
Cc: kernel, AngeloGioacchino Del Regno, Nícolas F. R. A. Prado,
Krzysztof Kozlowski, Liam Girdwood, Rob Herring, alsa-devel,
devicetree, linux-kernel
The rt5682 codec has two additional power supply pins, DBVDD and
LDO1_IN, that aren't currently described in the binding. Add them.
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
Documentation/devicetree/bindings/sound/rt5682.txt | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt
index 89e6245b870e..948109ff0db3 100644
--- a/Documentation/devicetree/bindings/sound/rt5682.txt
+++ b/Documentation/devicetree/bindings/sound/rt5682.txt
@@ -17,6 +17,12 @@ Required properties:
- VBAT-supply: phandle to the regulator supplying battery power through the
VBAT pin. Either MICVDD or VBAT should be present.
+- dbvdd-supply: phandle to the regulator supplying I/O power through the DBVDD
+ pin.
+
+- ldo1-in-supply: phandle to the regulator supplying power to the digital core
+ and charge pump through the LDO1_IN pin.
+
Optional properties:
- interrupts : The CODEC's interrupt output.
@@ -87,4 +93,6 @@ rt5682 {
AVDD-supply = <&avdd_reg>;
MICVDD-supply = <&micvdd_reg>;
+ dbvdd-supply = <&dbvdd_reg>;
+ ldo1-in-supply = <&ldo1_in_reg>;
};
--
2.38.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 4/8] ASoC: dt-bindings: rt5682: Add dbvdd and ldo1-in supplies
2022-10-28 20:55 ` [PATCH 4/8] ASoC: dt-bindings: rt5682: Add dbvdd and ldo1-in supplies Nícolas F. R. A. Prado
@ 2022-11-03 22:26 ` Krzysztof Kozlowski
0 siblings, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-03 22:26 UTC (permalink / raw)
To: Nícolas F. R. A. Prado, Mark Brown, Bjorn Andersson
Cc: kernel, AngeloGioacchino Del Regno, Krzysztof Kozlowski,
Liam Girdwood, Rob Herring, alsa-devel, devicetree, linux-kernel
On 28/10/2022 16:55, Nícolas F. R. A. Prado wrote:
> The rt5682 codec has two additional power supply pins, DBVDD and
> LDO1_IN, that aren't currently described in the binding. Add them.
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 7/8] arm64: dts: qcom: sc7180-trogdor: Add missing supplies for rt5682
2022-10-28 20:55 [PATCH 0/8] Adjust usage of rt5682(s) power supply properties Nícolas F. R. A. Prado
` (3 preceding siblings ...)
2022-10-28 20:55 ` [PATCH 4/8] ASoC: dt-bindings: rt5682: Add dbvdd and ldo1-in supplies Nícolas F. R. A. Prado
@ 2022-10-28 20:55 ` Nícolas F. R. A. Prado
2022-10-31 12:54 ` AngeloGioacchino Del Regno
2022-10-28 20:55 ` [PATCH 8/8] arm64: dts: qcom: sc7180-trogdor: Remove VBAT supply from rt5682s Nícolas F. R. A. Prado
5 siblings, 1 reply; 13+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-10-28 20:55 UTC (permalink / raw)
To: Mark Brown, Bjorn Andersson
Cc: kernel, AngeloGioacchino Del Regno, Nícolas F. R. A. Prado,
Andy Gross, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring,
devicetree, linux-arm-msm, linux-kernel
The dbvdd and ldo1-in supplies for rt5682 are required but are missing.
They are supplied by the same power rail as AVDD. Add them.
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 1a1c346d619c..1df507ffb267 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -768,6 +768,8 @@ alc5682: codec@1a {
interrupts = <28 IRQ_TYPE_EDGE_BOTH>;
AVDD-supply = <&pp1800_alc5682>;
+ dbvdd-supply = <&pp1800_alc5682>;
+ ldo1-in-supply = <&pp1800_alc5682>;
MICVDD-supply = <&pp3300_codec>;
VBAT-supply = <&pp3300_audio>;
--
2.38.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 7/8] arm64: dts: qcom: sc7180-trogdor: Add missing supplies for rt5682
2022-10-28 20:55 ` [PATCH 7/8] arm64: dts: qcom: sc7180-trogdor: Add missing supplies for rt5682 Nícolas F. R. A. Prado
@ 2022-10-31 12:54 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 13+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-10-31 12:54 UTC (permalink / raw)
To: Nícolas F. R. A. Prado, Mark Brown, Bjorn Andersson
Cc: kernel, Andy Gross, Konrad Dybcio, Krzysztof Kozlowski,
Rob Herring, devicetree, linux-arm-msm, linux-kernel
Il 28/10/22 22:55, Nícolas F. R. A. Prado ha scritto:
> The dbvdd and ldo1-in supplies for rt5682 are required but are missing.
> They are supplied by the same power rail as AVDD. Add them.
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 8/8] arm64: dts: qcom: sc7180-trogdor: Remove VBAT supply from rt5682s
2022-10-28 20:55 [PATCH 0/8] Adjust usage of rt5682(s) power supply properties Nícolas F. R. A. Prado
` (4 preceding siblings ...)
2022-10-28 20:55 ` [PATCH 7/8] arm64: dts: qcom: sc7180-trogdor: Add missing supplies for rt5682 Nícolas F. R. A. Prado
@ 2022-10-28 20:55 ` Nícolas F. R. A. Prado
2022-10-31 12:56 ` AngeloGioacchino Del Regno
5 siblings, 1 reply; 13+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-10-28 20:55 UTC (permalink / raw)
To: Mark Brown, Bjorn Andersson
Cc: kernel, AngeloGioacchino Del Regno, Nícolas F. R. A. Prado,
Andy Gross, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring,
devicetree, linux-arm-msm, linux-kernel
These devicetrees override a rt5682 node to use the rt5682s compatible,
however, unlike rt5682, rt5682s doesn't have a VBAT supply. Remove the
inexistent supply in the rt5682s nodes.
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi | 1 +
.../dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dts | 1 +
.../dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dts | 1 +
3 files changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi
index 74f0e07ea5cf..e0fb83a9a0b1 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi
@@ -11,6 +11,7 @@
&alc5682 {
compatible = "realtek,rt5682s";
+ /delete-property/ VBAT-supply;
realtek,dmic1-clk-pin = <2>;
realtek,dmic-clk-rate-hz = <2048000>;
};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dts
index aa605885c371..6225ab8329c3 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dts
@@ -19,6 +19,7 @@ / {
&alc5682 {
compatible = "realtek,rt5682s";
+ /delete-property/ VBAT-supply;
realtek,dmic1-clk-pin = <2>;
realtek,dmic-clk-rate-hz = <2048000>;
};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dts
index 7116c44c8d85..b40b068dad6a 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dts
@@ -19,6 +19,7 @@ / {
&alc5682 {
compatible = "realtek,rt5682s";
+ /delete-property/ VBAT-supply;
realtek,dmic1-clk-pin = <2>;
realtek,dmic-clk-rate-hz = <2048000>;
};
--
2.38.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 8/8] arm64: dts: qcom: sc7180-trogdor: Remove VBAT supply from rt5682s
2022-10-28 20:55 ` [PATCH 8/8] arm64: dts: qcom: sc7180-trogdor: Remove VBAT supply from rt5682s Nícolas F. R. A. Prado
@ 2022-10-31 12:56 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 13+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-10-31 12:56 UTC (permalink / raw)
To: Nícolas F. R. A. Prado, Mark Brown, Bjorn Andersson
Cc: kernel, Andy Gross, Konrad Dybcio, Krzysztof Kozlowski,
Rob Herring, devicetree, linux-arm-msm, linux-kernel
Il 28/10/22 22:55, Nícolas F. R. A. Prado ha scritto:
> These devicetrees override a rt5682 node to use the rt5682s compatible,
> however, unlike rt5682, rt5682s doesn't have a VBAT supply. Remove the
> inexistent supply in the rt5682s nodes.
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> ---
>
> arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi | 1 +
> .../dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dts | 1 +
> .../dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dts | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi
> index 74f0e07ea5cf..e0fb83a9a0b1 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi
> @@ -11,6 +11,7 @@
>
> &alc5682 {
> compatible = "realtek,rt5682s";
> + /delete-property/ VBAT-supply;
I really dislike seeing /delete-property/ but I don't know if changing all of the
non-kingoftown and non-wormdingler devicetrees is worth the noise...
Any strong opinions on that?
Regards,
Angelo
^ permalink raw reply [flat|nested] 13+ messages in thread