From: Iskren Chernev <iskren.chernev@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/14] dt-bindings: ufs: qcom: Add sm6115 binding
Date: Sat, 3 Sep 2022 19:54:01 +0300 [thread overview]
Message-ID: <89e6a200-d9af-7263-5e09-d7d824277a30@gmail.com> (raw)
In-Reply-To: <7804ffbe-4e27-d8bd-dbe2-75d1323da064@linaro.org>
On 9/1/22 19:11, Krzysztof Kozlowski wrote:
> On 01/09/2022 10:24, Iskren Chernev wrote:
>> Add SM6115 UFS to DT schema.
>>
>> Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com>
>> ---
>> .../devicetree/bindings/ufs/qcom,ufs.yaml | 26 +++++++++++++++++++
>> 1 file changed, 26 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> index f2d6298d926c..7c5f6e2e6d4c 100644
>> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> @@ -28,6 +28,7 @@ properties:
>> - qcom,msm8998-ufshc
>> - qcom,sc8280xp-ufshc
>> - qcom,sdm845-ufshc
>> + - qcom,sm6115-ufshc
>> - qcom,sm6350-ufshc
>> - qcom,sm8150-ufshc
>> - qcom,sm8250-ufshc
>> @@ -178,6 +179,31 @@ allOf:
>> minItems: 1
>> maxItems: 1
>>
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - qcom,sm6115-ufshc
>> + then:
>> + properties:
>> + clocks:
>> + minItems: 8
>> + maxItems: 8
>> + clock-names:
>> + items:
>> + - const: core_clk
>> + - const: bus_aggr_clk
>> + - const: iface_clk
>> + - const: core_clk_unipro
>> + - const: core_clk_ice
>
> Use existing name and put it in the same place as existing variant - sdm845:
> ice_core_clk
The only problem with sdm845 bindings is the presence of rx_lane1_sync_clk
clock. I'm guessing I could pass zeros there, because it shouldn't be used. Or
it could be moved to last property and then min/maxItems to guard, but that is
a change to something more-or-less immutable.
> Best regards,
> Krzysztof
Regards,
Iskren
next prev parent reply other threads:[~2022-09-03 16:54 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 7:23 [PATCH 00/14] Add support for sm6115,4250 and OnePlus Nord N100 Iskren Chernev
2022-09-01 7:24 ` [PATCH 01/14] arm64: dts: qcom: sm6115: Add basic soc dtsi Iskren Chernev
2022-09-01 16:03 ` Krzysztof Kozlowski
2022-09-01 7:24 ` [PATCH 02/14] arm64: dts: qcom: sm6115: Add rpmcc and rpmpd nodes Iskren Chernev
2022-09-01 7:24 ` [PATCH 03/14] arm64: dts: qcom: sm6115: Add GCC node Iskren Chernev
2022-09-01 16:05 ` Krzysztof Kozlowski
2022-09-01 7:24 ` [PATCH 04/14] arm64: dts: qcom: sm6115: Add pinctrl node Iskren Chernev
2022-09-01 7:24 ` [PATCH 05/14] arm64: dts: qcom: sm6115: Add apps smmu node Iskren Chernev
2022-09-01 16:05 ` Krzysztof Kozlowski
2022-09-01 7:24 ` [PATCH 06/14] arm64: dts: qcom: sm6115: Add usb and related phy nodes Iskren Chernev
2022-09-01 16:06 ` Krzysztof Kozlowski
2022-09-01 7:24 ` [PATCH 07/14] arm64: dts: qcom: sm6115: Add sdhci nodes and related pinctrl Iskren Chernev
2022-09-01 16:08 ` Krzysztof Kozlowski
2022-09-01 7:24 ` [PATCH 08/14] dt-bindings: ufs: qcom: Add sm6115 binding Iskren Chernev
2022-09-01 16:11 ` Krzysztof Kozlowski
2022-09-03 16:54 ` Iskren Chernev [this message]
2022-09-04 19:10 ` Krzysztof Kozlowski
2022-09-05 7:29 ` Iskren Chernev
2022-09-05 10:03 ` Krzysztof Kozlowski
2022-09-01 7:24 ` [PATCH 09/14] arm64: dts: qcom: sm6115: Add UFS nodes Iskren Chernev
2022-09-01 16:13 ` Krzysztof Kozlowski
2022-09-03 17:04 ` Iskren Chernev
2022-09-05 10:02 ` Krzysztof Kozlowski
2022-09-05 10:45 ` Iskren Chernev
2022-09-05 10:54 ` Krzysztof Kozlowski
2022-09-01 7:24 ` [PATCH 10/14] arm64: dts: qcom: sm6115: Add SPMI bus node Iskren Chernev
2022-09-01 16:14 ` Krzysztof Kozlowski
2022-09-01 7:24 ` [PATCH 11/14] dt-bindings: arm: cpus: Add kryo240 compatible Iskren Chernev
2022-09-01 15:29 ` Vinod Koul
2022-09-01 16:14 ` Krzysztof Kozlowski
2022-09-01 7:24 ` [PATCH 12/14] arm64: dts: qcom: sm4250: Add soc dtsi Iskren Chernev
2022-09-01 7:24 ` [PATCH 13/14] dt-bindings: arm: qcom: Add compatible for oneplus,billie2 phone Iskren Chernev
2022-09-01 16:17 ` Krzysztof Kozlowski
2022-09-01 7:24 ` [PATCH 14/14] arm64: dts: qcom: sm4250: Add support for oneplus-billie2 Iskren Chernev
2022-09-01 16:20 ` Krzysztof Kozlowski
2022-09-03 12:32 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89e6a200-d9af-7263-5e09-d7d824277a30@gmail.com \
--to=iskren.chernev@gmail.com \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bjorn.andersson@linaro.org \
--cc=bvanassche@acm.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).