From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wang, Haiyue" Subject: Re: [RFC PATCH 15/17] ipmi: kcs: aspeed: Implement v2 bindings Date: Sat, 27 Jul 2019 01:30:24 +0800 Message-ID: <89ea7e21-944e-3d89-05b7-2dedb7916fa9@linux.intel.com> References: <20190726053959.2003-1-andrew@aj.id.au> <20190726053959.2003-16-andrew@aj.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190726053959.2003-16-andrew@aj.id.au> Sender: linux-kernel-owner@vger.kernel.org To: Andrew Jeffery , linux-aspeed@lists.ozlabs.org Cc: robh+dt@kernel.org, mark.rutland@arm.com, joel@jms.id.au, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Corey Minyard , Arnd Bergmann , Greg Kroah-Hartman , openipmi-developer@lists.sourceforge.net List-Id: devicetree@vger.kernel.org ÔÚ 2019-07-26 13:39, Andrew Jeffery дµÀ: > The v2 bindings allow us to extract the resources from the devicetree. > The table in the driver is retained to derive the channel index, which > removes the need for kcs_chan property from the v1 bindings. The v2 > bindings allow us to reduce the number of warnings generated by the > existing devicetree nodes. > > Cc: Haiyue Wang > Cc: Corey Minyard > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman > Cc:openipmi-developer@lists.sourceforge.net > Signed-off-by: Andrew Jeffery > --- > drivers/char/ipmi/kcs_bmc_aspeed.c | 156 +++++++++++++++++++++++------ > 1 file changed, 127 insertions(+), 29 deletions(-) Looks good, thanks for the hard work, the code is more clean! :) Reviewed-by: Haiyue Wang