From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C86C1C433F5 for ; Mon, 21 Feb 2022 11:38:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356529AbiBULie (ORCPT ); Mon, 21 Feb 2022 06:38:34 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:58426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231761AbiBULi2 (ORCPT ); Mon, 21 Feb 2022 06:38:28 -0500 Received: from mail.kapsi.fi (mail.kapsi.fi [IPv6:2001:67c:1be8::25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 640C91AD98; Mon, 21 Feb 2022 03:38:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kapsi.fi; s=20161220; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=k++dA0QZ/l0Udf5bpYqTGcUCwXaoUM28Erkwayg30Jc=; b=DjFpUsSjsqvQ/gdEZdw8Rwa5Qo 9bXoOF1KTGBZPvp/rgZaf8yjzzKLP/CnTfXLXHxNahmNv+N3orhjP30d45zXNSyVNLdhnYAfKwb4Z RdZDWWyx5V+p2DZX1qChy8TvuoqPeByQau/37fzk1n2ruNUWTV+klAJ0okIv3AqAd/re6huAOP/Cs Z3al4naD7nxzxQhO5ec1AdRE8qA0HgbWtD/xEGMtJdjmIAer25KKsinCjvChQ/QbnHc9hgoI0UObV MtWELb4j25Syy6af3x6augoBrkrIZbIX1nPAE9ui+L3bLUFM7FwBo4yvzXLF5HNwa8VteE/Kid7IW ikdpDZ2A==; Received: from 91-158-25-70.elisa-laajakaista.fi ([91.158.25.70] helo=[192.168.1.10]) by mail.kapsi.fi with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1nM70t-0002ZP-Mh; Mon, 21 Feb 2022 13:37:55 +0200 Message-ID: <8a1387e5-b68f-db90-9ab5-0b8606ca8841@kapsi.fi> Date: Mon, 21 Feb 2022 13:37:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH v3 3/9] gpu: host1x: Add context device management code Content-Language: en-US To: Dmitry Osipenko , Mikko Perttunen , thierry.reding@gmail.com, jonathanh@nvidia.com, joro@8bytes.org, will@kernel.org, robh+dt@kernel.org, robin.murphy@arm.com Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220218113952.3077606-1-mperttunen@nvidia.com> <20220218113952.3077606-4-mperttunen@nvidia.com> <2605a614-0a2c-85ac-576a-048f38f9d366@gmail.com> From: Mikko Perttunen In-Reply-To: <2605a614-0a2c-85ac-576a-048f38f9d366@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 91.158.25.70 X-SA-Exim-Mail-From: cyndis@kapsi.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2/19/22 19:52, Dmitry Osipenko wrote: > 18.02.2022 14:39, Mikko Perttunen пишет: >> + for (index = 0; index < cdl->len; index++) { >> + struct iommu_fwspec *fwspec; >> + >> + ctx = &cdl->devs[index]; >> + >> + ctx->host = host1x; >> + >> + device_initialize(&ctx->dev); >> + >> + ctx->dev.dma_mask = &context_device_dma_mask; >> + ctx->dev.coherent_dma_mask = context_device_dma_mask; >> + dev_set_name(&ctx->dev, "host1x-ctx.%d", index); >> + ctx->dev.bus = &host1x_context_device_bus_type; > > host1x_context_device_bus_type will be an undefined symbol if > CONFIG_TEGRA_HOST1X_CONTEXT_BUS=n? Please compile and test all combinations. But this file is only built if CONFIG_HOST1X, which selects CONFIG_TEGRA_HOST1X_CONTEXT_BUS? Mikko