From: Krzysztof Kozlowski <krzk@kernel.org>
To: Daisuke Nojiri <dnojiri@chromium.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: cros-ec-keyboard: Add keyboard matrix v3.0
Date: Thu, 6 Jun 2024 08:27:00 +0200 [thread overview]
Message-ID: <8a197b98-8a7b-4675-b175-6d8ddaeb072e@kernel.org> (raw)
In-Reply-To: <20240606010808.27069-1-dnojiri@chromium.org>
On 06/06/2024 03:08, Daisuke Nojiri wrote:
> Add support for keyboard matrix version 3.0.
Not much improved.
>
> Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
This is a friendly reminder during the review process.
It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.
Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-06 6:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240604005354.2294468-1-dnojiri@chromium.org>
2024-06-04 17:09 ` [PATCH 3/3] ARM: dts: cros-ec-keyboard: Add keyboard matrix v3.0 Daisuke Nojiri
2024-06-04 19:09 ` Dmitry Torokhov
2024-06-04 23:09 ` Daisuke Nojiri
2024-06-06 0:24 ` Rob Herring
2024-06-06 1:08 ` [PATCH 3/3] dt-bindings: " Daisuke Nojiri
2024-06-06 6:27 ` Krzysztof Kozlowski [this message]
[not found] ` <20240606173509.243739-1-dnojiri@chromium.org>
2024-06-06 17:34 ` [PATCH 3/3 v4] " Daisuke Nojiri
2024-06-06 17:40 ` [PATCH 0/3 v4] Add cros-ec-keyboard v3.0 Daisuke Nojiri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a197b98-8a7b-4675-b175-6d8ddaeb072e@kernel.org \
--to=krzk@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dnojiri@chromium.org \
--cc=groeck@chromium.org \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).