public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: "Yu-Chun Lin [林祐君]" <eleanor.lin@realtek.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "linusw@kernel.org" <linusw@kernel.org>,
	"brgl@kernel.org" <brgl@kernel.org>,
	"robh@kernel.org" <robh@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"afaerber@suse.com" <afaerber@suse.com>,
	"TY_Chang[張子逸]" <tychang@realtek.com>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-realtek-soc@lists.infradead.org"
	<linux-realtek-soc@lists.infradead.org>,
	"CY_Huang[黃鉦晏]" <cy.huang@realtek.com>,
	"Stanley Chang[昌育德]" <stanley_chang@realtek.com>,
	"James Tai [戴志峰]" <james.tai@realtek.com>
Subject: RE: [PATCH 1/3] dt-bindings: gpio: realtek: Add realtek,rtd1625-gpio
Date: Wed, 1 Apr 2026 11:10:33 +0000	[thread overview]
Message-ID: <8a4f558fdc6649be8c6239403e706621@realtek.com> (raw)
In-Reply-To: <20260401-idealistic-grinning-wallaby-8c3cd5@quoll>

> On Tue, Mar 31, 2026 at 07:38:33PM +0800, Yu-Chun Lin wrote:
> > +  reg:
> > +    items:
> > +      - description: GPIO controller registers
> > +      - description: GPIO interrupt registers
> > +
> > +  interrupts:
> > +    items:
> > +      - description: Interrupt number of the assert GPIO interrupt, which
> is
> > +                     triggered when there is a rising edge.
> > +      - description: Interrupt number of the deassert GPIO interrupt,
> which is
> > +                     triggered when there is a falling edge.
> > +      - description: Interrupt number of the level-sensitive GPIO interrupt,
> > +                     triggered by a configured logic level.
> > +
> > +  interrupt-controller: true
> > +
> > +  "#interrupt-cells":
> > +    const: 2
> > +
> > +  gpio-ranges: true
> > +
> > +  gpio-controller: true
> > +
> > +  "#gpio-cells":
> > +    const: 2
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - gpio-ranges
> > +  - gpio-controller
> > +  - "#gpio-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    gpio@89120 {
> > +      compatible = "realtek,rtd1625-isom-gpio";
> > +      reg = <0x89120 0x10>,
> 
> 0x10 feels very short range.
> 
> > +            <0x89100 0x20>;
> 
> And this means it's continuous. Are you sure these are two separate address
> spaces?
> 
> Best regards,
> Krzysztof

Agreed, they are continuous. I will merge them into a single region in v2.

Best regards,
Yu-Chun

  reply	other threads:[~2026-04-01 11:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31 11:38 [PATCH 0/3] gpio: realtek: Add support for Realtek DHC RTD1625 Yu-Chun Lin
2026-03-31 11:38 ` [PATCH 1/3] dt-bindings: gpio: realtek: Add realtek,rtd1625-gpio Yu-Chun Lin
2026-04-01  7:47   ` Krzysztof Kozlowski
2026-04-01 11:10     ` Yu-Chun Lin [林祐君] [this message]
2026-04-01 11:12       ` Krzysztof Kozlowski
2026-03-31 11:38 ` [PATCH 2/3] arm64: dts: realtek: Add GPIO support for RTD1625 Yu-Chun Lin
2026-04-01  7:49   ` Krzysztof Kozlowski
2026-04-01 11:21     ` Yu-Chun Lin [林祐君]
2026-03-31 11:38 ` [PATCH 3/3] gpio: realtek: Add driver for Realtek DHC RTD1625 SoC Yu-Chun Lin
2026-03-31 12:15   ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a4f558fdc6649be8c6239403e706621@realtek.com \
    --to=eleanor.lin@realtek.com \
    --cc=afaerber@suse.com \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cy.huang@realtek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=james.tai@realtek.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-realtek-soc@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=stanley_chang@realtek.com \
    --cc=tychang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox