From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDD54EB64D9 for ; Thu, 15 Jun 2023 14:59:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241650AbjFOO7E (ORCPT ); Thu, 15 Jun 2023 10:59:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344680AbjFOO64 (ORCPT ); Thu, 15 Jun 2023 10:58:56 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 184252D42 for ; Thu, 15 Jun 2023 07:58:53 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-4f6370ddd27so10703285e87.0 for ; Thu, 15 Jun 2023 07:58:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686841131; x=1689433131; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Uft+CVcyQtvxjPemL6r4Oh7qCEnxqfPWZRaOgMtD3t8=; b=b3WfLv+Lup6DOzdHe6Srfh5BAIcCWkvoc2mcUHk0r60aOiS6EdMlX867mXgJXqWLQ6 k1JJVDc++3yUZ8iXTutAiMLLJhpAi1qBDYxvOGYM2aBBd/H4lSJp3Sbox+zMjzUqA9Af KO3cZx9U39Bl5YxppN6kl8+Qx32cHhmVuhEfTXkgdP8UhDJj8clisCDarAhOSa0pk1Xw zlgAxuxt2wEM20wCjzL/958QAm9+yPyJhVCaNGCJsdomIVROfAaey7GPZxJhIqRh94sj 2sI/9wwlZ0F0/ejs8vjm5GjhG6XkKU0uLAe+jVrqZs2RrWycJVp0LoLkEWBUZNInOuRr 5RHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686841131; x=1689433131; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Uft+CVcyQtvxjPemL6r4Oh7qCEnxqfPWZRaOgMtD3t8=; b=dwGBDg4gcHpeYPeo5OOTgM0Ds8HsTD3fdipEeHo0haSzc9zdJyUKwNpdir4ukFvNDi QY8nhaguOT258meVuwsmNz25vJbzAwEFk7/CedP49EtP4QwfJkqFbvcAumxC+kNSDn5I F+UH9RwhTDkgikmBSO3mwXWtrOHlv5xRpwg+lIO9No0iC4IczoEleaLUNH+oCF8kFQI4 BCFZshWhVdEP9BgU5tbIuqLMdTPbQleyWVYykaD1IW6Wwknn97ZKA+ouxKAASAsUVLsV 53Dfn3urDn7xgUSrcDnbESSqts/dJ+QizQ2i5Zw9ajm2/8Wi5AHdEGme2nSTQ5KocgxF +gSA== X-Gm-Message-State: AC+VfDwNaFnQXX78LzpEausWInDQ/kYNFDcT2WjNlNKc/8sLSUrcDvgo zU6iynD072RbaFeVLqvaoOZk8w== X-Google-Smtp-Source: ACHHUZ6Wq8XrZsTRpYQDYV7g30Miws2XrVRZhDeCyISNAUewWWsY494u23i/SZrxY4QmWtbZF+UUng== X-Received: by 2002:a19:e019:0:b0:4f3:ac64:84d9 with SMTP id x25-20020a19e019000000b004f3ac6484d9mr11836666lfg.20.1686841131255; Thu, 15 Jun 2023 07:58:51 -0700 (PDT) Received: from [192.168.1.101] (abyj190.neoplus.adsl.tpnet.pl. [83.9.29.190]) by smtp.gmail.com with ESMTPSA id p3-20020ac246c3000000b004f004c0498esm2604065lfo.71.2023.06.15.07.58.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jun 2023 07:58:50 -0700 (PDT) Message-ID: <8a4f8af5-c181-6e30-bfb5-be25f77a51a0@linaro.org> Date: Thu, 15 Jun 2023 16:58:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH V2 2/2] arm64: dts: qcom: ipq9574: enable GPIO based LEDs Content-Language: en-US To: Sridharan S N , agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230615145311.2776-1-quic_sridsn@quicinc.com> <20230615145311.2776-3-quic_sridsn@quicinc.com> From: Konrad Dybcio In-Reply-To: <20230615145311.2776-3-quic_sridsn@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 15.06.2023 16:53, Sridharan S N wrote: > Add support for wlan-2g LED on GPIO 64. > > Signed-off-by: Sridharan S N > --- Same comments as on patch 1. Konrad > Changes in V2: > - Updated commit message > > .../boot/dts/qcom/ipq9574-rdp-common.dtsi | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi > index fd5326dc1773..25424cecd834 100644 > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi > @@ -34,6 +34,18 @@ > debounce-interval = <60>; > }; > }; > + > + leds { > + compatible = "gpio-leds"; > + pinctrl-0 = <&gpio_leds_default>; > + pinctrl-names = "default"; > + > + led-0 { > + gpios = <&tlmm 64 GPIO_ACTIVE_LOW>; > + linux,default-trigger = "phy0tx"; > + default-state = "off"; > + }; > + }; > }; > > &blsp1_spi0 { > @@ -137,6 +149,14 @@ > drive-strength = <8>; > bias-pull-up; > }; > + > + gpio_leds_default: gpio-leds-default-state { > + pins = "gpio64"; > + function = "gpio"; > + drive-strength = <8>; > + bias-pull-up; > + }; > + > }; > > &xo_board_clk {