From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 894B2C77B77 for ; Mon, 17 Apr 2023 13:37:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230229AbjDQNhG (ORCPT ); Mon, 17 Apr 2023 09:37:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229802AbjDQNhF (ORCPT ); Mon, 17 Apr 2023 09:37:05 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EA3D1FF0 for ; Mon, 17 Apr 2023 06:37:03 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2a8b082d6feso13727381fa.2 for ; Mon, 17 Apr 2023 06:37:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681738622; x=1684330622; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ajiTsFHjF5bEfn/T0pz497Y4T0W30EVlD5XZiWzW1G8=; b=k5Ai8lynqBteD3+ZaXcqgNcsEUo5d6I1KDWEBPrXfHBbhz0GPJDjV+iWgcELffFW2N T36YVT2Sy86NuQbvuMLTjodQ0XE3EhFULHLnHvQL09KakbwiDeB9ucZe8XqUj/CXRlSq y+WC08aV7bI8zAmgTCxNzlYSLx1NmTVjh80jQmF4d5iM4PYnwi07FcBdx5Rv/ZV5ChPU c2XTYkbs9qGVbJRcSVDiCT80JnDIQgpQvPJc49GEyYnTpSOcaJKRcMZZK49DouhhCho3 7vYIY/lZFf8B8w3lBpnziyPT6B9YA4JVLUswFvsV6lq6RLwnoPuzLu6lhQfowSwA7gho WU0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681738622; x=1684330622; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ajiTsFHjF5bEfn/T0pz497Y4T0W30EVlD5XZiWzW1G8=; b=M1HS10rFR+puF7nJ3JmrZ9grTuPDsTXu2uw7KuCSnSCZGbTqiy5sJ9ezeSZPtsk8SR Ip4shP2mQkkQnjyMg6/WoS+Q8+gZsUAHbpvYYrY1Y9CZx1soyjqd1ALY7OkA5u+tM5UM r0qldjMfie2nTId3cwnryd4EzjSyJ9ILsHHr15RJG/Oyb+IsjsH+HZX/eLTd6YWS/DjE QaQqc1lif8cmb3sVpoo9gt3Jz+Wp7eQATd7XYUCmSf79A5Z+lQn+oztxpMLV6LyTfZzI OlyEP0nTs1pcl3s9Y7FSGZhzU9r957u4ycEOTAYe+g9DeTNiEFRYnDwEUUc8DRBUNSfv hjoQ== X-Gm-Message-State: AAQBX9cnr9Rzj+/U1JL7cy2gw/kLu6FU+e7W/EKAJ3eQXO3S9ey2ympz wTtJlMDdyVtgPPv/p01ZdCcGhg== X-Google-Smtp-Source: AKy350bqpmBwO7pT6gTJyyulqIMk2WplO3I3p5A9atMkIk4oS8bLgIA8QDfDyLRF7NBH71KIU62zxQ== X-Received: by 2002:ac2:4c2f:0:b0:4ec:b1bf:a55b with SMTP id u15-20020ac24c2f000000b004ecb1bfa55bmr1642956lfq.24.1681738621717; Mon, 17 Apr 2023 06:37:01 -0700 (PDT) Received: from [192.168.1.101] (abyk99.neoplus.adsl.tpnet.pl. [83.9.30.99]) by smtp.gmail.com with ESMTPSA id u6-20020ac243c6000000b004e7fa99f2b5sm2061422lfl.186.2023.04.17.06.37.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Apr 2023 06:37:01 -0700 (PDT) Message-ID: <8a6834d6-8e5a-3c48-8a04-8d9c4d160408@linaro.org> Date: Mon, 17 Apr 2023 15:36:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v4] dt-bindings: net: Convert ATH10K to YAML Content-Language: en-US To: Kalle Valo Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Marijn Suijten , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20230406-topic-ath10k_bindings-v4-1-9f67a6bb0d56@linaro.org> <87pm82x1ew.fsf@kernel.org> From: Konrad Dybcio In-Reply-To: <87pm82x1ew.fsf@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17.04.2023 12:12, Kalle Valo wrote: > Konrad Dybcio writes: > >> Convert the ATH10K bindings to YAML. >> >> Dropped properties that are absent at the current state of mainline: >> - qcom,msi_addr >> - qcom,msi_base > > Very good, thanks. Clearly I had missed that those were unused during > the review. > >> qcom,coexist-support and qcom,coexist-gpio-pin do very little and should >> be reconsidered on the driver side, especially the latter one. > > I'm curious, what do you mean very little? We set ath10k firmware > parameters based on these coex properties. How would you propose to > handle these? Right, I first thought they did nothing and then realized they're sent to the fw.. I never amended the commit message though.. > >> Somewhat based on the ath11k bindings. >> >> Signed-off-by: Konrad Dybcio > > [...] > >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml >> @@ -0,0 +1,358 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/wireless/qcom,ath10k.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Technologies ATH10K wireless devices > > [...] > >> + wifi-firmware: >> + type: object >> + additionalProperties: false >> + description: | >> + The ATH10K Wi-Fi node can contain one optional firmware subnode. >> + Firmware subnode is needed when the platform does not have Trustzone. > > Is there a reason why you write ath10k in upper case? There are two case > of that in the yaml file. We usually write it in lower case, can I > change to that? No particular reason, my brain just implicitly decided that it should be this way.. Please unify it (or LMK if you want me to perform another resend)! Konrad >