From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Rob Herring <robh@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
devicetree@vger.kernel.org, robdclark@gmail.com,
quic_abhinavk@quicinc.com, sean@poorly.run, airlied@gmail.com,
daniel@ffwll.ch, dianders@chromium.org, david@ixit.cz,
krzysztof.kozlowski+dt@linaro.org, swboyd@chromium.org,
konrad.dybcio@somainline.org, agross@kernel.org,
andersson@kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 07/18] dt-bindings: display/msm: Add list of mdss-dsi-ctrl compats
Date: Wed, 4 Jan 2023 11:37:56 +0200 [thread overview]
Message-ID: <8a68bb5c-6006-c852-227d-d68751258a61@linaro.org> (raw)
In-Reply-To: <20230104002905.GA134092-robh@kernel.org>
On 04/01/2023 02:29, Rob Herring wrote:
> On Fri, Dec 23, 2022 at 02:10:14AM +0000, Bryan O'Donoghue wrote:
>> Add the list of current compats absent the deprecated qcm2290 to the list
>> of dsi compats listed here.
>>
>> Several MDSS yaml files exist which document the dsi sub-node.
>> For each existing SoC MDSS yaml, provide the right dsi compat string.
>>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> ---
>> .../bindings/display/msm/qcom,mdss.yaml | 16 +++++++++++++++-
>> .../bindings/display/msm/qcom,msm8998-mdss.yaml | 8 +++++---
>> .../bindings/display/msm/qcom,sc7180-mdss.yaml | 6 ++++--
>> .../bindings/display/msm/qcom,sc7280-mdss.yaml | 6 ++++--
>> .../bindings/display/msm/qcom,sdm845-mdss.yaml | 8 +++++---
>> .../bindings/display/msm/qcom,sm8250-mdss.yaml | 8 +++++---
>> 6 files changed, 38 insertions(+), 14 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml
>> index ba0460268731b..86bb43489bf4a 100644
>> --- a/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml
>> @@ -94,7 +94,21 @@ patternProperties:
>> type: object
>> properties:
>> compatible:
>> - const: qcom,mdss-dsi-ctrl
>> + items:
>> + - enum:
>> + - qcom,apq8064-dsi-ctrl
>> + - qcom,msm8916-dsi-ctrl
>> + - qcom,msm8953-dsi-ctrl
>> + - qcom,msm8974-dsi-ctrl
>> + - qcom,msm8996-dsi-ctrl
>> + - qcom,msm8998-dsi-ctrl
>> + - qcom,qcm2290-dsi-ctrl
>> + - qcom,sc7180-dsi-ctrl
>> + - qcom,sc7280-dsi-ctrl
>> + - qcom,sdm660-dsi-ctrl
>> + - qcom,sdm845-dsi-ctrl
>> + - qcom,sm8250-dsi-ctrl
>> + - const: qcom,mdss-dsi-ctrl
>
> No need to have an exact match here. Just this is enough:
>
> compatible:
> contains:
> const: qcom,mdss-dsi-ctrl
>
> Then the DSI schema will check the rest.
I think the intent here should have been to list DSI variants usable
with the qcom,mdss device. But then the list should be shortened a bit.
E.g. apq8064 is pre-MDSS and sc7180/7280 and sm8250 are used with
qcom,SoC-mdss devices rather than just qcom,mdss.
> Same for the rest.
>
> Rob
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-01-04 9:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 2:10 [PATCH v6 00/18] mdss-dsi-ctrl binding and dts fixes Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 01/18] dt-bindings: msm: dsi-controller-main: Fix operating-points-v2 constraint Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 02/18] dt-bindings: msm: dsi-controller-main: Fix power-domain constraint Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 03/18] dt-bindings: msm: dsi-controller-main: Fix description of core clock Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 04/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC Bryan O'Donoghue
2023-01-10 5:48 ` Dmitry Baryshkov
2022-12-23 2:10 ` [PATCH v6 05/18] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis Bryan O'Donoghue
2023-01-10 5:47 ` Dmitry Baryshkov
2022-12-23 2:10 ` [PATCH v6 06/18] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 07/18] dt-bindings: display/msm: Add list of mdss-dsi-ctrl compats Bryan O'Donoghue
2023-01-04 0:29 ` Rob Herring
2023-01-04 9:37 ` Dmitry Baryshkov [this message]
2022-12-23 2:10 ` [PATCH v6 08/18] ARM: dts: qcom: apq8064: add compat qcom,apq8064-dsi-ctrl Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 09/18] ARM: dts: qcom: msm8974: Add compat qcom,msm8974-dsi-ctrl Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 10/18] arm64: dts: qcom: msm8916: Add compat qcom,msm8916-dsi-ctrl Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 11/18] arm64: dts: qcom: msm8953: Add compat qcom,msm8953-dsi-ctrl Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 12/18] arm64: dts: qcom: msm8996: Add compat qcom,msm8996-dsi-ctrl Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 13/18] arm64: dts: qcom: sc7180: Add compat qcom,sc7180-dsi-ctrl Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 14/18] arm64: dts: qcom: sc7280: Add compat qcom,sc7280-dsi-ctrl Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 15/18] arm64: dts: qcom: sdm630: Add compat qcom,sdm660-dsi-ctrl Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 16/18] arm64: dts: qcom: sdm660: " Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 17/18] arm64: dts: qcom: sdm845: Add compat qcom,sdm845-dsi-ctrl Bryan O'Donoghue
2022-12-23 2:10 ` [PATCH v6 18/18] arm64: dts: qcom: sm8250: Add compat qcom,sm8250-dsi-ctrl Bryan O'Donoghue
2022-12-29 17:23 ` (subset) [PATCH v6 00/18] mdss-dsi-ctrl binding and dts fixes Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a68bb5c-6006-c852-227d-d68751258a61@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=daniel@ffwll.ch \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).