From: Ritesh Harjani <riteshh@codeaurora.org>
To: Sowjanya Komatineni <skomatineni@nvidia.com>,
adrian.hunter@intel.com, ulf.hansson@linaro.org,
robh+dt@kernel.org, mark.rutland@arm.com
Cc: thierry.reding@gmail.com, jonathanh@nvidia.com, anrao@nvidia.com,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH V3 06/10] mmc: cqhci: allow hosts to update dcmd cmd desc
Date: Thu, 14 Mar 2019 11:02:28 +0530 [thread overview]
Message-ID: <8a90c2e5-fd0a-9ea3-59a5-c237c0003a3b@codeaurora.org> (raw)
In-Reply-To: <1552513552-23423-6-git-send-email-skomatineni@nvidia.com>
On 3/14/2019 3:15 AM, Sowjanya Komatineni wrote:
> This patch adds update_dcmd_desc interface to cqhci_host_ops to
> allow hosts to update any of the DCMD task descriptor attributes
> and parameters.
>
> Tested-by: Jon Hunter <jonathanh@nvidia.com>
> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
Thanks,
Reviewed-by: Ritesh Harjani <riteshh@codeaurora.org>
> ---
> drivers/mmc/host/cqhci.c | 2 ++
> drivers/mmc/host/cqhci.h | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
> index a8af682a9182..d59cb0a51964 100644
> --- a/drivers/mmc/host/cqhci.c
> +++ b/drivers/mmc/host/cqhci.c
> @@ -537,6 +537,8 @@ static void cqhci_prep_dcmd_desc(struct mmc_host *mmc,
> CQHCI_ACT(0x5) |
> CQHCI_CMD_INDEX(mrq->cmd->opcode) |
> CQHCI_CMD_TIMING(timing) | CQHCI_RESP_TYPE(resp_type));
> + if (cq_host->ops->update_dcmd_desc)
> + cq_host->ops->update_dcmd_desc(mmc, mrq, &data);
> *task_desc |= data;
> desc = (u8 *)task_desc;
> pr_debug("%s: cqhci: dcmd: cmd: %d timing: %d resp: %d\n",
> diff --git a/drivers/mmc/host/cqhci.h b/drivers/mmc/host/cqhci.h
> index 9e68286a07b4..8c8ec6f01c45 100644
> --- a/drivers/mmc/host/cqhci.h
> +++ b/drivers/mmc/host/cqhci.h
> @@ -210,6 +210,8 @@ struct cqhci_host_ops {
> u32 (*read_l)(struct cqhci_host *host, int reg);
> void (*enable)(struct mmc_host *mmc);
> void (*disable)(struct mmc_host *mmc, bool recovery);
> + void (*update_dcmd_desc)(struct mmc_host *mmc, struct mmc_request *mrq,
> + u64 *data);
> };
>
> static inline void cqhci_writel(struct cqhci_host *host, u32 val, int reg)
next prev parent reply other threads:[~2019-03-14 5:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 21:45 [PATCH V3 01/10] mmc: tegra: fix ddr signaling for non-ddr modes Sowjanya Komatineni
2019-03-13 21:45 ` [PATCH V3 02/10] mmc: sdhci: allow host to specify maximum tuning loops Sowjanya Komatineni
2019-03-13 21:45 ` [PATCH V3 03/10] mmc: tegra: update hw tuning process Sowjanya Komatineni
2019-03-13 21:45 ` [PATCH V3 04/10] dt-bindings: mmc: tegra: document Tegra194 compatible string Sowjanya Komatineni
2019-03-13 21:45 ` [PATCH V3 05/10] arm64: tegra: fix default tap and trim values Sowjanya Komatineni
2019-03-21 10:32 ` Ulf Hansson
2019-03-21 15:22 ` Sowjanya Komatineni
2019-04-01 17:42 ` Sowjanya Komatineni
2019-04-11 10:11 ` Ulf Hansson
2019-04-11 19:42 ` Sowjanya Komatineni
2019-03-13 21:45 ` [PATCH V3 06/10] mmc: cqhci: allow hosts to update dcmd cmd desc Sowjanya Komatineni
2019-03-14 5:32 ` Ritesh Harjani [this message]
2019-03-13 21:45 ` [PATCH V3 07/10] mmc: tegra: add Tegra186 WAR for CQE Sowjanya Komatineni
2019-03-14 5:34 ` Ritesh Harjani
2019-03-13 21:45 ` [PATCH V3 08/10] mmc: cqhci: add CQHCI_SSC1 register CBC field mask Sowjanya Komatineni
2019-03-13 21:45 ` [PATCH V3 09/10] mmc: tegra: fix CQE enable and resume sequence Sowjanya Komatineni
2019-03-13 21:45 ` [PATCH V3 10/10] arm64: tegra: enable command queue for tegra186 sdmmc4 Sowjanya Komatineni
2019-03-21 10:32 ` [PATCH V3 01/10] mmc: tegra: fix ddr signaling for non-ddr modes Ulf Hansson
2019-03-21 15:24 ` Sowjanya Komatineni
2019-03-24 4:49 ` Sowjanya Komatineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a90c2e5-fd0a-9ea3-59a5-c237c0003a3b@codeaurora.org \
--to=riteshh@codeaurora.org \
--cc=adrian.hunter@intel.com \
--cc=anrao@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).