From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: yuji2.ishikawa@toshiba.co.jp, hverkuil@xs4all.nl,
laurent.pinchart@ideasonboard.com, mchehab@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, nobuhiro1.iwamatsu@toshiba.co.jp
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 1/5] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface
Date: Wed, 4 Oct 2023 08:51:17 +0200 [thread overview]
Message-ID: <8a936a54-9c20-4a3b-ac2c-ae65cd22698f@linaro.org> (raw)
In-Reply-To: <TYAPR01MB6201C2E34B969197C9E9DFB492C4A@TYAPR01MB6201.jpnprd01.prod.outlook.com>
On 04/10/2023 01:10, yuji2.ishikawa@toshiba.co.jp wrote:
>>> + properties:
>>> + endpoint:
>>> + $ref: video-interfaces.yaml#
>>> + additionalProperties: false
>>
>> This is a friendly reminder during the review process.
>>
>> It seems my previous comments were not fully addressed. Maybe my feedback
>> got lost between the quotes, maybe you just forgot to apply it.
>> Please go back to the previous discussion and either implement all requested
>> changes or keep discussing them.
>>
>> Thank you.
>
> I'm very sorry that I misunderstood the intent of the last conversion.
> https://lore.kernel.org/all/0aa471ce-da83-172d-d870-1ec7a562baf7@linaro.org/
> I thought "additionalProperties: false" can be used and "xxx:true" should stay.
>
> Let me confirm your intentions:
> - "unevaluatedProperties: false" should be used instead of "additionalProperties: false"
> - All of "xxx: true" should be removed
> Are these two correct understandings?
Ah, true, I missed that. It is indeed fine, apologies.
>
>>
>>> +
>>> + required:
>>> + - clock-noncontinuous
>>> + - link-frequencies
>>> + - remote-endpoint
>>> + - data-lanes
>>
>> Not much improved here. required goes after properties, always. I pointed you
>> last time the file which you should use as an example.
>
> I'll check the overall structure of renesas,rzg2l-csi2.yaml.
This needs to be fixed.
>
>>> +
>>> + properties:
>>> + data-lanes:
>>> + description: VIIF supports 1, 2, 3 or 4 data lanes
>>> + minItems: 1
>>> + items:
>>> + - const: 1
>>> + - const: 2
>>> + - const: 3
>>> + - const: 4
>>> +
>>> + clock-noncontinuous: true
>>
>> Drop
This and further can be ignored.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-04 6:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 23:28 [PATCH v8 0/5] Add Toshiba Visconti Video Input Interface driver Yuji Ishikawa
2023-09-25 23:28 ` [PATCH v8 1/5] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface Yuji Ishikawa
2023-09-28 5:32 ` Krzysztof Kozlowski
2023-10-03 23:10 ` yuji2.ishikawa
2023-10-04 6:51 ` Krzysztof Kozlowski [this message]
2023-10-05 12:30 ` yuji2.ishikawa
2023-09-25 23:28 ` [PATCH v8 2/5] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver Yuji Ishikawa
2023-09-25 23:28 ` [PATCH v8 3/5] media: add V4L2 vendor specific control handlers Yuji Ishikawa
2023-09-25 23:28 ` [PATCH v8 4/5] documentation: media: add documentation for Toshiba Visconti Video Input Interface driver Yuji Ishikawa
2023-09-25 23:28 ` [PATCH v8 5/5] MAINTAINERS: Add entries for Toshiba Visconti Video Input Interface Yuji Ishikawa
2023-09-27 13:23 ` [PATCH v8 0/5] Add Toshiba Visconti Video Input Interface driver Hans Verkuil
2023-09-29 1:49 ` yuji2.ishikawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a936a54-9c20-4a3b-ac2c-ae65cd22698f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=robh+dt@kernel.org \
--cc=yuji2.ishikawa@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).