From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BDB9C433E0 for ; Wed, 3 Feb 2021 06:50:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B74564E40 for ; Wed, 3 Feb 2021 06:50:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231726AbhBCGu0 (ORCPT ); Wed, 3 Feb 2021 01:50:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231722AbhBCGuX (ORCPT ); Wed, 3 Feb 2021 01:50:23 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 396F5C0613D6 for ; Tue, 2 Feb 2021 22:49:43 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id p15so22829796wrq.8 for ; Tue, 02 Feb 2021 22:49:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Llt9wZ/++YWpNuv24fYJyAK2KaKZ50JAQBYyHHTRHl0=; b=eMd6ybxnZ1GMNU8CePXnXb1pTr6Ufz1IDd0Ctp4ZlKMVoPoNxn0ozbVA2qeUr1CqPN Go0jM+q9METdwsc19UY3lhxyBGBqmQem9uQv3feFzfiYu4Xm4gubwTEDWsqd6ndAz/R5 zZaaTNnjrM7HXSPRIzwwnd+ICKb9BAO+0Q0r9CbY+tLvoNv5Wmq3vEwWU3qWhB6v6x0s p15tmaQ+8Rx7FSXc4FF1/shXUABaAcZhXzjWQvk+prBEyBK8nxwoDu2/H9wPkCsqj7wv jXQo5x/fNSBx3ThDZnAN6BUFvMO4tD6gcg8vofcRDo3n2hTDGX67QtWQV5CHc9lU+dg9 aiAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Llt9wZ/++YWpNuv24fYJyAK2KaKZ50JAQBYyHHTRHl0=; b=a9gU3H2BGNjk8d4xP1z+tJQ0Hx6NIFc96mga9AFBfe+XvvK4E6wEipVLWbGEuYx/76 WjfvWeus/aZ6F4pnInX68dwluCgdJr8uvKlVeRqCNqtWFvwYHQOm4yJ9iGw0ISKqnRW2 zScdthhNW3Oy9acDS+tKLNpiqBoXscwf7pQjOcUHvNNZuEloF1+FEpR2MoP24TE6ntkL LsoWyBxcQEGqsy1qTMKZt4IZmNn6M8ncxN83HNVzupjyOu2v4sz6bdcksERp95MQOzL2 w89j/oGQX78GD1cjZyetEx6Fp/gV0U3hrrf39crV4MibgTi4NnkrrhHb81+hi0jTE5Ew HupQ== X-Gm-Message-State: AOAM532Y+sbqsiin28RURDuX7eitZqmxg5o62NlVadTkBnsO3ieBXyF9 uko/mDO3S3sJGrCHctQ77zKFkw== X-Google-Smtp-Source: ABdhPJxQrjhEspsMyRywC+CZuV6pLjH2d0gs0SU2q/MWY/IqDeweyxSs/Z4+de3Z6tAprGygraB2Qw== X-Received: by 2002:adf:fc86:: with SMTP id g6mr1721941wrr.20.1612334981687; Tue, 02 Feb 2021 22:49:41 -0800 (PST) Received: from [10.44.66.8] ([212.45.67.2]) by smtp.googlemail.com with ESMTPSA id l5sm1883815wrv.44.2021.02.02.22.49.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Feb 2021 22:49:41 -0800 (PST) Subject: Re: [PATCH v2 5/5] interconnect: qcom: Add MSM8939 interconnect provider driver To: Benjamin Li , Vincent Knecht , Jun Nie , devicetree@vger.kernel.org, bjorn.andersson@linaro.org, agross@kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, robh@kernel.org Cc: shawn.guo@linaro.org References: <20201204075345.5161-1-jun.nie@linaro.org> <20201204075345.5161-6-jun.nie@linaro.org> <7630c4aa-b023-55a6-e2aa-37a7538c6b45@squareup.com> From: Georgi Djakov Message-ID: <8aa03f6d-dcf5-73b3-41f8-0d872d9f4f86@linaro.org> Date: Wed, 3 Feb 2021 08:49:40 +0200 MIME-Version: 1.0 In-Reply-To: <7630c4aa-b023-55a6-e2aa-37a7538c6b45@squareup.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Ben, On 2/3/21 02:50, Benjamin Li wrote: > On 1/5/21 5:54 AM, Georgi Djakov wrote: >> On 1/2/21 13:08, Vincent Knecht wrote: >>> Le vendredi 04 décembre 2020 à 15:53 +0800, Jun Nie a écrit : >>>> Add driver for the Qualcomm interconnect buses found in MSM8939 based >>>> platforms. The topology consists of four NoCs that are controlled by >>>> a remote processor that collects the aggregated bandwidth for each >>>> master-slave pairs. >>>> >>>> Signed-off-by: Jun Nie >>> >>> Shouldn't some rpm ids be changed like they were for msm8916 in the following patch ? >>> c497f9322af9 ("interconnect: qcom: msm8916: Remove rpm-ids from non-RPM nodes") >>> https://patchwork.kernel.org/project/linux-arm-msm/patch/20201112105140.10092-1-georgi.djakov@linaro.org/ >> >> Maybe they should. I don't have the hardware to try it, but the test will be >> to just add the NoC DT nodes, enable the driver and inspect the boot log for >> messages like: >> [    2.926647] qcom_icc_rpm_smd_send mas X error -6 >> >> Thanks, >> Georgi > > Hi Vincent & Georgi, > > Thanks, I ran your suggestion on an MSM8939 board (with an additional > change to print slave IDs as well). Results: > > [ 1.901376] qcom_icc_rpm_smd_send slv 24 error -6 > [ 2.005977] qcom_icc_rpm_smd_send mas 20 error -6 > [ 2.010250] qcom_icc_rpm_smd_send slv 20 error -6 > [ 2.014684] qcom_icc_rpm_smd_send slv 106 error -6 > [ 2.019338] qcom_icc_rpm_smd_send slv 107 error -6 > [ 2.024615] qcom_icc_rpm_smd_send slv 29 error -6 > [ 2.028782] qcom_icc_rpm_smd_send mas 3 error -6 > [ 2.034657] qcom_icc_rpm_smd_send mas 100 error -6 > (and there's another slv 131 that's hidden by the mas 100 failure) > > Jun, I'll send you the patch I tested with to silence all these errors, > if you want to just squash that into the next version of your patchset. Thank you for doing this! Please send a follow-up patch as i already queued Jun's patches. Thanks, Georgi