From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Eddie James <eajames@linux.vnet.ibm.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-i2c <linux-i2c@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Wolfram Sang <wsa@the-dreams.de>,
Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Mark Rutland <mark.rutland@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Edward A. James" <eajames@us.ibm.com>
Subject: Re: [PATCH v7 3/7] drivers/i2c: Add port structure to FSI algorithm
Date: Thu, 31 May 2018 07:16:00 +1000 [thread overview]
Message-ID: <8aaa7fa9874bf140354964535ce5cf023012c3f4.camel@kernel.crashing.org> (raw)
In-Reply-To: <ae3de08c-6849-bb3a-7c6c-96309876d48e@linux.vnet.ibm.com>
On Wed, 2018-05-30 at 10:47 -0500, Eddie James wrote:
> > > + if (!list_empty(&i2c->ports)) {
> >
> > My gosh, this is done already in list_for_each*()
>
> No, list_for_each_entry does NOT check if the list is empty or if the
> first entry is NULL.
NULL is never valid for a list. It does however check for an empty list
It does it implicitely in the test part of the for () statement,
checking if the next pointer points back to the head.
Cheers,
Ben.
next prev parent reply other threads:[~2018-05-30 21:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 22:24 [PATCH v7 0/7] i2c: Add FSI-attached I2C master algorithm Eddie James
2018-05-29 22:24 ` [PATCH v7 1/7] dt-bindings: i2c: Add FSI-attached I2C master dt binding documentation Eddie James
2018-05-29 22:24 ` [PATCH v7 2/7] drivers/i2c: Add FSI-attached I2C master algorithm Eddie James
2018-05-29 23:27 ` Randy Dunlap
2018-05-29 23:42 ` Andy Shevchenko
2018-05-30 15:40 ` Eddie James
2018-05-29 22:24 ` [PATCH v7 3/7] drivers/i2c: Add port structure to FSI algorithm Eddie James
2018-05-29 23:19 ` Andy Shevchenko
2018-05-30 15:47 ` Eddie James
2018-05-30 21:16 ` Benjamin Herrenschmidt [this message]
2018-05-31 14:18 ` Eddie James
2018-05-30 21:27 ` Andy Shevchenko
2018-05-30 21:28 ` Andy Shevchenko
2018-05-30 22:34 ` Benjamin Herrenschmidt
2018-05-31 6:21 ` Andy Shevchenko
2018-05-30 15:49 ` Eddie James
2018-05-29 22:24 ` [PATCH v7 4/7] drivers/i2c: Add abort and hardware reset procedures Eddie James
2018-05-30 0:20 ` Andy Shevchenko
2018-05-29 22:24 ` [PATCH v7 5/7] drivers/i2c: Add transfer implementation for FSI algorithm Eddie James
2018-05-30 0:08 ` Andy Shevchenko
2018-05-30 20:53 ` Eddie James
2018-05-29 22:24 ` [PATCH v7 6/7] drivers/i2c: Add I2C master locking to " Eddie James
2018-05-29 22:24 ` [PATCH v7 7/7] drivers/i2c: Add bus recovery for " Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8aaa7fa9874bf140354964535ce5cf023012c3f4.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.vnet.ibm.com \
--cc=eajames@us.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).