From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Frank Wunderlich <linux@fw-web.de>, linux-mediatek@lists.infradead.org
Cc: devicetree@vger.kernel.org,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
"Wenbin Mei" <wenbin.mei@mediatek.com>,
"Sam Shih" <Sam.Shih@mediatek.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Chaotian Jing" <chaotian.jing@mediatek.com>
Subject: Re: [PATCH v5 1/6] dt-bindings: mmc: mtk-sd: Set clocks based on compatible
Date: Fri, 28 Oct 2022 11:24:57 +0200 [thread overview]
Message-ID: <8adb643e-9c0e-2870-fdbe-0c6d75fbc63e@collabora.com> (raw)
In-Reply-To: <20221025132953.81286-2-linux@fw-web.de>
Il 25/10/22 15:29, Frank Wunderlich ha scritto:
> From: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
> The binding was describing a single clock list for all platforms, but
> that's not really suitable:
>
> Most platforms using at least 2 clocks (source, hclk), some of them
> a third "source_cg". Mt2712 requires an extra 'bus_clk' on some of
> its controllers, while mt8192 requires 8 clocks.
>
> Move the clock definitions inside if blocks that match on the
> compatibles.
>
> I used Patch from Nícolas F. R. A. Prado and modified it to not using
> "not" statement.
>
> Fixes: 59a23395d8aa ("dt-bindings: mmc: Add support for MT8192 SoC")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2022-10-28 9:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 13:29 [PATCH v5 0/6] Add mmc-support for mt7986 Frank Wunderlich
2022-10-25 13:29 ` [PATCH v5 1/6] dt-bindings: mmc: mtk-sd: Set clocks based on compatible Frank Wunderlich
2022-10-28 9:24 ` AngeloGioacchino Del Regno [this message]
2022-10-25 13:29 ` [PATCH v5 2/6] dt-bindings: mmc: Add support for Mediatek MT7986 Frank Wunderlich
2022-10-25 13:51 ` Krzysztof Kozlowski
2022-10-28 9:25 ` AngeloGioacchino Del Regno
2022-10-25 13:29 ` [PATCH v5 3/6] arm64: dts: mediatek: mt2712e: swap last 2 clocks to match binding Frank Wunderlich
2022-10-28 9:25 ` AngeloGioacchino Del Regno
2022-10-25 13:29 ` [PATCH v5 4/6] arm64: dts: mt8183: drop drv-type from mmc-node Frank Wunderlich
2022-10-27 8:01 ` AngeloGioacchino Del Regno
2022-10-25 13:29 ` [PATCH v5 5/6] arm64: dts: mt7622: drop r_smpl property from mmc node Frank Wunderlich
2022-10-27 8:01 ` AngeloGioacchino Del Regno
2022-10-25 13:29 ` [PATCH v5 6/6] mmc: mediatek: add support for MT7986 SoC Frank Wunderlich
2022-10-26 11:25 ` [PATCH v5 0/6] Add mmc-support for mt7986 Ulf Hansson
2022-11-08 18:34 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8adb643e-9c0e-2870-fdbe-0c6d75fbc63e@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Sam.Shih@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@fw-web.de \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wenbin.mei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).