From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D924FA3745 for ; Fri, 28 Oct 2022 09:25:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230136AbiJ1JZk (ORCPT ); Fri, 28 Oct 2022 05:25:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230088AbiJ1JZN (ORCPT ); Fri, 28 Oct 2022 05:25:13 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C84A75FCD; Fri, 28 Oct 2022 02:25:02 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 652266602910; Fri, 28 Oct 2022 10:25:00 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1666949101; bh=2bIhaQBUmBagbZkcCfQYz81lwmySMXrFscfo52gtVRY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=cqy0A/x9OWYhJT94GG1oWVGElLve88xG2bRickgsjeuqW8Smq+XthNAvn6aPDNkgq Vr0R61BN0q6XQDo90RYsIdecOmKlTppC7WhRSf2A7Xdwhs+v2P0sptLIvl4iGmJFf8 JImafWgy3puPOaZeNO/7hoe+iDuFfA6tRB2L7+Se01jtMayD1pg+s/jMzJYtBD/cZn knn+UhSc1le9C8gGW1vijVDCGwMyebspnBzIGcZeVOTE29ZPOqI8TncCT396Db2KHB TZ1hIQPdl3cAJi/nD8HkXuvqmAn4noDb0K7yzJqwuCFcxBF4iBUDK6QY62jwp51KR3 747fObHVRLuXg== Message-ID: <8adb643e-9c0e-2870-fdbe-0c6d75fbc63e@collabora.com> Date: Fri, 28 Oct 2022 11:24:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v5 1/6] dt-bindings: mmc: mtk-sd: Set clocks based on compatible Content-Language: en-US To: Frank Wunderlich , linux-mediatek@lists.infradead.org Cc: devicetree@vger.kernel.org, Ulf Hansson , =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Wenbin Mei , Sam Shih , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Rob Herring , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Matthias Brugger , Chaotian Jing References: <20221025132953.81286-1-linux@fw-web.de> <20221025132953.81286-2-linux@fw-web.de> From: AngeloGioacchino Del Regno In-Reply-To: <20221025132953.81286-2-linux@fw-web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Il 25/10/22 15:29, Frank Wunderlich ha scritto: > From: Nícolas F. R. A. Prado > > The binding was describing a single clock list for all platforms, but > that's not really suitable: > > Most platforms using at least 2 clocks (source, hclk), some of them > a third "source_cg". Mt2712 requires an extra 'bus_clk' on some of > its controllers, while mt8192 requires 8 clocks. > > Move the clock definitions inside if blocks that match on the > compatibles. > > I used Patch from Nícolas F. R. A. Prado and modified it to not using > "not" statement. > > Fixes: 59a23395d8aa ("dt-bindings: mmc: Add support for MT8192 SoC") > Signed-off-by: Nícolas F. R. A. Prado > Signed-off-by: Frank Wunderlich > Reviewed-by: Krzysztof Kozlowski Reviewed-by: AngeloGioacchino Del Regno