Re: [PATCH v13 08/10] clk: nuvoton: Add clock driver for ma35d1 clock controller

[Jacky Huang <ychuang570808@gmail.com>]

On 2023/6/13 上午 10:16, Stephen Boyd wrote:
> Quoting Jacky Huang (2023-06-12 18:37:31)
>> On 2023/6/13 上午 09:02, Stephen Boyd wrote:
>>> Quoting Jacky Huang (2023-06-04 21:07:47)
>>>> diff --git a/drivers/clk/nuvoton/clk-ma35d1-divider.c b/drivers/clk/nuvoton/clk-ma35d1-divider.c
>>>> +                                           int num_pdata)
>>>> +{
>>>> +       return clk_hw_register_mux_parent_data(dev, name, pdata, num_pdata,
>>>> +                                              CLK_SET_RATE_NO_REPARENT, reg, shift,
>>>> +                                              width, 0, &ma35d1_lock);
>>>> +}
>>>> +
>>>> +static struct clk_hw *ma35d1_clk_mux(struct device *dev, const char *name,
>>>> +                                    void __iomem *reg, u8 shift, u8 width,
>>>> +                                    const char *const *parents, int num_parents)
>>> Please don't use string arrays for parent descriptions. Everything
>>> should use clk_parent_data or direct clk_hw pointers.
>> I will use clk_parent_data instead of strings.
>>
> When you use clk_parent_data, just don't set anything for the "dummy"
> clks besides a -1 .index to indicate there isn't a parent for that
> entry.


Okay, thank you for the reminder.

Best Regards,
Jacky Huang