* [PATCH] dt-bindings: clock: brcm,iproc-clocks: fix armpll properties
@ 2021-08-19 5:29 Rafał Miłecki
2021-08-22 10:30 ` Florian Fainelli
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rafał Miłecki @ 2021-08-19 5:29 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, linux-clk, Rob Herring,
Florian Fainelli
Cc: Ray Jui, Scott Branden, bcm-kernel-feedback-list, devicetree,
linux-arm-kernel, Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
armpll clocks (available on Cygnus and Northstar Plus) are simple clocks
with no cells. Adjust binding props #clock-cells and clock-output-names
to handle them.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
.../bindings/clock/brcm,iproc-clocks.yaml | 27 +++++++++++++++++--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/brcm,iproc-clocks.yaml b/Documentation/devicetree/bindings/clock/brcm,iproc-clocks.yaml
index 1174c9aa9934..5ad147d265e6 100644
--- a/Documentation/devicetree/bindings/clock/brcm,iproc-clocks.yaml
+++ b/Documentation/devicetree/bindings/clock/brcm,iproc-clocks.yaml
@@ -61,13 +61,30 @@ properties:
maxItems: 1
'#clock-cells':
- const: 1
+ true
clock-output-names:
minItems: 1
maxItems: 45
allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - brcm,cygnus-armpll
+ - brcm,nsp-armpll
+ then:
+ properties:
+ '#clock-cells':
+ const: 0
+ else:
+ properties:
+ '#clock-cells':
+ const: 1
+ required:
+ - clock-output-names
- if:
properties:
compatible:
@@ -358,7 +375,6 @@ required:
- reg
- clocks
- '#clock-cells'
- - clock-output-names
additionalProperties: false
@@ -392,3 +408,10 @@ examples:
clocks = <&osc2>;
clock-output-names = "keypad", "adc/touch", "pwm";
};
+ - |
+ arm_clk@0 {
+ #clock-cells = <0>;
+ compatible = "brcm,nsp-armpll";
+ clocks = <&osc>;
+ reg = <0x0 0x1000>;
+ };
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: clock: brcm,iproc-clocks: fix armpll properties
2021-08-19 5:29 [PATCH] dt-bindings: clock: brcm,iproc-clocks: fix armpll properties Rafał Miłecki
@ 2021-08-22 10:30 ` Florian Fainelli
2021-08-23 18:24 ` Rob Herring
2021-08-29 6:45 ` Stephen Boyd
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2021-08-22 10:30 UTC (permalink / raw)
To: Rafał Miłecki, Michael Turquette, Stephen Boyd,
linux-clk, Rob Herring, Florian Fainelli
Cc: Ray Jui, Scott Branden, bcm-kernel-feedback-list, devicetree,
linux-arm-kernel, Rafał Miłecki
On 8/19/2021 7:29 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> armpll clocks (available on Cygnus and Northstar Plus) are simple clocks
> with no cells. Adjust binding props #clock-cells and clock-output-names
> to handle them.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: clock: brcm,iproc-clocks: fix armpll properties
2021-08-19 5:29 [PATCH] dt-bindings: clock: brcm,iproc-clocks: fix armpll properties Rafał Miłecki
2021-08-22 10:30 ` Florian Fainelli
@ 2021-08-23 18:24 ` Rob Herring
2021-08-29 6:45 ` Stephen Boyd
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2021-08-23 18:24 UTC (permalink / raw)
To: Rafał Miłecki
Cc: bcm-kernel-feedback-list, linux-clk, Rob Herring,
linux-arm-kernel, devicetree, Rafał Miłecki,
Florian Fainelli, Ray Jui, Michael Turquette, Scott Branden,
Stephen Boyd
On Thu, 19 Aug 2021 07:29:18 +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> armpll clocks (available on Cygnus and Northstar Plus) are simple clocks
> with no cells. Adjust binding props #clock-cells and clock-output-names
> to handle them.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> .../bindings/clock/brcm,iproc-clocks.yaml | 27 +++++++++++++++++--
> 1 file changed, 25 insertions(+), 2 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: clock: brcm,iproc-clocks: fix armpll properties
2021-08-19 5:29 [PATCH] dt-bindings: clock: brcm,iproc-clocks: fix armpll properties Rafał Miłecki
2021-08-22 10:30 ` Florian Fainelli
2021-08-23 18:24 ` Rob Herring
@ 2021-08-29 6:45 ` Stephen Boyd
2 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2021-08-29 6:45 UTC (permalink / raw)
To: Florian Fainelli, Michael Turquette, zajec5, Rob Herring,
linux-clk
Cc: Ray Jui, Scott Branden, bcm-kernel-feedback-list, devicetree,
linux-arm-kernel, rafal
>
> armpll clocks (available on Cygnus and Northstar Plus) are simple clocks
> with no cells. Adjust binding props #clock-cells and clock-output-names
> to handle them.
>
Applied to clk-next
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-29 6:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-19 5:29 [PATCH] dt-bindings: clock: brcm,iproc-clocks: fix armpll properties Rafał Miłecki
2021-08-22 10:30 ` Florian Fainelli
2021-08-23 18:24 ` Rob Herring
2021-08-29 6:45 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).