From: Florian Fainelli <f.fainelli@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"William Zhang" <william.zhang@broadcom.com>,
"Linux ARM List" <linux-arm-kernel@lists.infradead.org>
Cc: Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
joel.peshkin@broadcom.com, dan.beygelman@broadcom.com,
kursad.oney@broadcom.com, f.fainelli@gmail.com,
anand.gore@broadcom.com, Arnd Bergmann <arnd@arndb.de>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Olof Johansson <olof@lixom.net>, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
soc@kernel.org
Subject: Re: [PATCH v2 2/8] ARM: dts: Move BCM963138DVT board dts to ARCH_BCMBCA
Date: Wed, 13 Jul 2022 09:35:23 -0700 [thread overview]
Message-ID: <8b11eac7-cabe-a0bc-061f-7b9936c3696f@gmail.com> (raw)
In-Reply-To: <304678bb-f49c-9c3b-e15e-df6c9e8a4ea2@gmail.com>
On 7/13/22 08:26, Rafał Miłecki wrote:
> On 7.07.2022 09:00, William Zhang wrote:
>> Use CONFIG_ARCH_BCMBCA to build all the BCMBCA SoC dts and remove
>> CONFIG_ARCH_BCM_63XX from the makefile
>>
>> Signed-off-by: William Zhang <william.zhang@broadcom.com>
>> ---
>>
>> (no changes since v1)
>>
>> arch/arm/boot/dts/Makefile | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 38d9c60aece7..1bf8e2f8ee68 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -147,8 +147,6 @@ dtb-$(CONFIG_ARCH_BCM_53573) += \
>> bcm47189-luxul-xap-810.dtb \
>> bcm47189-tenda-ac9.dtb \
>> bcm947189acdbmr.dtb
>> -dtb-$(CONFIG_ARCH_BCM_63XX) += \
>> - bcm963138dvt.dtb
>> dtb-$(CONFIG_ARCH_BCM_CYGNUS) += \
>> bcm911360_entphn.dtb \
>> bcm911360k.dtb \
>> @@ -184,6 +182,7 @@ dtb-$(CONFIG_ARCH_BRCMSTB) += \
>> bcm7445-bcm97445svmb.dtb
>> dtb-$(CONFIG_ARCH_BCMBCA) += \
>> bcm947622.dtb \
>> + bcm963138dvt.dtb \
>> bcm963148.dtb \
>> bcm963178.dtb \
>> bcm96756.dtb \
>
> Do we want to mix all that DT files? Are ARCH_BCM_63XX (ex-)users
> interested in compiling all of them?
>
> For IPROC SoCs we have separated symbols: ARCH_BCM_CYGNUS / ARCH_BCM_HR2
> / ARCH_BCM_NSP / ARCH_BCM_5301X and we compile arch specific DT files
> only.
I am fine with that and build systems (buildroot and OpenWrt at least)
typically offer a way to produce a device specific image that will
contain a single DTB fit for the target device.
What we would be optimizing for would be build time vs. coverage, as a
maintainer I favor coverage as it allows me to build everyone in one
sweep. We could make the building of the 63138 conditional upon
BCMBCA_CORTEXA9 if that bothers you.
--
Florian
next prev parent reply other threads:[~2022-07-13 16:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 7:00 [PATCH v2 0/8] arm: bcmbca: Move BCM63138 SoC support under ARCH_BCMBCA William Zhang
2022-07-07 7:00 ` [PATCH v2 1/8] dt-bindings: arm: add BCM63138 SoC William Zhang
2022-07-08 20:58 ` Florian Fainelli
2022-07-07 7:00 ` [PATCH v2 2/8] ARM: dts: Move BCM963138DVT board dts to ARCH_BCMBCA William Zhang
2022-07-08 20:59 ` Florian Fainelli
2022-07-13 15:26 ` Rafał Miłecki
2022-07-13 16:35 ` Florian Fainelli [this message]
2022-07-07 7:00 ` [PATCH v2 3/8] ARM: dts: update dts files for bcmbca SoC BCM63138 William Zhang
2022-07-08 20:59 ` Florian Fainelli
2022-07-07 7:00 ` [PATCH v2 4/8] ARM: dts: Add BCM63138 generic board dts William Zhang
2022-07-08 21:00 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b11eac7-cabe-a0bc-061f-7b9936c3696f@gmail.com \
--to=f.fainelli@gmail.com \
--cc=anand.gore@broadcom.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.beygelman@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=joel.peshkin@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kursad.oney@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=william.zhang@broadcom.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).