public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Nikita Travkin <nikita@trvn.ru>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: cros-qcom-dts-watchers@chromium.org,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: qcom: acer-aspire1: Add sound
Date: Tue, 31 Oct 2023 12:26:50 +0500	[thread overview]
Message-ID: <8b13ec027d960a09aee9434055a12e15@trvn.ru> (raw)
In-Reply-To: <db624c01-a48c-4a8f-b9ea-548b25aa3091@linaro.org>

Konrad Dybcio писал(а) 31.10.2023 02:51:
> On 30.10.2023 22:50, Konrad Dybcio wrote:
>> On 27.10.2023 16:42, Nikita Travkin wrote:
>>> This laptop has two i2s speakers; an i2s audio codec for the headset
>>> jack; two DMIC microphones in the lid and the displayport audio channel.
>>>
>>> This commit adds the audio node that describes all of the above with the
>>> exception of the DMICs that require in-SoC digital codec to be brought
>>> up, which will be done later.
>>>
>>> Note that the displayport channel is connected here for completeness,
>>> but the displayport can't be used yet since the HPD signal is created by
>>> the embedded controller, which will be added later.
>>>
>>> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
>>> ---
>> [...]
>>
>>
>>> +		primary-tx-dai-link {
>>> +			link-name = "Primary MI2S Capture";
>>> +
>>> +			cpu {
>>> +				sound-dai = <&q6afedai PRIMARY_MI2S_TX>;
>>> +			};
>>> +
>>> +			platform {
>>> +				sound-dai = <&q6routing>;
>>> +			};
>>> +
>>> +			codec {
>>> +				sound-dai = <&alc5682 0>;
>> Both RX and TX going to 5862 interface?
> interface1*

Yes, indeed. The codec has a single i2s with rx and tx, and
shared i2s clocks. They are connected to the prim i2s.

Codec playback is headphone jack, and capture is headset
mic. It could have also been the lid dmics, like on trogdor
but 2/3 describes that sad story...

Nikita

>>
>> Konrad

  reply	other threads:[~2023-10-31  7:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-27 14:42 [PATCH 0/3] sc7180-acer-aspire1: Add sound Nikita Travkin
2023-10-27 14:42 ` [PATCH 1/3] arm64: dts: qcom: acer-aspire1: Enable RTC Nikita Travkin
2023-10-30 21:47   ` Konrad Dybcio
2023-10-30 21:55     ` Doug Anderson
2023-10-31  7:18       ` Nikita Travkin
2023-10-27 14:42 ` [PATCH 2/3] arm64: dts: qcom: acer-aspire1: Correct audio codec definition Nikita Travkin
2023-10-30 21:48   ` Konrad Dybcio
2023-10-31  7:20     ` Nikita Travkin
2023-10-31 10:06       ` Konrad Dybcio
2023-10-31 10:48         ` Nikita Travkin
2023-10-31 10:58           ` Konrad Dybcio
2023-10-27 14:42 ` [PATCH 3/3] arm64: dts: qcom: acer-aspire1: Add sound Nikita Travkin
2023-10-30 21:50   ` Konrad Dybcio
2023-10-30 21:51     ` Konrad Dybcio
2023-10-31  7:26       ` Nikita Travkin [this message]
2023-10-31 10:07         ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b13ec027d960a09aee9434055a12e15@trvn.ru \
    --to=nikita@trvn.ru \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox