From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED6BDEB64DD for ; Sun, 9 Jul 2023 17:28:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229868AbjGIR26 (ORCPT ); Sun, 9 Jul 2023 13:28:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230114AbjGIR25 (ORCPT ); Sun, 9 Jul 2023 13:28:57 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8D34FA for ; Sun, 9 Jul 2023 10:28:55 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-4f76a0a19d4so5430480e87.2 for ; Sun, 09 Jul 2023 10:28:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688923734; x=1691515734; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0dKYNbBXcnp2npYERmD6OwPGyF18Ls7/g1iPD2dIqkc=; b=dfvQYsS7R+9f1XZdiGS878gaVCwz8HtDNvKnKs0ASwuLeupgac1jJp7J9xH4GzjbAY NQh0ZJIJbNgu9ulCqAlxsRu5ytNxmmDT+J2ghMVKnTLbPvRujFaZbfUFFvuJh5UdRlLj 1d5kXM3W/Jmyj6N0q3TJhydMquk1WYpfx7L4R5goXwCW24P4fAZ9fXPwATcnY7OQe5gE D28Sy29i3ySLj8RGkJNV+aSpm9IszgF4mLHoHl0IJ6zCdgdUNPA0MIIr87CSquaofV69 OSFE6YPYLYDiBkzahm+h0QNSD1s9gKwzLgN0IH2urcw0C+zvQu46Qb/9aSwBEOqKRJ1r oUqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688923734; x=1691515734; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0dKYNbBXcnp2npYERmD6OwPGyF18Ls7/g1iPD2dIqkc=; b=cS2fIUtXOyGeecoz44GC8mBH19vaVrnUjlCXFaq7Mx4c7JjVsOmKXY8GPzQWcjHiYL fHGRiZdHyskXrYXOnMeSQVRkCKO0rABeowCAKcoIsyTxkvjBoyzTTve2Nj6swX7yx0C2 Z2mktLD9NXYX0oOjCA6qvsFyVyoGB2yT2qYqtTKqvDk82pKyWyin7ScNJIW53J2YcmfQ M1J84fZQUnuSfdWWmfT3DbCYnv4xMRjFg4KyZ+ohcQpW7oRtW8hJFl/5IKnROeHh4Zj2 oW8PRZ26pC0/kT120VsWgigWYvwsLFQGcOKoqqm4Rq+XMUrGTdJjzwnyQcCyPRrwILPU pMYQ== X-Gm-Message-State: ABy/qLYM3ROfqLl1BGCKy+J6Rt+ZvmJsbqcSYrPkzL+ymVv5m4lp7E3B AE5H0IStmBLgpCv0UiAdAv1B2Q== X-Google-Smtp-Source: APBJJlHpqhfp6mspgLh/7s1bioqqe7qjN0nmeg08p4aZ9KLzrTcfmxw29nR5V2f5KNKf7t9FIuexLQ== X-Received: by 2002:a05:6512:3d14:b0:4fb:8afa:4dc9 with SMTP id d20-20020a0565123d1400b004fb8afa4dc9mr9176209lfv.49.1688923733365; Sun, 09 Jul 2023 10:28:53 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id n2-20020aa7c782000000b0051de3e1323dsm4641086eds.95.2023.07.09.10.28.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 Jul 2023 10:28:52 -0700 (PDT) Message-ID: <8b2dd686-382a-f490-7b6e-9603d939bad7@linaro.org> Date: Sun, 9 Jul 2023 19:28:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 11/11] dt-bindings: iio: remove QCOM ADC files from iio folder Content-Language: en-US To: Jishnu Prakash , agross@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linus.walleij@linaro.org, Jonathan.Cameron@huawei.com, sboyd@kernel.org, dmitry.baryshkov@linaro.org, quic_subbaram@quicinc.com, quic_collinsd@quicinc.com, quic_kamalw@quicinc.com, quic_jestar@quicinc.com, marijn.suijten@somainline.org, andriy.shevchenko@linux.intel.com, Bjorn Andersson , Konrad Dybcio , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org Cc: linux-arm-msm-owner@vger.kernel.org References: <20230708072835.3035398-1-quic_jprakash@quicinc.com> <20230708072835.3035398-12-quic_jprakash@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20230708072835.3035398-12-quic_jprakash@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/07/2023 09:28, Jishnu Prakash wrote: > Now that the ADC dt-binding paths have been updated everywhere > to use the files copied to the 'iio/adc' folder, remove them > from the 'iio' folder. > > Signed-off-by: Jishnu Prakash > --- Nothing this was explained in previous patches... We should not have to read patchset from the end to understand what is happening here. Anyway, your commits lack rationale why this is done. Without it, this is pure churn which breaks users. ABI breaks need to be explained in the commit msg and come with some reason. ... > -/* 400k pull-up3 */ > -#define ADC5_GEN3_AMUX1_THM_400K_PU 0x64 > -#define ADC5_GEN3_AMUX2_THM_400K_PU 0x65 > -#define ADC5_GEN3_AMUX3_THM_400K_PU 0x66 > -#define ADC5_GEN3_AMUX4_THM_400K_PU 0x67 > -#define ADC5_GEN3_AMUX5_THM_400K_PU 0x68 > -#define ADC5_GEN3_AMUX6_THM_400K_PU 0x69 > -#define ADC5_GEN3_AMUX1_GPIO_400K_PU 0x6a > -#define ADC5_GEN3_AMUX2_GPIO_400K_PU 0x6b > -#define ADC5_GEN3_AMUX3_GPIO_400K_PU 0x6c > -#define ADC5_GEN3_AMUX4_GPIO_400K_PU 0x6d > - > -/* 1/3 Divider */ > -#define ADC5_GEN3_AMUX1_GPIO_DIV3 0x8a > -#define ADC5_GEN3_AMUX2_GPIO_DIV3 0x8b > -#define ADC5_GEN3_AMUX3_GPIO_DIV3 0x8c You just added these defines in previous patches. Don't add them to incorrect places just to fix it second later. Best regards, Krzysztof