From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76260388; Tue, 16 Jan 2024 02:00:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=feathertop.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=feathertop.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=feathertop.org header.i=@feathertop.org header.b="nQp7+hD1"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Uf9q2wMC" Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 5FB0A5C0178; Mon, 15 Jan 2024 21:00:25 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 15 Jan 2024 21:00:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=feathertop.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm2; t=1705370425; x=1705456825; bh=2Z1qmxEMsTLQKMDBfJ+3O0kjmLD/ZIDW rrbu4Nd1JY8=; b=nQp7+hD1mEDFNO9npIAC09Ca9w/EUlHo5mORB4C09PhCzBaN vPaMLM3XpxZ0mdePdFX9F+cVNHRM0YuecJV9brXIQHCtMh+71H8sVoBCkzLvTi1E HIGouJJSU94nSPb8PgY4lSppEnL4x4Z5WmKAKB+KTejQ/zFJIyfF0h97Oc67J590 pKC3Mo88Iao1rb6t1tDJQ/71TtBRBRaHRrWpO+LjLKuQiwdQ0t0oWs+saA3r0F6d BbOqtf1QSIlQiijNOhr57KA1PZpp2jyl50pSO+BIM3+yGk/jJkRmRgZ2mfep/NtA lpLAqIrKmXN3Lr15z64O1RVVMxUwxZ7HWgfuww== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1705370425; x= 1705456825; bh=2Z1qmxEMsTLQKMDBfJ+3O0kjmLD/ZIDWrrbu4Nd1JY8=; b=U f9q2wMCYiBq/sv/XZ0oWHcrEPi5NNNjVQNkEkxP4pvGO8hOGUyCunIDIY3S75nCs TiDPxJXJVckT4/Lmwb8o3bKFhs1k93/585YD/GN9LX5JV4po2kqLNAzh1JatpmpS ahxvTOayTo6mv7aVBL56W7dHsJ1HZon//HO1LgRgaKXgLfE4MLj4FY848T1Kul5+ nI8YI/wrNr5/r4HWZa4CjwT3K9Z0WNe8pFb+9f1w1EFFTHA0I3UhZHVQKrd14YSX 0uigaULCZeMy0ilwADhDb3YVIdcMmRib1ktFD2RC25B9T869M8TL5sORW+eTnRbx AGjRzdLOusHM1liQpc1bA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdejvddggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtvdejnecuhfhrohhmpefvihhm ucfnuhhnnhcuoehtihhmsehfvggrthhhvghrthhophdrohhrgheqnecuggftrfgrthhtvg hrnhepjeekhfeikeffgfeuvdefgfehudevffeiudeiudfgveevudeukeetveeiueehtedv necuffhomhgrihhnpehlihhnrghrohdrohhrghdpihhnfhhrrgguvggrugdrohhrghenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehtihhmsehf vggrthhhvghrthhophdrohhrgh X-ME-Proxy: Feedback-ID: i1f8241ce:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 15 Jan 2024 21:00:18 -0500 (EST) Message-ID: <8b31ae29-b88b-4ded-95b4-c2d9bbad24e1@feathertop.org> Date: Tue, 16 Jan 2024 13:00:15 +1100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dt-bindings: rockchip: Fix Hardkernel ODROID-M1 board bindings Content-Language: en-US To: Krzysztof Kozlowski , KyuHyuk Lee , Rob Herring Cc: Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Chris Morgan , Tianling Shen , Jagan Teki , Ondrej Jirman , Andy Yan , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240115145142.6292-1-lee@kyuhyuk.kr> From: Tim Lunn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/16/24 01:58, Krzysztof Kozlowski wrote: > On 15/01/2024 15:51, KyuHyuk Lee wrote: >> The vendor in ODROID-M1 is hardkernel, but it was incorrectly written >> as rockchip. Fixed the vendor prefix correctly. >> >> Signed-off-by: KyuHyuk Lee >> --- >> Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > You need to start testing your patches. Your last M1 fails as well in > multiple places. > > It does not look like you tested the DTS against bindings. Please run > `make dtbs_check W=1` (see > Documentation/devicetree/bindings/writing-schema.rst or > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ > for instructions). > > The DTS change will break the users, so would be nice to mention this in > its commit msg. I notice there are a couple of other boards that incorrectly use rockchip as the vendor also:           - const: rockchip,rk3399-orangepi           - const: rockchip,rk3568-bpi-r2pro Perhaps these should also be fixed at the same time? Regards   Tim > > Best regards, > Krzysztof > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip