From: Alex Elder <elder@ieee.org>
To: David Heidelberg <david@ixit.cz>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Alex Elder <elder@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, ~okias/devicetree@lists.sr.ht,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: net: qcom,ipa: describe IPA v4.5 interconnects
Date: Thu, 21 Oct 2021 08:51:08 -0500 [thread overview]
Message-ID: <8b425afc-55ec-e1d1-4a09-31e7aa216c58@ieee.org> (raw)
In-Reply-To: <20211020225435.274628-1-david@ixit.cz>
On 10/20/21 5:54 PM, David Heidelberg wrote:
> IPA v4.5 interconnects was missing from dt-schema, which was trigering
> warnings while validation.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
Sorry about that. This is actually not correct, because
the DTS file is not correct. I've been meaning to fix it
but didn't want to commit the change until I had actually
tested it.
The DTS file was sent out before I had a better understanding
of what it was supposed to represent.
I will put a priority on fixing the DTS file soon.
-Alex
> ---
> Documentation/devicetree/bindings/net/qcom,ipa.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> index b8a0b392b24e..a2835ed52076 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> @@ -95,6 +95,11 @@ properties:
> - description: Path leading to system memory
> - description: Path leading to internal memory
> - description: Path between the AP and IPA config space
> + - items: # IPA v4.5
> + - description: Path leading to system memory region A
> + - description: Path leading to system memory region B
> + - description: Path leading to internal memory
> + - description: Path between the AP and IPA config space
>
> interconnect-names:
> oneOf:
> @@ -105,6 +110,11 @@ properties:
> - const: memory
> - const: imem
> - const: config
> + - items: # IPA v4.5
> + - const: memory-a
> + - const: memory-b
> + - const: imem
> + - const: config
>
> qcom,smem-states:
> $ref: /schemas/types.yaml#/definitions/phandle-array
>
next prev parent reply other threads:[~2021-10-21 13:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 22:54 [PATCH 1/2] dt-bindings: net: qcom,ipa: describe IPA v4.5 interconnects David Heidelberg
2021-10-20 22:54 ` [PATCH 2/2] dt-bindings: net: qcom,ipa: IPA does support up to two iommus David Heidelberg
2021-10-21 13:30 ` Rob Herring
2021-10-21 13:51 ` Alex Elder [this message]
2021-10-21 20:34 ` [PATCH 1/2] dt-bindings: net: qcom,ipa: describe IPA v4.5 interconnects Alex Elder
2021-10-21 20:35 ` Alex Elder
2021-10-21 22:11 ` David Heidelberg
2021-10-26 14:17 ` Alex Elder
2021-10-26 16:34 ` David Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b425afc-55ec-e1d1-4a09-31e7aa216c58@ieee.org \
--to=elder@ieee.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=elder@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~okias/devicetree@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox